From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mengyan1223.wang (mengyan1223.wang [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 9176A3858025 for ; Thu, 24 Feb 2022 17:42:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9176A3858025 Received: from [IPv6:240e:358:1147:5a00:fbe5:ccc7:1e82:c134] (unknown [IPv6:240e:358:1147:5a00:fbe5:ccc7:1e82:c134]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@mengyan1223.wang) by mengyan1223.wang (Postfix) with ESMTPSA id DD0276641D; Thu, 24 Feb 2022 12:42:15 -0500 (EST) Message-ID: <690583191259d02c04c31fee65bd378991aa37a4.camel@mengyan1223.wang> Subject: Re: [PATCH v7 08/12] LoongArch Port: libgcc From: Xi Ruoyao To: xuchenghua@loongson.cn, gcc-patches@gcc.gnu.org Cc: chenglulu@loongson.cn, joseph@codesourcery.com Date: Fri, 25 Feb 2022 01:42:04 +0800 In-Reply-To: <20220212031142.1165933-9-xuchenghua@loongson.cn> References: <20220212031142.1165933-1-xuchenghua@loongson.cn> <20220212031142.1165933-9-xuchenghua@loongson.cn> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3030.0 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2022 17:42:23 -0000 On Sat, 2022-02-12 at 11:11 +0800, xuchenghua@loongson.cn wrote: > +      sc = &rt_->uc.uc_mcontext; Get a warning: In file included from ../../../libgcc/unwind-dw2.c:412: ./md-unwind-support.h: In function ‘loongarch_fallback_frame_state’: ./md-unwind-support.h:55:10: warning: assignment to ‘struct sigcontext *’ from incompatible pointer type ‘mcontext_t *’ [-Wincompatible-pointer-types] 55 | sc = &rt_->uc.uc_mcontext; | ^ Maybe we should just add a cast here like `(struct sigcontext *) &rt_->uc.uc_mcontext` ? -- Xi Ruoyao School of Aerospace Science and Technology, Xidian University