From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 63F683858D38 for ; Thu, 22 Sep 2022 22:18:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 63F683858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663885115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vARveuw6WMHwHXEp6Fy/a91gE/aCO/duuoyUXMFxWo8=; b=cweY1E7R+UOnPGbTkaCUxlIoB8S3c6+wdCyXtficFGVGEUFMgkri/yi0na8qdvuvIq6G8Q tCrcJcTZtE3vwyP2o2wwbWEPD6uYPcQEUhn0sNvmuTG0I/qGTnIatljZM/Qg6LA5odExBP jqrlCkN/TD9HEw+KRM3NdsNBpQSpyHQ= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-265-OVZUYqIcNOuj_hbmiE0uZQ-1; Thu, 22 Sep 2022 18:18:33 -0400 X-MC-Unique: OVZUYqIcNOuj_hbmiE0uZQ-1 Received: by mail-qk1-f199.google.com with SMTP id x22-20020a05620a259600b006b552a69231so7603596qko.18 for ; Thu, 22 Sep 2022 15:18:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=vARveuw6WMHwHXEp6Fy/a91gE/aCO/duuoyUXMFxWo8=; b=sVH0+qWt2XhzEdfx2MJX5cs8+qX3qDGbPxHQd6u+H0z9NXfn9Ip0ZDIosI3wvPj3sM k77HzMLW13t1X1csJy6ABYu4wUGGj1ghu8NTxaDhV8t9Fwr77bXA6NaCVq8jpHR7xL9o rc0MUSajPEKMEG9Ea0Luktu3qTbNkGkCCT9cSco9kFCMSxFxZObNrwMBpAz4628xybm4 V55qftbplNNgKYJvQplDj4xOsQW0JLDVuI2GY8CpjtBoJyBSPPAXbofxr1m61AxS1UR8 kM9hGVh9G0YzWiuHj4d8LGwojXcn5Nql2htNPgwADKE1HAKTcTXhoPwEBmpvigH6Lbvl Y29w== X-Gm-Message-State: ACrzQf34puOBTghEzbMWTRethJO2ZTnHeM+TNPywFdL9GBXWYbcu1VsX bAg8xd905qoShuYpGOeXh7qfzLlVtBtYOL1c6yt552TnWi0vV70RnYIWp5uRy6LaG4Qe1fGcZaP vdSF9i5eoCGTNswt3IA== X-Received: by 2002:ac8:5c50:0:b0:35b:b246:c457 with SMTP id j16-20020ac85c50000000b0035bb246c457mr4641477qtj.128.1663885113266; Thu, 22 Sep 2022 15:18:33 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6kefJBxl09qA81dDa/T0eGnCfgm1SERSeWaLUv0iMgUoeEHSvaPbd1VzC8O2OzMLetRCVzYQ== X-Received: by 2002:ac8:5c50:0:b0:35b:b246:c457 with SMTP id j16-20020ac85c50000000b0035bb246c457mr4641453qtj.128.1663885113007; Thu, 22 Sep 2022 15:18:33 -0700 (PDT) Received: from [192.168.1.101] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id f26-20020a05620a069a00b006cebda00630sm4336694qkh.60.2022.09.22.15.18.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 15:18:32 -0700 (PDT) Message-ID: <6914f74d-0c69-eb2b-36d8-f17a8340bb25@redhat.com> Date: Thu, 22 Sep 2022 18:18:31 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] c++: ICE-on-invalid with designated initializer [PR106983] To: Marek Polacek , GCC Patches References: <20220920210552.835987-1-polacek@redhat.com> From: Jason Merrill In-Reply-To: <20220920210552.835987-1-polacek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/20/22 17:05, Marek Polacek wrote: > We ICE in the code added in r12-7117: type_build_dtor_call gets > the error_mark_node because the type of 'prev' wasn't declared. > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? OK. > PR c++/106983 > > gcc/cp/ChangeLog: > > * typeck2.cc (split_nonconstant_init_1): Check TYPE_P. > > gcc/testsuite/ChangeLog: > > * g++.dg/other/error36.C: New test. > --- > gcc/cp/typeck2.cc | 2 +- > gcc/testsuite/g++.dg/other/error36.C | 13 +++++++++++++ > 2 files changed, 14 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/g++.dg/other/error36.C > > diff --git a/gcc/cp/typeck2.cc b/gcc/cp/typeck2.cc > index 688e9c15326..75fd0e2a9bf 100644 > --- a/gcc/cp/typeck2.cc > +++ b/gcc/cp/typeck2.cc > @@ -597,7 +597,7 @@ split_nonconstant_init_1 (tree dest, tree init, bool last, > if (prev == field_index) > break; > tree ptype = TREE_TYPE (prev); > - if (type_build_dtor_call (ptype)) > + if (TYPE_P (ptype) && type_build_dtor_call (ptype)) > { > tree pcref = build3 (COMPONENT_REF, ptype, dest, prev, > NULL_TREE); > diff --git a/gcc/testsuite/g++.dg/other/error36.C b/gcc/testsuite/g++.dg/other/error36.C > new file mode 100644 > index 00000000000..556287816fd > --- /dev/null > +++ b/gcc/testsuite/g++.dg/other/error36.C > @@ -0,0 +1,13 @@ > +// PR c++/106983 > +// { dg-do compile { target c++20 } } > + > +typedef unsigned long long A; > +typedef union > +{ > + struct B s; // { dg-error "incomplete" } > + A a; > +} U; > +void f (A x, unsigned int b) > +{ > + const U y = {.a = x}; > +} > > base-commit: be60aa5b608b5f09fadfeff852a46589ac311a42