From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: "Martin Liška" <mliska@suse.cz>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2] gcov: Add __gcov_info_to_gdca()
Date: Fri, 23 Jul 2021 08:14:56 +0200 [thread overview]
Message-ID: <694c7258-5c08-a83d-d6e0-785e71120d68@embedded-brains.de> (raw)
In-Reply-To: <d5772dc5-7601-4cdf-3a66-157fd51e2878@suse.cz>
On 23/07/2021 07:31, Martin Liška wrote:
>> write_topn_counters (const struct gcov_ctr_info *ci_ptr,
>> unsigned t_ix,
>> - gcov_unsigned_t n_counts)
>> + gcov_unsigned_t n_counts,
>> + void (*dump) (const void *, unsigned, void *),
>> + void *(*allocate)(unsigned, void *),
>> + void *arg)
>
> I would likely prefer dump_fn and allocate_fn argumen t names.
If I use dump_fn and allocate_fn throughout the code, then several lines
would exceed 79 characters. This needs more vertical space. Should I
still add the _fn postfix?
--
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax: +49-89-18 94 741 - 08
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
next prev parent reply other threads:[~2021-07-23 6:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 20:15 Sebastian Huber
2021-07-23 5:31 ` Martin Liška
2021-07-23 6:10 ` Sebastian Huber
2021-07-23 6:52 ` Martin Liška
2021-07-23 7:06 ` Sebastian Huber
2021-07-23 7:16 ` Martin Liška
2021-07-23 12:01 ` Sebastian Huber
2021-07-23 9:17 ` Sebastian Huber
2021-07-23 9:31 ` Sebastian Huber
2021-07-23 6:14 ` Sebastian Huber [this message]
2021-07-23 6:53 ` Martin Liška
2021-07-23 6:21 ` Sebastian Huber
2021-07-23 6:53 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=694c7258-5c08-a83d-d6e0-785e71120d68@embedded-brains.de \
--to=sebastian.huber@embedded-brains.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).