From: Jeff Law <law@redhat.com>
To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com
Subject: Re: [PATCH] rtl-ssa: Fix updates to call clobbers [PR98403]
Date: Mon, 4 Jan 2021 14:13:05 -0700 [thread overview]
Message-ID: <695fd678-7310-30eb-b208-2412c498e803@redhat.com> (raw)
In-Reply-To: <mptsg7zm86n.fsf@arm.com>
On 12/21/20 9:32 AM, Richard Sandiford wrote:
> In the PR, fwprop was changing a call instruction and tripped
> an assert when trying to update a list of call clobbers.
> There are two ways we could handle this: remove the call clobber
> and then add it back, or assume that the clobber will stay in its
> current place.
>
> At the moment we don't have enough information to safely move
> calls around, so the second approach seems simpler and more
> efficient.
>
> Tested on x86_64-linux-gnu and aarch64-linux-gnu. OK to install?
>
> Richard
>
>
> gcc/
> PR rtl-optimization/98403
> * rtl-ssa/changes.cc (function_info::finalize_new_accesses): Explain
> why we don't remove call clobbers.
> (function_info::apply_changes_to_insn): Don't attempt to add
> call clobbers here.
>
> gcc/testsuite/
> PR rtl-optimization/98403
> * g++.dg/opt/pr98403.C: New test.
OK
jeff
prev parent reply other threads:[~2021-01-04 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 16:32 Richard Sandiford
2021-01-04 21:13 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=695fd678-7310-30eb-b208-2412c498e803@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).