From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by sourceware.org (Postfix) with ESMTPS id C147B3858C39 for ; Tue, 28 Nov 2023 05:05:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C147B3858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C147B3858C39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::235 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701147938; cv=none; b=izQEpC2XG3LO9LbCG5nm1yKkMck4KFskELtr2ykQ8oM2Md10WGUhOJ09BBh5CRv3oIW+QXBWjMBpU6S+oRVUsrPkHiasxQbRBvbvUkzRfqB8xLSTv0jaEgBGhCJcyFiVza2t1HAP0cz2xzTTsylSPLRobtwB73Vp7F83xvlkHy4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701147938; c=relaxed/simple; bh=4WIqWySr7jjGyGXmTSoZv3u7Z8BZYmLj0/ZaT5dHDno=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=d4hjL1jAAmbh5iaWeFBrip5/KQJbVeeLh3RL3FLsObtlXOGBVe87MZFX29ZBvO6bTXg4c7+BrP8zaRQFp90FWvBsoBfaFTj/ckwY4v++cT2n9VizUtqY5N+EfZ1ipZ2+ruFuJqRF4sHVxmdLRuWPgQMprGQ/a3HFLQ2XFfXPgsY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x235.google.com with SMTP id 5614622812f47-3b844357f7cso3193465b6e.1 for ; Mon, 27 Nov 2023 21:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701147936; x=1701752736; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tPut3TNwoA/9gAZ4kMUKwikzvoNwFZW3Kab4/hjlrVc=; b=k8u82IeFgqOON+/AGZ7WI6aOXLX4G8xCocVZOxyRBHdKj5nxU0g29DgGU/ED2iGqob BcUSRLRxOQH2bF2lNvPoS9qRwqwY1jz6BF6RMarIrLmNFbYp7F+ercNOngMVnAmj2YHG wZSo8xcLKYKl2KzFyXXpTzSNMN8ARUnP9Xp3QfG4nR8ePm8pXmuTIQjdJFFQpVRKMKEr kcmmNH4WDtvQlSH5/qZwgcBmG00bMMpujDZgAIHbHJIJSjJRodcE+0e8fTbd6zcQJjjs ShQw2KteHX15b7/itqXaIQEhAjnIBKlPKm7LMwrvQzCjHiC1Zx/tth9UTCnKEEE42C7f 3bfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701147936; x=1701752736; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tPut3TNwoA/9gAZ4kMUKwikzvoNwFZW3Kab4/hjlrVc=; b=SOwkT9h8BBc7kAApxnrOrI99423Sx7CsBubytwuxXwOa8zGL9pmHU8kvSeRJcaBvOL VCCdU8SHnTyD6fV8VNsLOQ/EAnWFs+w/W+NN/MQxDc6u9vrIRmS1USFQmIECy88Jfmpx jwTMzdG8omzYktHPqfqnIo98kwi5hYMdyXyJg4OfXPHA628Apy6kWPbkBPzUUEwF//aj J3OxGR4RoVSu4cZoIXsTu8fsbUiT1SpDQyKxSHpTbduufVyRTa/24Dhm+jPVpiQ/UoZa 3IWVO+XUC/t02QdKE8QyN2T1XWamKCFIO6OU6pkySmLTLcnncQ2ppQucY538AVOFO4de LsDA== X-Gm-Message-State: AOJu0YzeVKygU37n4Q3EfDbrjdXA826nOiylSLYQL1zFaAcRhGA14z7v ugmKV1usgye/Av+0k89cdNk= X-Google-Smtp-Source: AGHT+IHxnGgDA/lhdVhXhJXF/4joMuMikMwqUA4RcWuHzVZ8nlWdXksYDk6FKtW8Pd82ChdyuC8r5w== X-Received: by 2002:a05:6808:1456:b0:3b8:339a:9a85 with SMTP id x22-20020a056808145600b003b8339a9a85mr20935161oiv.5.1701147935895; Mon, 27 Nov 2023 21:05:35 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id x5-20020a631705000000b0056b6d1ac949sm8405951pgl.13.2023.11.27.21.05.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Nov 2023 21:05:35 -0800 (PST) Message-ID: <697a3367-659b-42e9-8ed2-4947fe72ae06@gmail.com> Date: Mon, 27 Nov 2023 22:05:30 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] [ifcvt] if convert x=c ? y+z : y by RISC-V Zicond like insns Content-Language: en-US To: Fei Gao , gcc-patches Cc: Kito Cheng , Palmer Dabbelt References: <20231030072523.26818-1-gaofei@eswincomputing.com> <20231030072523.26818-3-gaofei@eswincomputing.com> <2023103111354257191364@eswincomputing.com> <4c7a3049-f818-45df-8352-71ab12118a95@gmail.com> <20231128104654781897135@eswincomputing.com> From: Jeff Law In-Reply-To: <20231128104654781897135@eswincomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/27/23 19:46, Fei Gao wrote: > On 2023-11-20 14:46  Jeff Law wrote: >> >> >> >> On 10/30/23 21:35, Fei Gao wrote: >> >>>> So just a few notes to further illustrate why I'm currently looking to >>>> take the VRULL+Ventana implementation.  The code above would be much >>>> better handled by just calling noce_emit_cmove.  noce_emit_cmove will go >>>> through the conditional move expander.  So any improvement we make in >>>> the expander "just work" when called from the if-converter. >>> noce_emit_czero is used here to make sure czero insns are emited. >>> noce_emit_cmove includes SFB and Thead movcc, which will take precedence >>> over zicond in RISCV if enabled. Unfortunately we have products with SFB and Zicond >>> both available and saw such conflict. >>> And that is also the reason to add hook TARGET_HAVE_COND_ZERO >>> in [PATCH 1/4] to disallow ineffient code emited by SFB enable and Zicond disabled case. >> I understand what you're trying to do, but I would consider the >> TARGET_HAVE_COND_ZERO fundamentally the wrong approach. > Hi Jeff > > Thanks for your review. I just post the new series. > https://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg327148.html > https://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg327151.html > https://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg327149.html > https://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg327150.html > > TARGET_HAVE_COND_ZERO has been deleted. THanks for the V2. I'll see what I can do with them this week. The series was posted prior to close of stage1, so it can still be integrated into gcc-14 if we get it cleaned up. Jeff