From: Jeff Law <law@redhat.com>
To: Paul Gofman <gofmanp@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix stack pointer handling in ms_hook_prologue functions for i386 target.
Date: Wed, 25 Mar 2020 16:49:51 -0600 [thread overview]
Message-ID: <69d3d4ac4cc52e196ad374dc16225e103ec05c69.camel@redhat.com> (raw)
In-Reply-To: <20200210162241.988175-1-gofmanp@gmail.com>
On Mon, 2020-02-10 at 19:22 +0300, Paul Gofman wrote:
> ChangeLog:
> PR target/91489
> * config/i386/i386.md (simple_return): Also check
> for ms_hook_prologue function attribute.
> * config/i386/i386.c (ix86_can_use_return_insn_p):
> Also check for ms_hook_prologue function attribute.
>
> testsuite/ChangeLog:
> PR target/91489
> * gcc.target/i386/ms_hook_prologue.c: Expand testcase
> to reproduce PR target/91489 issue.
I'm going to queue this for gcc-11. While I realize this is a codegen issue, I'm
not familiar enough with the stdcall conventions to give this the review it would
need at this stage in gcc-10 development.
jeff
>
next prev parent reply other threads:[~2020-03-25 22:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 16:22 Paul Gofman
2020-02-21 9:11 ` Paul Gofman
2020-03-25 14:17 ` Paul Gofman
2020-03-25 22:49 ` Jeff Law [this message]
2020-06-18 17:42 ` Paul Gofman
2020-11-06 22:40 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69d3d4ac4cc52e196ad374dc16225e103ec05c69.camel@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gofmanp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).