From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by sourceware.org (Postfix) with ESMTP id 851CF385E003 for ; Wed, 25 Mar 2020 22:49:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 851CF385E003 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-2NgyNek3P2-MuhTibzTWkw-1; Wed, 25 Mar 2020 18:49:53 -0400 X-MC-Unique: 2NgyNek3P2-MuhTibzTWkw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9E604477; Wed, 25 Mar 2020 22:49:52 +0000 (UTC) Received: from ovpn-114-239.phx2.redhat.com (ovpn-114-239.phx2.redhat.com [10.3.114.239]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4A9C01001938; Wed, 25 Mar 2020 22:49:52 +0000 (UTC) Message-ID: <69d3d4ac4cc52e196ad374dc16225e103ec05c69.camel@redhat.com> Subject: Re: [PATCH] Fix stack pointer handling in ms_hook_prologue functions for i386 target. From: Jeff Law Reply-To: law@redhat.com To: Paul Gofman , gcc-patches@gcc.gnu.org Date: Wed, 25 Mar 2020 16:49:51 -0600 In-Reply-To: <20200210162241.988175-1-gofmanp@gmail.com> References: <20200210162241.988175-1-gofmanp@gmail.com> Organization: Red Hat User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-16.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2020 22:49:58 -0000 On Mon, 2020-02-10 at 19:22 +0300, Paul Gofman wrote: > ChangeLog: > PR target/91489 > * config/i386/i386.md (simple_return): Also check > for ms_hook_prologue function attribute. > * config/i386/i386.c (ix86_can_use_return_insn_p): > Also check for ms_hook_prologue function attribute. > > testsuite/ChangeLog: > PR target/91489 > * gcc.target/i386/ms_hook_prologue.c: Expand testcase > to reproduce PR target/91489 issue. I'm going to queue this for gcc-11. While I realize this is a codegen issue, I'm not familiar enough with the stdcall conventions to give this the review it would need at this stage in gcc-10 development. jeff >