From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id F2E6F3858D35 for ; Thu, 17 Aug 2023 13:44:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F2E6F3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37HCOMef024250; Thu, 17 Aug 2023 13:44:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=Pap1q8JU6Y5lV/Z7xRHSmxfBzPQk7MnaRQbys19vZm8=; b=fkeQvebyrK/k3/peXTDGx0vvMZ8kNVp5AdY0uIy6Oce7WSKLGpo925FlRU3tj7ig+Sge AKfEqFmNoepTjYTSJ1gidTNCfDetaXLC4E6o7Cbo8HwFrcevK3gObaDrSMGAWq14BaEe pvU/tM+Ho3za/KI7FxDKrVimp4DPe8/8Kg0J1eQuWBPb6pbXCWefFj7VHhsowJCS8efc pJXy/AFMl51KsirQDoKGwmm+qjmn2Qfjvtm68MW3MlCujPncBtoOVcQ0W54SSnCSYP7v F29DlWhfDKO1OBU3JPcorReA4TVrXgH068ehM5PCwQqu178Sx+yPc40WqhUzLNHc24/O Og== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3se349hk76-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Aug 2023 13:44:47 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 37HD6NvX038962; Thu, 17 Aug 2023 13:44:46 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2177.outbound.protection.outlook.com [104.47.55.177]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3sey72ua97-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Aug 2023 13:44:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E6bpOWzjiIoKHlZoDsnO0m7VVub/NI2+8H96XTycg5EjT/NR4wzxwGJDMU59VT+2FV3AvU3D3PSbHfuh6VpBg0RjbKk3XlTLMEDLeh+rGZEroKl+46g4xI6v9YC9LpsMJrYnIiX54nKEnlDRtiY70S+7+NYQFPvUqwnJ4N4pkr/RMUiut8/yzSHlYczIEIrSeMh8v0uu5tbV+YxC4GE4aJrYiN35OtRejFvfzmkZfb03wFQRSP/FunttI1bVlMDPbxjAnRGMi6tux1J90LP9HTuOOAEInJxv0vCqs7qf+1eexLBeXzUA0ZxcUtjhgb5eXKuv6ePfe2ZK4C5FBAY5+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pap1q8JU6Y5lV/Z7xRHSmxfBzPQk7MnaRQbys19vZm8=; b=C7B9B89LvJeyKTadPTc+p6Tnn6CwTHZr6N4VCfNHMUaZD7DstjhwUpt92Wi7qf+j82FSryJHURPxf5UTNkfE0PTULc9s5hB2Poyw4XOvJUcHAWXBdqwYup1/RI/L1llrFqUltJVLLw0B9qL9G0FBSN4iPWmhd6wB1HwlWS00XairPeZbKZhsL4ifmQCN0nr9dDIpzGEP+m7FiignNiJ1FJcRRLZqMx502lMFf+5WpQLKfNrQNmS7vHSUTdnq9ZZ6UF1EPHfctcHCEiaqIRseu8TElGSY+nBzvO5FVNry1n3eWzX48QN4GD3YPUeNzvq+i1bWOx4Kcn25i3rtQlz2jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pap1q8JU6Y5lV/Z7xRHSmxfBzPQk7MnaRQbys19vZm8=; b=GqNLkfKrDujpVHsY283yWgGsgUC/YPFqYMQCITuwDkwWc/0p/uv0zzWpLE9+t9WV9h4LotyZEKST/wAaH2zHKirv9tPF8Kc6k1BAMOuP5oR4O51txAwutj+SrCPthW8i7r6QRb42Qh2hoP5txD0kC4zkP6lZu1iybvBkEyJ9Tlw= Received: from CH2PR10MB4344.namprd10.prod.outlook.com (2603:10b6:610:af::19) by BLAPR10MB5044.namprd10.prod.outlook.com (2603:10b6:208:326::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.31; Thu, 17 Aug 2023 13:44:42 +0000 Received: from CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::5afd:d02a:38ef:94ba]) by CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::5afd:d02a:38ef:94ba%7]) with mapi id 15.20.6678.031; Thu, 17 Aug 2023 13:44:42 +0000 From: Qing Zhao To: Kees Cook CC: Joseph Myers , Richard Biener , jakub Jelinek , "gcc-patches@gcc.gnu.org" , Siddhesh Poyarekar , Martin Uecker , "isanbard@gmail.com" Subject: Re: [V2][PATCH 0/3] New attribute "counted_by" to annotate bounds for C99 FAM(PR108896) Thread-Topic: [V2][PATCH 0/3] New attribute "counted_by" to annotate bounds for C99 FAM(PR108896) Thread-Index: AQHZxwwaiTihIsYc/kmfUkC2AXJ+ra/uCg4AgAAS1oCAAHb1gA== Date: Thu, 17 Aug 2023 13:44:42 +0000 Message-ID: <6A031F57-F282-4EDE-BE3F-0F0476A90C00@oracle.com> References: <20230804194431.993958-1-qing.zhao@oracle.com> <202308162226.19D3A36@keescook> <202308162337.11DAF21835@keescook> In-Reply-To: <202308162337.11DAF21835@keescook> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.3) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR10MB4344:EE_|BLAPR10MB5044:EE_ x-ms-office365-filtering-correlation-id: ba5ac8e0-91d3-4079-3e45-08db9f281c2e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 67WlXN7x5of6bSvC+Cq+M6CaF1Wz/McE0/YsRBciqYwgfdqU4TgICgU2T8yZAQNxamZFTY2JXILsowTw9zsOCZr4RqoORKfxGorf4wI71ZpvJgaxJya7/G34RpX3Oe8Nr0JB4ZmqBH1ZkcFBEQcuKlE5mQ/HCY6/AcxbuU4NzcUAQKL/myNUuJxBqCEzkdmljLbqdnUexIb/5p29c13WY3nN/COy8RdSSsYM9HmqYKM5pu2MRuVa8Rox8SG0rAvCKj2eeM2OP+269ks/gnwBxKhGB/EmqjRc37eMOjEajuSY3x6I5nZALOvV2mKQpXQ33xt0kOBOrHB6Ke1/0W5Yss25Q/G6PU2E50alszB6m7auK2et+kFVL7S0Y+quCPv8ZNjmPoz3vNLgQYyvHAUuiV78y1R1niA2Crt1y3jRO6xkPeoA+y5XFeJt09nBlQqrnMgoDDP0+qTYhWQWYX9CqInIouP3A3mZ7P9AYxJlig+HTikKfuNb/JEmH/zDIb+gKOKqSEcfY5jcZD+PuBhEH2CQ4+8BZ5RU/o0M+UMK/nPS1QgkL8+mv2FsRfU45LKkSI5ITFSvsYeKD+byWQm+plnrFtdaZ4JCyj4vOqY+IXLo2UuT07zNmHq8iJeUA3PzkeshE+om2ZC3gKKUyAkORA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR10MB4344.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(376002)(136003)(396003)(39860400002)(366004)(451199024)(1800799009)(186009)(86362001)(33656002)(36756003)(122000001)(38070700005)(38100700002)(2616005)(5660300002)(44832011)(76116006)(66446008)(66556008)(478600001)(6506007)(66476007)(66946007)(316002)(53546011)(91956017)(54906003)(64756008)(6486002)(6916009)(71200400001)(26005)(6512007)(41300700001)(4326008)(8676002)(8936002)(83380400001)(2906002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RS3nwWlEvSAjkAWarZuigwEL8uHa1FyQZ0dV7sveyWueLPC0qhOmAo0MioXm?= =?us-ascii?Q?9PIbrEtO4KRlP81bfUMgAloPwIuEjp/Tk/nG2HUjVUt9WPiAJcIaMTaGJsvy?= =?us-ascii?Q?GAqmI5Aagi28rZCuUSvJU3JrJTZNyxeW5+O3e8Wr/erYf6ZRA8IlyPI2b+/s?= =?us-ascii?Q?FJrzO18tu/q+ESld1xHKNP06IGBKyr7rqwBzFPJYhvTkanAFdc0S5TRZXpAo?= =?us-ascii?Q?Jup9opMRRsT0E/TIE67wPuhV+dFyTqhp0ag53fRm09OUJB+Qi7DyOLBt7n7M?= =?us-ascii?Q?XwuSRdAOhDuhguaxhcXpMecvdKzB4Gy6M3xY7Pm0LibHTJCXQwdn2NZ7Cslg?= =?us-ascii?Q?psg16CIybKyYSWAd6bZUZklDb266IazvL1IOajtg/jgfupLJfgFi1veBw+Nw?= =?us-ascii?Q?ozeziZAYjGQjP+Qby4WAzzeOhFOjZAjnarBSSFJAu6vYd3sp8mvfA0CzdxCO?= =?us-ascii?Q?/zbrRes4TkSJtFYZ726+wFqhjWhFYo3sRhizRlyf8p8f5GZszc4TLzw/SFRq?= =?us-ascii?Q?ViJL2sFyOBIhFFxsi/A453cMXobe2pr7EEQJFcWzLZ26pR/FRUR90Pv7i4gI?= =?us-ascii?Q?6wq1+gCf9+bEvYzd8BVKcgwxnRVxdZUmcvMxhDkEMKrsl6qi6R9Q7SUvATtj?= =?us-ascii?Q?C2dTuMweFFCtQxWfSAcn2Si6H34BaRBl2qtV/yi3fTtEEem0zm1TV7wa7yMI?= =?us-ascii?Q?ED+5mejv5nmcbq+N82EfUI1OFUgp80LxzaPvwCjte105wigiIdMsLtc36Ns8?= =?us-ascii?Q?U9y+8C/yfyZzeUgXr07t+K6uoL7HYoPvWWV3PPccezL6QVWsxVQlJGOsQYeN?= =?us-ascii?Q?TpnaKiuZZyfTb4IVm4qD2j1hr/dfAylsVuY7xlHzgo7vZGGGFmLUv8Wxe2I2?= =?us-ascii?Q?CgjzJBf6F7FLy8YX3ADiZNr1mzjAyvXuXX+QUXI020gS4dAZYSwuDWZG0na2?= =?us-ascii?Q?iUgvokR9j2YCAhEBSUiJ45ZJNU6C5D6V3MBHELlK2qyTEdil+RyH3QH4tMPB?= =?us-ascii?Q?0ZbGHaxwBf4sDb06Si8UmNhsdS7xCjddpDt5cP1LVDgRMx6VuAPA+9fe6UQC?= =?us-ascii?Q?qpnYKrHC615f7Zsw+sfa7Knfr0QMxOmx7Yz/ANh2JtaAX2mYXbl2s2lrIFbr?= =?us-ascii?Q?iV+FhqGExord0jG784HjWF+aC1ZVRfWHpQ4UhlxotqK+snVeOqDWkl+AK8MC?= =?us-ascii?Q?MRFVVOrOd7J7SPtpqTI5m5SuMnP41oI6co4WQa7IF6BIo7SmeCEQUu7OL/NO?= =?us-ascii?Q?1zB/fKBy1oBCGpG4ocduGTdYEuA3CvVuNXxu9gg5QD71n12WiNUjpDePZ+BD?= =?us-ascii?Q?RUwx24XzBRN4mu82nSC4+2DnIEhTwpd8vwym0GSTNtA2i9e+X9UTqC6k5XEx?= =?us-ascii?Q?zMqOExCbjUoAk9XoOmoP1Rs4VGomhNnlMCbG8zS1XTfDyUFL9ZBa5LkMKGaY?= =?us-ascii?Q?S355/YoYSoFboFe5uFav49SZHf6OIdZ90O20FHHh9I03YNpRkvx9P8fDcZ6i?= =?us-ascii?Q?90NYHXHSUFjFpjjjOMggrAZWJlQxeFELUX+uZa+mpx+BsjMjeuB26IytJm/1?= =?us-ascii?Q?Td0PDmz9qJIojP/Ua+iIQS75c+6myuYXN3mV8D87?= Content-Type: text/plain; charset="us-ascii" Content-ID: <8C5FBABE787E074BAA70859F0EFD3751@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?5qxeYmiTlCpcY0uoY+oyr3V6U9Kv5QeMonwBQ5/4TS8+B5Ny1Wjvh6Y2XrVt?= =?us-ascii?Q?0YiPIyV70wPkb7toeCC/45rxc7M3Q5DlSxTJz/BapvTYfFc7/lXCN2NxENoY?= =?us-ascii?Q?vCCvgyitlI04aMwdRoKbJud0OdJvM1x7q76MFbzgDLBlqx03tDHphgbmYflB?= =?us-ascii?Q?pVGA9J4u4Rso9By3ebSQiVnsJa10p2fBoKXMqhJRmhfVVOI1sa/CTdmzEsSJ?= =?us-ascii?Q?xn7GvUCcxTq4sG1flhHdZxTzcIq6zuhSvgmLQEJDD4+Dkm84pJXC9Ky3BjYd?= =?us-ascii?Q?payH/9krDBZ5Vyx/okhm0xBD1Duv2+ahOjA8vB7ILRBEXGjbiEiI5UeBn8Ui?= =?us-ascii?Q?GzaE5JmFZtDwQ10ZXC2Po9dyKQU71WaczAIoK7vLpDIjYfjj3YR/7P9zDf/g?= =?us-ascii?Q?OLjHVQj8Jyc2VNZ8DxautB3ED0cNobWzUANN6HbV42F1Qx974sJz3yR9da2f?= =?us-ascii?Q?qllYVzXRZZoGp9ZhVp2Wo8B7UXSJY5DoWw0HdyfPh4v9Tlc6Na9WKlCBF7qU?= =?us-ascii?Q?viQ3L2HAYBhY2yfsNkEvw7hYC0W9JrlCE8DPiMtM3ZaHxkuojRmT2jsXb+QB?= =?us-ascii?Q?LsJsqMSAwgp7S25PMrLthOSUOx0YNgJV6azslSSMwtD8bEuOFjwwR+4m9OrC?= =?us-ascii?Q?8ngCr72EKqvGnhjlqKwhAfk7ZC2aeLMLBcFHmbi1ZNV7TIuuv84K2LI2pXeL?= =?us-ascii?Q?dxKsoI3pkDsIuaVUkUIk3QTStJjZDmt5Rez6/2D+arA5ls3vvRZeACDxLzno?= =?us-ascii?Q?6Gwu8ThGbLlzXfWW+1V3KS6FqgSOLaCIOMy+qQeHTRQlwV2KlZ6pVl0ULLzI?= =?us-ascii?Q?HluIDlEHKs5GoNR9PIaTwD+AcBwNM/eN8zq6rbtfNWZehOGWC2AidHRR9zKW?= =?us-ascii?Q?rKmBhAh7jXLFkZplQcjAwG1STcAkIKXLNh+/2Z2bQz+DrMuBBEPmmRwghFck?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4344.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba5ac8e0-91d3-4079-3e45-08db9f281c2e X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2023 13:44:42.2800 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WTvYCMD1SobqW2a/X07kxwfrYCyifHfzezJhgvtMIS/U4bnjZSHab9FQkToVGI3YNeE3kbfQPr7hcYb0MQUdGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5044 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-17_07,2023-08-17_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 bulkscore=0 mlxlogscore=890 adultscore=0 suspectscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308170124 X-Proofpoint-GUID: r27qYtt7Ex83FyTpe-GruHxLB3jGGv8R X-Proofpoint-ORIG-GUID: r27qYtt7Ex83FyTpe-GruHxLB3jGGv8R X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Kees, Thanks for the testing case.=20 Yes, I noticed this issue too, and already fixed it in my private branch.=20 With the latest patch, the compilation has no issue: [opc@qinzhao-ol8u3-x86 108896]$ sh t /home/opc/Install/latest-d/bin/gcc -O2 -c -o /dev/null bug.c [opc@qinzhao-ol8u3-x86 108896]$=20 Qing > On Aug 17, 2023, at 2:38 AM, Kees Cook wrote: >=20 > On Wed, Aug 16, 2023 at 10:31:30PM -0700, Kees Cook wrote: >> On Fri, Aug 04, 2023 at 07:44:28PM +0000, Qing Zhao wrote: >>> This is the 2nd version of the patch, per our discussion based on the >>> review comments for the 1st version, the major changes in this version >>=20 >> I've been using Coccinelle to find and annotate[1] structures (193 so >> far...), and I've encountered 2 cases of GCC internal errors. I'm workin= g >> on a minimized test case, but just in case these details are immediately >> helpful, here's what I'm seeing: >=20 > Okay, I got it minimized: >=20 > $ cat poc.c > struct a { > unsigned long c; > char d[] __attribute__((__counted_by__(c))); > } *b; >=20 > void f(long); >=20 > void e(void) { > long g =3D __builtin_dynamic_object_size(b->d, 1); > f(g); > } > $ gcc -O2 -c -o /dev/null poc.c > poc.c: In function 'e': > poc.c:8:6: error: incorrect sharing of tree nodes > 8 | void e(void) { > | ^ > *b.0_1 > _2 =3D &b.0_1->d; > during GIMPLE pass: objsz > poc.c:8:6: internal compiler error: verify_gimple failed > 0xfe97fd verify_gimple_in_cfg(function*, bool, bool) > ../../../../gcc/gcc/tree-cfg.cc:5646 > 0xe84894 execute_function_todo > ../../../../gcc/gcc/passes.cc:2088 > 0xe84dee execute_todo > ../../../../gcc/gcc/passes.cc:2142 >=20 > --=20 > Kees Cook