From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-c1p-023464.sys.comcast.net (resqmta-c1p-023464.sys.comcast.net [IPv6:2001:558:fd00:56::b]) by sourceware.org (Postfix) with ESMTPS id E06653858C66 for ; Thu, 12 Jan 2023 14:17:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E06653858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=comcast.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=comcast.net Received: from resomta-c1p-023266.sys.comcast.net ([96.102.18.234]) by resqmta-c1p-023464.sys.comcast.net with ESMTP id FyAppAyBazoyrFyOcpMa2N; Thu, 12 Jan 2023 14:17:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=20190202a; t=1673533054; bh=i+vhiQxQtAffLNqwPtspInMaiXME3dar8xwIOWv50AU=; h=Received:Received:Content-Type:Mime-Version:Subject:From:Date: Message-Id:To:Xfinity-Spam-Result; b=0kTyJp7UgdnOnNx1qQ7yxI/hy7JrKjuMTY6e+atbyq+YifyttBZ1xZ0TOPnAUZsd0 jC+7P+3MiFqv972r6b5S79n70Us9rRGXk60ch5YSAVoiWAsC8/TXT7ShKdYAi3z0ed NMrXCNSWoui+ImW2Xvf9T7h5tmsby8iBX7ljs81EdCjCZ/g5KBvV7Krv+HlAZisUui H8at1tDjw/UF1gLi4GUP5AwE+tYdyNEl7uRN00iXRaHfxFFlorCQhG9P945+sBM9LX 0ilPHYdzPeCaIh2nOinG34kKDhQSkLgQifvj6XlhfAWFoZliPL9abTWI5vMVEJCD6u 3wr+f3Y8JUjdQ== Received: from smtpclient.apple ([73.60.223.101]) by resomta-c1p-023266.sys.comcast.net with ESMTPSA id FyOZp1hp0xkzwFyOapanfR; Thu, 12 Jan 2023 14:17:34 +0000 X-Xfinity-VAAS: gggruggvucftvghtrhhoucdtuddrgedvhedrleeigdeivdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucevohhmtggrshhtqdftvghsihdpqfgfvfdppffquffrtefokffrnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegtggfuhfgjffevgffkfhfvofesthhqmhdthhdtvdenucfhrhhomheprfgruhhlucfmohhnihhnghcuoehprghulhhkohhnihhnghestghomhgtrghsthdrnhgvtheqnecuggftrfgrthhtvghrnhepveekveelffeliefgiedufeehgeejtdfhgedujeehueekiedtgfetffevgffggfdvnecukfhppeejfedriedtrddvvdefrddutddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghlohepshhmthhptghlihgvnhhtrdgrphhplhgvpdhinhgvthepjeefrdeitddrvddvfedruddtuddpmhgrihhlfhhrohhmpehprghulhhkohhnihhnghestghomhgtrghsthdrnhgvthdpnhgspghrtghpthhtohepgedprhgtphhtthhopehsvghghhgvrheskhgvrhhnvghlrdgtrhgrshhhihhnghdrohhrghdprhgtphhtthhopehrihgthhgrrhgurdhguhgvnhhthhgvrhesghhmrghilhdrtghomhdprhgtphhtthhopehgvghrrghlugesphhfvghifhgvrhdrtghomhdprhgtphhtthhopehgtggtqdhprghttghhvghssehgtggtrdhgnhhurdhorhhg X-Xfinity-VMeta: sc=-100.00;st=legit Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH] wwwdocs: Note that old reload is deprecated From: Paul Koning In-Reply-To: <20230112095059.GZ25951@gate.crashing.org> Date: Thu, 12 Jan 2023 09:17:31 -0500 Cc: Richard Biener , Gerald Pfeifer , gcc-patches@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: <6A51E423-A983-42F1-95BB-FFB495050FE2@comcast.net> References: <20230111151520.GU25951@gate.crashing.org> <20230111183251.GV25951@gate.crashing.org> <20230111192850.GX25951@gate.crashing.org> <9D16702E-DC97-432C-A331-593FE242CE4C@comcast.net> <20230112095059.GZ25951@gate.crashing.org> To: Segher Boessenkool X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Jan 12, 2023, at 4:50 AM, Segher Boessenkool = wrote: >=20 > On Wed, Jan 11, 2023 at 05:07:47PM -0500, Paul Koning wrote: >>> On Jan 11, 2023, at 2:28 PM, Segher Boessenkool = wrote: >>> I would say your predicates are way too lenient here = (general_operand), >>> but this needs more info. A testcase to reproduce the problem, to >>> start with :-) >>=20 >> I'll try to trim it down. >>=20 >> What do you mean "too lenient"? The first input operand (which is = supposed to be the same as the output since the instruction set is = 2-address) is "general_operand". The destination is = "nonimmediate_operand" which fits the constraints applied to it. >=20 > I mean general_operand accepts that sp thing you saw. But your > constraints do not? (I don't know your target well, maybe this isn't > true). Things like this should be sorted out by reload, but you get > better code (and fewer problems ;-) ) if you make code that fits > earlier. The L in LRA means "local": it "just" makes things fit, it > does not emphasise optimising your code. The destination is "nonimmediate_operand" which matches what the machine = actually does. It's like VAX and M68k, instruction operands in general = can be registers, memory references, register indirect or memory = indirect, memory at register with offset, or autoinc/autodec off any = register. As far as operand type is concerned, SP is certainly a valid operand for = an add operation, that isn't the problem. The problem is that it's a = two operand machine: the first operand of the add instruction is both = source and destination. And LRA assigned the source register to be the = destination register as required, but then after doing so it replaced = the destination (an FP reference) by a different register (SP = reference), violating the constraint after having satisfied it earlier. Interesting to know what LRA stands for, I didn't know that. paul