From: Tristan Gingold <gingold@adacore.com>
To: Janne Blomqvist <blomqvist.janne@gmail.com>
Cc: Tobias Burnus <tobias.burnus@physik.fu-berlin.de>,
GCC Patches <gcc-patches@gcc.gnu.org>,
fortran@gcc.gnu.org
Subject: Re: [Patch V2] libgfortran: do not assume libm
Date: Tue, 27 Mar 2012 09:29:00 -0000 [thread overview]
Message-ID: <6C5A80FF-4B39-449A-B015-00D537483F08@adacore.com> (raw)
In-Reply-To: <CAO9iq9GxYzSUeWLY-hua7z1pSYpc5kdTXyYZng9sJRJ-MT+rYg@mail.gmail.com>
On Mar 27, 2012, at 10:38 AM, Janne Blomqvist wrote:
> On Tue, Mar 27, 2012 at 11:01, Tristan Gingold <gingold@adacore.com> wrote:
>> Hi,
>>
>> this patch fixes this issue. Is it OK ?
>
> Ok.
No check-gfortran regressions on x86_64-darwin, committed.
>> Maybe we should include the AC_DEFINE action within GCC_CHECK_MATH_FUNC. Will try to do that.
>
> That looks like a cleaner solution, yes, and less chance for typos to sneak in.
>
>> Sorry for not having noticed this issue before.
>
> No problem. Thanks for fixing it quickly.
You're welcome!
Tristan.
next prev parent reply other threads:[~2012-03-27 9:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 9:49 [Patch] " Tobias Burnus
2012-03-20 9:57 ` Tristan Gingold
2012-03-22 8:30 ` [Patch V2] " Tristan Gingold
2012-03-22 10:07 ` Paolo Bonzini
2012-03-22 20:57 ` Tobias Burnus
2012-03-26 8:44 ` Tristan Gingold
2012-03-26 21:43 ` Janne Blomqvist
2012-03-27 7:51 ` Tristan Gingold
2012-03-27 8:01 ` Tristan Gingold
2012-03-27 8:39 ` Janne Blomqvist
2012-03-27 9:29 ` Tristan Gingold [this message]
2012-03-30 10:22 ` Tristan Gingold
2012-03-30 12:40 ` Paolo Bonzini
2012-04-02 7:47 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6C5A80FF-4B39-449A-B015-00D537483F08@adacore.com \
--to=gingold@adacore.com \
--cc=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias.burnus@physik.fu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).