From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53206 invoked by alias); 12 Dec 2015 08:53:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 53190 invoked by uid 89); 12 Dec 2015 08:53:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 12 Dec 2015 08:53:26 +0000 Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Websense Email Security Gateway with ESMTPS id C6FD5CC9CFF1B; Sat, 12 Dec 2015 08:53:21 +0000 (GMT) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (TLS) id 14.3.235.1; Sat, 12 Dec 2015 08:53:23 +0000 Received: from LEMAIL01.le.imgtec.org ([fe80::5ae:ee16:f4b9:cda9]) by LEMAIL01.le.imgtec.org ([fe80::5ae:ee16:f4b9:cda9%17]) with mapi id 14.03.0210.002; Sat, 12 Dec 2015 08:53:23 +0000 From: Matthew Fortune To: Steve Ellcey , "gcc-patches@gcc.gnu.org" CC: "clm@codesourcery.com" Subject: RE: [Patch, MIPS] Remove definition of TARGET_PROMOTE_PROTOTYPES Date: Sat, 12 Dec 2015 08:53:00 -0000 Message-ID: <6D39441BF12EF246A7ABCE6654B0235361D03859@LEMAIL01.le.imgtec.org> References: <9003b977-ba2d-4c32-9078-af164c7305c8@BAMAIL02.ba.imgtec.org> <1449875085.4788.106.camel@ubuntu-sellcey> In-Reply-To: <1449875085.4788.106.camel@ubuntu-sellcey> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg01322.txt.bz2 Steve Ellcey writes: > On Tue, 2015-11-10 at 15:57 -0800, Steve Ellcey wrote: > > 2015-11-10 Steve Ellcey > > > > * config/mips/mips.c (mips_promote_function_mode): New function. > > (TARGET_PROMOTE_FUNCTION_MODE): Define as above function. > > (TARGET_PROMOTE_PROTOTYPES): Remove. I'm OK with this change on the basis that MIPS has been providing stronger guarantees than required by the various standards. I.e. after this change MIPS will have undefined behaviour for a mismatch in types between a call to an un-prototyped function and its definition: extern void foo(); void caller(int a) { foo(a); } -- void foo(short a) { // the value of 'a' can be out of range of a short because the caller // did not get the right type for the argument. } Thanks, Matthew