* [patch, MIPS] Update -mvirt option description
@ 2017-03-31 20:25 Matthew Fortune
2017-04-06 15:23 ` Moore, Catherine
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Fortune @ 2017-03-31 20:25 UTC (permalink / raw)
To: Moore, Catherine (Catherine_Moore@mentor.com)
Cc: 'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org),
roland.illig
Hi Catherine,
I'm following up on PR target/80057 to update the description of -mvirt.
I agree with Roland that the description is inconsistent and should not
state 'application specific' as none of the other ASE options include
it. Instead I suggest we put the shortened form of (VZ) in like (XPA)
is shown for -mxpa. The short form of virtualization ASE is usually VZ
not VIRT which has always irritated me about this option name but that
is history.
What do you think?
gcc/
PR target/80057
* config/mips/mips.opt (-mvirt): Update description.
Thanks,
Matthew
diff --git a/gcc/config/mips/mips.opt b/gcc/config/mips/mips.opt
index 7c4b607..ced2432 100644
--- a/gcc/config/mips/mips.opt
+++ b/gcc/config/mips/mips.opt
@@ -406,7 +406,7 @@ Put uninitialized constants in ROM (needs -membedded-data).
mvirt
Target Report Var(TARGET_VIRT)
-Use Virtualization Application Specific instructions.
+Use Virtualization (VZ) instructions.
mxpa
Target Report Var(TARGET_XPA)
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 8d3821e..19a85b6 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -19345,7 +19345,7 @@ Use (do not use) the MIPS Enhanced Virtual Addressing instructions.
@itemx -mno-virt
@opindex mvirt
@opindex mno-virt
-Use (do not use) the MIPS Virtualization Application Specific instructions.
+Use (do not use) the MIPS Virtualization (VZ) instructions.
@item -mxpa
@itemx -mno-xpa
--
2.2.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [patch, MIPS] Update -mvirt option description
2017-03-31 20:25 [patch, MIPS] Update -mvirt option description Matthew Fortune
@ 2017-04-06 15:23 ` Moore, Catherine
0 siblings, 0 replies; 2+ messages in thread
From: Moore, Catherine @ 2017-04-06 15:23 UTC (permalink / raw)
To: Matthew Fortune
Cc: 'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org),
roland.illig
> -----Original Message-----
> From: Matthew Fortune [mailto:Matthew.Fortune@imgtec.com]
> Sent: Friday, March 31, 2017 4:00 PM
> To: Moore, Catherine <Catherine_Moore@mentor.com>
> Cc: 'gcc-patches@gcc.gnu.org' (gcc-patches@gcc.gnu.org) <gcc-
> patches@gcc.gnu.org>; roland.illig@gmx.de
> Subject: [patch, MIPS] Update -mvirt option description
>
> Hi Catherine,
>
> I'm following up on PR target/80057 to update the description of -
> mvirt.
>
> I agree with Roland that the description is inconsistent and should not
> state 'application specific' as none of the other ASE options include
> it. Instead I suggest we put the shortened form of (VZ) in like (XPA)
> is shown for -mxpa. The short form of virtualization ASE is usually VZ
> not VIRT which has always irritated me about this option name but
> that
> is history.
>
> What do you think?
This looks good to me.
>
> gcc/
> PR target/80057
> * config/mips/mips.opt (-mvirt): Update description.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-06 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-31 20:25 [patch, MIPS] Update -mvirt option description Matthew Fortune
2017-04-06 15:23 ` Moore, Catherine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).