From: Richard Biener <richard.guenther@gmail.com>
To: Andrew Pinski <apinski@marvell.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix PR 110085: `make clean` in GCC directory on sh target causes a failure
Date: Mon, 5 Jun 2023 07:23:58 +0200 [thread overview]
Message-ID: <6E446C0B-DD2C-46CD-96E4-538B4339EF45@gmail.com> (raw)
In-Reply-To: <20230605044112.2861212-1-apinski@marvell.com>
> Am 05.06.2023 um 06:42 schrieb Andrew Pinski via Gcc-patches <gcc-patches@gcc.gnu.org>:
>
> On sh target, there is a MULTILIB_DIRNAMES (or is it MULTILIB_OPTIONS) named m2,
> this conflicts with the langauge m2. So when you do a `make clean`, it will remove
> the m2 directory and then a build will fail. Now since r0-78222-gfa9585134f6f58,
> the multilib directories are no longer created in the gcc directory as libgcc
> was moved to the toplevel. So we can remove the part of clean that removes those
> directories.
>
> Tested on x86_64-linux-gnu and a cross to sh-elf that `make clean` followed by
> `make` works again.
>
> OK?
Ok
> gcc/ChangeLog:
>
> PR bootstrap/110085
> * Makefile.in (clean): Remove the removing of
> MULTILIB_DIR/MULTILIB_OPTIONS directories.
> ---
> gcc/Makefile.in | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/gcc/Makefile.in b/gcc/Makefile.in
> index 1d39e6dd3f8..0c02f312985 100644
> --- a/gcc/Makefile.in
> +++ b/gcc/Makefile.in
> @@ -3622,13 +3622,6 @@ clean: mostlyclean lang.clean
> -rm -f doc/*.pdf
> # Delete the include directories.
> -rm -rf include include-fixed
> -# Delete files used by the "multilib" facility (including libgcc subdirs).
> - -rm -f multilib.h tmpmultilib*
> - -if [ "x$(MULTILIB_DIRNAMES)" != x ] ; then \
> - rm -rf $(MULTILIB_DIRNAMES); \
> - else if [ "x$(MULTILIB_OPTIONS)" != x ] ; then \
> - rm -rf `echo $(MULTILIB_OPTIONS) | sed -e 's/\// /g'`; \
> - fi ; fi
>
> # Delete all files that users would normally create
> # while building and installing GCC.
> --
> 2.31.1
>
next prev parent reply other threads:[~2023-06-05 5:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 4:41 Andrew Pinski
2023-06-05 5:23 ` Richard Biener [this message]
2023-06-05 5:43 ` Andrew Pinski
2023-06-05 6:33 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6E446C0B-DD2C-46CD-96E4-538B4339EF45@gmail.com \
--to=richard.guenther@gmail.com \
--cc=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).