From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id D2A7C3858C2C for ; Mon, 5 Jun 2023 05:24:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D2A7C3858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-9741a0fd134so742146566b.0 for ; Sun, 04 Jun 2023 22:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685942651; x=1688534651; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=Cv814wW5z/58gtLh4EzJixfOGlGDbLNlrys5Tb1YRiM=; b=JnWPZjI9kxsrj42uyUI1BQWB4GQ8Lk6ufzcSMWVEpwBeCIsc0o9AE/wxCVeLfbOTiG hfma8O8vkTllT0ViGnLa1wwBgNbzY61QgNPsYkDNn6xVQP77oHOaQ/bUsuUeqt7j2LG2 nlc2rxyHYzWDiOxVaB6PpuIbHm7vf3omJ89Uj7v03TvcQjqKtKWivgEq71OR4lJbT/dR QLO5JnxF3cQuWCnyMxATfdH6+uEboksq1eZVmAPVQgFkLp/bICQbeRhWTqeG+I90fcuC 8ATdOmKimmN04qvtMv/ebXfUD8mLYSfpdAMwYkZUoG2sFj3cLKkJIjxCpWZ73CHtwg+S isdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685942651; x=1688534651; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cv814wW5z/58gtLh4EzJixfOGlGDbLNlrys5Tb1YRiM=; b=R2iUDfJvEkhnivZlNQkrXk+uscpEu492XyZ1kL6ZWe3nzD2RkjtHdCEztyl5R8E5rY 6GGPqZsmQRbEUPBbxC7WbRkH89RGZzl91k9qcsvK1UGyxhhyOZw4Wtw5MRco9jNLp8y8 6ltUhOvTYYPj6CUmo3XXBFie9abeqLndFaIA4skC+ptF7jeo1czA8CGnPRt0Uz1fyp9E AcIZr8kXL08oQH7lYl20mFKav9ezc/d0V6rVtdunnwquhxZm297MUbCs+dB9viaiJlTJ iPGQIr0oxWmUyU61dcEdGg+OMhkukNV1+iHDaH9rwkttCVN7rrFZM4NvOMNFH6T1KwM0 hlmw== X-Gm-Message-State: AC+VfDx+V8hTqEVAS+GzSgYn+t6UHyXMw0fhkHZlYC0NllvrrtvYV9ui bt8NizVdUYC+XJU14LS0XBmzYUMkY+E= X-Google-Smtp-Source: ACHHUZ7R2ivl3JPOr4p6/rfPdGPFB4zrsDE/4IFqVa1N4iwMTlYkL27B+uiQ2VZnKVwUoWljFO/olw== X-Received: by 2002:a17:907:ea7:b0:966:53b1:b32a with SMTP id ho39-20020a1709070ea700b0096653b1b32amr6223541ejc.53.1685942650542; Sun, 04 Jun 2023 22:24:10 -0700 (PDT) Received: from smtpclient.apple (dynamic-095-115-016-225.95.115.pool.telefonica.de. [95.115.16.225]) by smtp.gmail.com with ESMTPSA id w17-20020a1709060a1100b009655eb8be26sm3826245ejf.73.2023.06.04.22.24.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Jun 2023 22:24:09 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Richard Biener Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] Fix PR 110085: `make clean` in GCC directory on sh target causes a failure Date: Mon, 5 Jun 2023 07:23:58 +0200 Message-Id: <6E446C0B-DD2C-46CD-96E4-538B4339EF45@gmail.com> References: <20230605044112.2861212-1-apinski@marvell.com> Cc: gcc-patches@gcc.gnu.org In-Reply-To: <20230605044112.2861212-1-apinski@marvell.com> To: Andrew Pinski X-Mailer: iPhone Mail (20F66) X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Am 05.06.2023 um 06:42 schrieb Andrew Pinski via Gcc-patches : >=20 > =EF=BB=BFOn sh target, there is a MULTILIB_DIRNAMES (or is it MULTILIB_OPT= IONS) named m2, > this conflicts with the langauge m2. So when you do a `make clean`, it wil= l remove > the m2 directory and then a build will fail. Now since r0-78222-gfa9585134= f6f58, > the multilib directories are no longer created in the gcc directory as lib= gcc > was moved to the toplevel. So we can remove the part of clean that removes= those > directories. >=20 > Tested on x86_64-linux-gnu and a cross to sh-elf that `make clean` followe= d by > `make` works again. >=20 > OK? Ok > gcc/ChangeLog: >=20 > PR bootstrap/110085 > * Makefile.in (clean): Remove the removing of > MULTILIB_DIR/MULTILIB_OPTIONS directories. > --- > gcc/Makefile.in | 7 ------- > 1 file changed, 7 deletions(-) >=20 > diff --git a/gcc/Makefile.in b/gcc/Makefile.in > index 1d39e6dd3f8..0c02f312985 100644 > --- a/gcc/Makefile.in > +++ b/gcc/Makefile.in > @@ -3622,13 +3622,6 @@ clean: mostlyclean lang.clean > -rm -f doc/*.pdf > # Delete the include directories. > -rm -rf include include-fixed > -# Delete files used by the "multilib" facility (including libgcc subdirs)= . > - -rm -f multilib.h tmpmultilib* > - -if [ "x$(MULTILIB_DIRNAMES)" !=3D x ] ; then \ > - rm -rf $(MULTILIB_DIRNAMES); \ > - else if [ "x$(MULTILIB_OPTIONS)" !=3D x ] ; then \ > - rm -rf `echo $(MULTILIB_OPTIONS) | sed -e 's/\// /g'`; \ > - fi ; fi >=20 > # Delete all files that users would normally create > # while building and installing GCC. > --=20 > 2.31.1 >=20