From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29498 invoked by alias); 21 Apr 2015 17:05:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 29487 invoked by uid 89); 21 Apr 2015 17:05:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: resqmta-po-01v.sys.comcast.net Received: from resqmta-po-01v.sys.comcast.net (HELO resqmta-po-01v.sys.comcast.net) (96.114.154.160) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 21 Apr 2015 17:05:42 +0000 Received: from resomta-po-08v.sys.comcast.net ([96.114.154.232]) by resqmta-po-01v.sys.comcast.net with comcast id Jh5g1q007516pyw01h5gwW; Tue, 21 Apr 2015 17:05:40 +0000 Received: from [IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d] ([IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d]) by resomta-po-08v.sys.comcast.net with comcast id Jh5e1q0082ztT3H01h5e85; Tue, 21 Apr 2015 17:05:39 +0000 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [RFC stage 1] Proposed new warning: -Wmisleading-indentation From: Mike Stump In-Reply-To: <1429632420.32584.134.camel@surprise> Date: Tue, 21 Apr 2015 17:05:00 -0000 Cc: "gcc-patches@gcc.gnu.org" Content-Transfer-Encoding: quoted-printable Message-Id: <6E724837-CC36-4ABC-A085-CAB44A229F05@comcast.net> References: <1429196485.32584.46.camel@surprise> <6A97A5CB-3000-4030-9E5C-BE55AE79F164@comcast.net> <1429632420.32584.134.camel@surprise> To: David Malcolm X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg01217.txt.bz2 On Apr 21, 2015, at 9:07 AM, David Malcolm wrote: > I think I want to make a distinction between >=20 > (A) classic C "gotchas", like the one in my mail and the: >=20 > if (cond); > stmt; >=20 > one you mentioned above >=20 > vs >=20 > (B) wrong/inconsistent indentation. >=20 > I think (A) is high-value, since it detects subtly wrong code, likely to > have misled the reader, whereas I don't find (B) as interesting. Ok. I don=92t have any problem with that. Going for the high value only m= akes the problem space smaller, more likely to implement and do a good job = and avoids false positives and all sorts of what ifs that the other class w= ould expose you to. I like your work and your plan.