From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-c1p-023832.sys.comcast.net (resqmta-c1p-023832.sys.comcast.net [IPv6:2001:558:fd00:56::9]) by sourceware.org (Postfix) with ESMTPS id D49B93858C20 for ; Sun, 5 Nov 2023 20:25:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D49B93858C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=comcast.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=comcast.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D49B93858C20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:558:fd00:56::9 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699215905; cv=none; b=E1P6uCNC3Hzx9/wj0CAJb4jayxDXfmfOqpEliw7+ox4RoQZM+Js5G2YYLutyIAgCDooEi930yr3bGi6sMOssQzODUfMrRLxLpywsCJPkYhmB9HRdMWOi/tzw5oIIYUwkBdFPdapLTe/wi4t2I4qWxDoTIawnTo/sK/6skRovZ3M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699215905; c=relaxed/simple; bh=FPRpPm+f2V3B1PSqj8SPvb86aU1ZVrgWxM7JetkvjOA=; h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=q/W03Gy5LJkIirI8lMgv5eebdpYl2FMRfc5reDe9KOK/NxbW3dLIk2tUURSKo2gAch/gMb/joTN+Q8FMTlNIXbHI1kZk2SWHlfPsdTxTBwp0mzsyuH/Uo2T/kwkdrPBLHXEphgzc3yn+F1sSSXo/OXkvPHtJsUqCrDfS1LGPFoM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from resomta-c1p-022584.sys.comcast.net ([96.102.18.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 256/256 bits) (Client did not present a certificate) by resqmta-c1p-023832.sys.comcast.net with ESMTP id zjN0ql3d9Wuy0zjg7qw9Xv; Sun, 05 Nov 2023 20:25:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=20190202a; t=1699215903; bh=9Pj+Lmur6qum6hhlAyiwqQGJOck8rqzqaEkx9aBccUE=; h=Received:Received:Content-Type:Mime-Version:Subject:From:Date: Message-Id:To:Xfinity-Spam-Result; b=lzMoEx6KJTYr7fTDjm7bednPL+itfm4vNfe3xYzeQY6UCxOAGg49Jd5AMFgRKoxSR ErcHEleRt8jCbgATsJ/vcYeAtQtrtTBgdW5SrWSckSUazfHJWGR5823aFD3BopemwN ORiRMek3SgIng1HKOw39fygYeJGcsO2PBGt/gX/fKx1ELfUFe89yWTxUUs7EfGpYa/ KmtNXoSqEMA0LBo08Tk6Xc5ps+EQYhDW8iwVIhdT6u5xUfHKL8XMpfMtDp9QH2ZVup EDWkJn25sep8/zgxOg6JlGMhLSnf3+w3T2lfDUBS33E2WU6tr2r44wYZvpBW8Aevkz tXvrRXnSzxhnQ== Received: from smtpclient.apple ([IPv6:2601:644:907f:7c80:dd0f:9e03:4598:be08]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 256/256 bits) (Client did not present a certificate) by resomta-c1p-022584.sys.comcast.net with ESMTPSA id zjg3qg6p4L7Gxzjg4qdgnE; Sun, 05 Nov 2023 20:25:02 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: [PATCH] testsuite: Force use of -c when precompiling headers From: Mike Stump In-Reply-To: <20231027151141.1879699-1-christophe.lyon@linaro.org> Date: Sun, 5 Nov 2023 12:24:59 -0800 Cc: gcc-patches@gcc.gnu.org, "ro@cebitec.uni-bielefeld.de" Content-Transfer-Encoding: quoted-printable Message-Id: <6EAF39D8-2A9A-4CDD-84A7-A69047D80AA3@comcast.net> References: <20231027151141.1879699-1-christophe.lyon@linaro.org> To: Christophe Lyon X-Mailer: Apple Mail (2.3696.120.41.1.4) X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Oct 27, 2023, at 8:11 AM, Christophe Lyon = wrote: >=20 > In some configurations of our validation setup, we always call the > compiler with -Wl,-rpath=3DXXX, which instructs the driver to invoke = the > linker if none of -c, -S or -E is used. >=20 > This happens to be the case in the PCH tests, where dg-flags-pch sets > dg-do-what-default to precompile. >=20 > This works most of the time, in absence of any linker option, the > compiler defaults to generating a precompiled header (otherwise the > linker complains because it cannot find 'main'). >=20 > This small patch forces the use of '-c' when generating the .gch file, > which is sufficient not to invoke the linker. >=20 > Arguably, this could be seen as a dejagnu bug: in gcc-dg-test-1 (in > gcc-dg.exp), we set compile_type to "precompiled_header", which is not > one of the supported values in dejagnu's default_target_compile (in > target.exp). >=20 > 2023-10-27 Christophe Lyon >=20 > gcc/testsuite/ > * lib/dg-pch.exp (dg-flags-pch): Add -c when generating the > precompiled header. Ok.