* [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests
@ 2020-11-03 8:25 Olivier Hainque
2020-11-03 8:30 ` Jakub Jelinek
0 siblings, 1 reply; 5+ messages in thread
From: Olivier Hainque @ 2020-11-03 8:25 UTC (permalink / raw)
To: GCC Patches
[-- Attachment #1: Type: text/plain, Size: 2739 bytes --]
Hello,
This change is a proposal to add
/* { dg-require-effective-target fpic } */
to tests in gcc.target/i386 that do use -fpic or -fPIC
but don't currently query the target support.
This corresponds to what many other fpic tests do
and helps the vxWorks ports at least, as -fpic is
typically not supported in at least one of the two
major modes of such port (kernel vs RTP).
I verified that it doesn't affect testing results
on a native x86_64-linux configuration.
Ok to commit ?
Thanks in advance!
With Best Regards,
Olivier
2020-11-03 Olivier Hainque <hainque@adacore.com>
* gcc.target/i386/indirect-thunk-5.c: Add
dg-require-effective-target fpic.
* gcc.target/i386/indirect-thunk-6.c: Likewise.
* gcc.target/i386/indirect-thunk-extern-5.c: Likewise.
* gcc.target/i386/indirect-thunk-extern-6.c: Likewise.
* gcc.target/i386/indirect-thunk-inline-5.c: Likewise.
* gcc.target/i386/indirect-thunk-inline-6.c: Likewise.
* gcc.target/i386/noplt-gd-1.c: Likewise.
* gcc.target/i386/noplt-gd-2.c: Likewise.
* gcc.target/i386/noplt-gd-3.c: Likewise.
* gcc.target/i386/noplt-ld-1.c: Likewise.
* gcc.target/i386/noplt-ld-2.c: Likewise.
* gcc.target/i386/noplt-ld-3.c: Likewise.
* gcc.target/i386/pr45352-1.c: Likewise.
* gcc.target/i386/pr47602.c: Likewise.
* gcc.target/i386/pr55151.c: Likewise.
* gcc.target/i386/pr55458.c: Likewise.
* gcc.target/i386/pr56348.c: Likewise.
* gcc.target/i386/pr57097.c: Likewise.
* gcc.target/i386/pr65248-1.c: Likewise.
* gcc.target/i386/pr65248-2.c: Likewise.
* gcc.target/i386/pr65248-3.c: Likewise.
* gcc.target/i386/pr65248-4.c: Likewise.
* gcc.target/i386/pr65753.c: Likewise.
* gcc.target/i386/pr65915.c: Likewise.
* gcc.target/i386/pr66232-1.c: Likewise.
* gcc.target/i386/pr66232-10.c: Likewise.
* gcc.target/i386/pr66232-11.c: Likewise.
* gcc.target/i386/pr66232-12.c: Likewise.
* gcc.target/i386/pr66232-13.c: Likewise.
* gcc.target/i386/pr66232-2.c: Likewise.
* gcc.target/i386/pr66232-3.c: Likewise.
* gcc.target/i386/pr66232-4.c: Likewise.
* gcc.target/i386/pr66232-5.c: Likewise.
* gcc.target/i386/pr66334.c: Likewise.
* gcc.target/i386/pr66819-2.c: Likewise.
* gcc.target/i386/pr67215-1.c: Likewise.
* gcc.target/i386/pr67215-2.c: Likewise.
* gcc.target/i386/pr67215-3.c: Likewise.
* gcc.target/i386/pr67265.c: Likewise.
* gcc.target/i386/pr68937-1.c: Likewise.
* gcc.target/i386/pr68937-2.c: Likewise.
* gcc.target/i386/pr68937-3.c: Likewise.
* gcc.target/i386/pr68937-4.c: Likewise.
* gcc.target/i386/pr68937-5.c: Likewise.
* gcc.target/i386/pr68937-6.c: Likewise.
* gcc.target/i386/pr81481.c: Likewise.
* gcc.target/i386/pr82699-3.c: Likewise.
* gcc.target/i386/pr82699-4.c: Likewise.
* gcc.target/i386/pr83994.c: Likewise.
[-- Attachment #2: 0001-Add-dg-require-effective-target-fpic-to-gcc-i386.txt --]
[-- Type: text/plain, Size: 23061 bytes --]
diff --git a/gcc/testsuite/gcc.target/i386/indirect-thunk-5.c b/gcc/testsuite/gcc.target/i386/indirect-thunk-5.c
index fb26c005e80d..58689b70fa21 100644
--- a/gcc/testsuite/gcc.target/i386/indirect-thunk-5.c
+++ b/gcc/testsuite/gcc.target/i386/indirect-thunk-5.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -mno-indirect-branch-register -mfunction-return=keep -fpic -fno-plt -mindirect-branch=thunk" } */
extern void bar (void);
diff --git a/gcc/testsuite/gcc.target/i386/indirect-thunk-6.c b/gcc/testsuite/gcc.target/i386/indirect-thunk-6.c
index 8bc45ff68ce9..f5ee97dc40c6 100644
--- a/gcc/testsuite/gcc.target/i386/indirect-thunk-6.c
+++ b/gcc/testsuite/gcc.target/i386/indirect-thunk-6.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -mno-indirect-branch-register -mfunction-return=keep -fpic -fno-plt -mindirect-branch=thunk" } */
extern void bar (void);
diff --git a/gcc/testsuite/gcc.target/i386/indirect-thunk-extern-5.c b/gcc/testsuite/gcc.target/i386/indirect-thunk-extern-5.c
index 53282390977d..b0696774a3e6 100644
--- a/gcc/testsuite/gcc.target/i386/indirect-thunk-extern-5.c
+++ b/gcc/testsuite/gcc.target/i386/indirect-thunk-extern-5.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -mno-indirect-branch-register -mfunction-return=keep -fpic -fno-plt -mindirect-branch=thunk-extern" } */
extern void bar (void);
diff --git a/gcc/testsuite/gcc.target/i386/indirect-thunk-extern-6.c b/gcc/testsuite/gcc.target/i386/indirect-thunk-extern-6.c
index 8ae43482d0cb..aa5d12deebe5 100644
--- a/gcc/testsuite/gcc.target/i386/indirect-thunk-extern-6.c
+++ b/gcc/testsuite/gcc.target/i386/indirect-thunk-extern-6.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -mno-indirect-branch-register -mfunction-return=keep -fpic -fno-plt -mindirect-branch=thunk-extern" } */
extern void bar (void);
diff --git a/gcc/testsuite/gcc.target/i386/indirect-thunk-inline-5.c b/gcc/testsuite/gcc.target/i386/indirect-thunk-inline-5.c
index 21cbfd39582a..087c914845e1 100644
--- a/gcc/testsuite/gcc.target/i386/indirect-thunk-inline-5.c
+++ b/gcc/testsuite/gcc.target/i386/indirect-thunk-inline-5.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -mno-indirect-branch-register -mfunction-return=keep -fpic -fno-plt -mindirect-branch=thunk-inline" } */
extern void bar (void);
diff --git a/gcc/testsuite/gcc.target/i386/indirect-thunk-inline-6.c b/gcc/testsuite/gcc.target/i386/indirect-thunk-inline-6.c
index d1300f18dc7a..7986aebcea60 100644
--- a/gcc/testsuite/gcc.target/i386/indirect-thunk-inline-6.c
+++ b/gcc/testsuite/gcc.target/i386/indirect-thunk-inline-6.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -mno-indirect-branch-register -mfunction-return=keep -fpic -fno-plt -mindirect-branch=thunk-inline" } */
extern void bar (void);
diff --git a/gcc/testsuite/gcc.target/i386/noplt-gd-1.c b/gcc/testsuite/gcc.target/i386/noplt-gd-1.c
index 5d5b531b744a..0f02826875fe 100644
--- a/gcc/testsuite/gcc.target/i386/noplt-gd-1.c
+++ b/gcc/testsuite/gcc.target/i386/noplt-gd-1.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target { *-*-linux* && tls_get_addr_via_got } } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fpic -fno-plt" } */
extern __thread int gd;
diff --git a/gcc/testsuite/gcc.target/i386/noplt-gd-2.c b/gcc/testsuite/gcc.target/i386/noplt-gd-2.c
index 81c8446a1127..75922e4ad5b9 100644
--- a/gcc/testsuite/gcc.target/i386/noplt-gd-2.c
+++ b/gcc/testsuite/gcc.target/i386/noplt-gd-2.c
@@ -1,4 +1,5 @@
/* { dg-do run { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fno-plt" } */
/* { dg-additional-sources noplt-gd-1.c } */
diff --git a/gcc/testsuite/gcc.target/i386/noplt-gd-3.c b/gcc/testsuite/gcc.target/i386/noplt-gd-3.c
index 6b0e780b7450..56601e8c2c7e 100644
--- a/gcc/testsuite/gcc.target/i386/noplt-gd-3.c
+++ b/gcc/testsuite/gcc.target/i386/noplt-gd-3.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target { *-*-linux* && { ia32 && tls_get_addr_via_got } } } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fpic -fno-plt" } */
extern __thread int gd;
diff --git a/gcc/testsuite/gcc.target/i386/noplt-ld-1.c b/gcc/testsuite/gcc.target/i386/noplt-ld-1.c
index 87698301bff1..57bf528cd129 100644
--- a/gcc/testsuite/gcc.target/i386/noplt-ld-1.c
+++ b/gcc/testsuite/gcc.target/i386/noplt-ld-1.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target { *-*-linux* && tls_get_addr_via_got } } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fpic -fno-plt" } */
static __thread int ld;
diff --git a/gcc/testsuite/gcc.target/i386/noplt-ld-2.c b/gcc/testsuite/gcc.target/i386/noplt-ld-2.c
index 8ae7e2957c97..c49d3fe09c51 100644
--- a/gcc/testsuite/gcc.target/i386/noplt-ld-2.c
+++ b/gcc/testsuite/gcc.target/i386/noplt-ld-2.c
@@ -1,4 +1,5 @@
/* { dg-do run { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fno-plt" } */
/* { dg-additional-sources noplt-ld-1.c } */
diff --git a/gcc/testsuite/gcc.target/i386/noplt-ld-3.c b/gcc/testsuite/gcc.target/i386/noplt-ld-3.c
index b014d53baabe..a2abbd01a4f1 100644
--- a/gcc/testsuite/gcc.target/i386/noplt-ld-3.c
+++ b/gcc/testsuite/gcc.target/i386/noplt-ld-3.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target { *-*-linux* && { ia32 && tls_get_addr_via_got } } } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fpic -fno-plt" } */
static __thread int ld;
diff --git a/gcc/testsuite/gcc.target/i386/pr45352-1.c b/gcc/testsuite/gcc.target/i386/pr45352-1.c
index 5cd1bd842d80..f5e96b270166 100644
--- a/gcc/testsuite/gcc.target/i386/pr45352-1.c
+++ b/gcc/testsuite/gcc.target/i386/pr45352-1.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-mtune=amdfam10 -O3 -fpeel-loops -fselective-scheduling2 -fsel-sched-pipelining -fPIC" } */
static int FIR_Tab_16[16][16];
diff --git a/gcc/testsuite/gcc.target/i386/pr47602.c b/gcc/testsuite/gcc.target/i386/pr47602.c
index fa5f5bd7d351..5ed1e1fd490c 100644
--- a/gcc/testsuite/gcc.target/i386/pr47602.c
+++ b/gcc/testsuite/gcc.target/i386/pr47602.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-require-effective-target ia32 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fPIC" } */
/* Test verifies that %ebx is no longer fixed when generating PIC code on i686. */
diff --git a/gcc/testsuite/gcc.target/i386/pr55151.c b/gcc/testsuite/gcc.target/i386/pr55151.c
index 62da8cb7781e..d6255a83dee7 100644
--- a/gcc/testsuite/gcc.target/i386/pr55151.c
+++ b/gcc/testsuite/gcc.target/i386/pr55151.c
@@ -1,5 +1,6 @@
/* PR rtl-optimization/55151 */
/* { dg-do compile { target { ! ia32 } } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fPIC" } */
int a, b, c, d, e, f, g, h, i, j, k, l;
diff --git a/gcc/testsuite/gcc.target/i386/pr55458.c b/gcc/testsuite/gcc.target/i386/pr55458.c
index 7164ca905db2..1dea55c50c9e 100644
--- a/gcc/testsuite/gcc.target/i386/pr55458.c
+++ b/gcc/testsuite/gcc.target/i386/pr55458.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-require-effective-target ia32 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fPIC" } */
/* Test verifies that %ebx is no longer fixed when generating PIC code on i686. */
diff --git a/gcc/testsuite/gcc.target/i386/pr56348.c b/gcc/testsuite/gcc.target/i386/pr56348.c
index c31814f60f47..93423d9190d9 100644
--- a/gcc/testsuite/gcc.target/i386/pr56348.c
+++ b/gcc/testsuite/gcc.target/i386/pr56348.c
@@ -1,5 +1,6 @@
/* PR target/56348 */
/* { dg-do compile { target ia32 } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fPIC -mfpmath=sse -msse2" } */
typedef unsigned int size_t;
diff --git a/gcc/testsuite/gcc.target/i386/pr57097.c b/gcc/testsuite/gcc.target/i386/pr57097.c
index 2f0093840df5..debacbfc048b 100644
--- a/gcc/testsuite/gcc.target/i386/pr57097.c
+++ b/gcc/testsuite/gcc.target/i386/pr57097.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fPIC" } */
extern double ad[], bd[], cd[], dd[];
extern long long all[], bll[], cll[], dll[];
diff --git a/gcc/testsuite/gcc.target/i386/pr65248-1.c b/gcc/testsuite/gcc.target/i386/pr65248-1.c
index 735adde93377..1f1e50c6235d 100644
--- a/gcc/testsuite/gcc.target/i386/pr65248-1.c
+++ b/gcc/testsuite/gcc.target/i386/pr65248-1.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic" } */
/* Common symbol with -fpic. */
diff --git a/gcc/testsuite/gcc.target/i386/pr65248-2.c b/gcc/testsuite/gcc.target/i386/pr65248-2.c
index af264f36a14e..89d1763d88bf 100644
--- a/gcc/testsuite/gcc.target/i386/pr65248-2.c
+++ b/gcc/testsuite/gcc.target/i386/pr65248-2.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic" } */
/* Weak common symbol with -fpic. */
diff --git a/gcc/testsuite/gcc.target/i386/pr65248-3.c b/gcc/testsuite/gcc.target/i386/pr65248-3.c
index e7a05eac6e6e..a3315188d9da 100644
--- a/gcc/testsuite/gcc.target/i386/pr65248-3.c
+++ b/gcc/testsuite/gcc.target/i386/pr65248-3.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic" } */
/* Initialized symbol with -fpic. */
diff --git a/gcc/testsuite/gcc.target/i386/pr65248-4.c b/gcc/testsuite/gcc.target/i386/pr65248-4.c
index db818fc1f780..e5e1915d4c50 100644
--- a/gcc/testsuite/gcc.target/i386/pr65248-4.c
+++ b/gcc/testsuite/gcc.target/i386/pr65248-4.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic" } */
/* Weak initialized symbol with -fpic. */
diff --git a/gcc/testsuite/gcc.target/i386/pr65753.c b/gcc/testsuite/gcc.target/i386/pr65753.c
index 562f54bff6bd..117d6ed0cf17 100644
--- a/gcc/testsuite/gcc.target/i386/pr65753.c
+++ b/gcc/testsuite/gcc.target/i386/pr65753.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fPIC -O2" } */
/* { dg-final { scan-assembler-not "call" } } */
diff --git a/gcc/testsuite/gcc.target/i386/pr65915.c b/gcc/testsuite/gcc.target/i386/pr65915.c
index 990c5aaa2e4d..6588de47c4a2 100644
--- a/gcc/testsuite/gcc.target/i386/pr65915.c
+++ b/gcc/testsuite/gcc.target/i386/pr65915.c
@@ -1,4 +1,5 @@
/* { dg-do run } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -mavx512f -fpic -mcmodel=medium" } */
/* { dg-require-effective-target avx512f } */
/* { dg-require-effective-target lp64 } */
diff --git a/gcc/testsuite/gcc.target/i386/pr66232-1.c b/gcc/testsuite/gcc.target/i386/pr66232-1.c
index 5ea03de09bdc..3095212ad51b 100644
--- a/gcc/testsuite/gcc.target/i386/pr66232-1.c
+++ b/gcc/testsuite/gcc.target/i386/pr66232-1.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fno-plt" } */
extern void bar (void);
diff --git a/gcc/testsuite/gcc.target/i386/pr66232-10.c b/gcc/testsuite/gcc.target/i386/pr66232-10.c
index d5e3d5fd163a..c14d11e529af 100644
--- a/gcc/testsuite/gcc.target/i386/pr66232-10.c
+++ b/gcc/testsuite/gcc.target/i386/pr66232-10.c
@@ -1,5 +1,6 @@
/* { dg-do compile { target { *-*-linux* && { ! ia32 } } } } */
/* { dg-require-effective-target maybe_x32 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -mx32 -fpic -fno-plt -maddress-mode=long" } */
extern void bar (void);
diff --git a/gcc/testsuite/gcc.target/i386/pr66232-11.c b/gcc/testsuite/gcc.target/i386/pr66232-11.c
index 57446ac7b6ad..f32d17aff560 100644
--- a/gcc/testsuite/gcc.target/i386/pr66232-11.c
+++ b/gcc/testsuite/gcc.target/i386/pr66232-11.c
@@ -1,5 +1,6 @@
/* { dg-do compile { target { *-*-linux* && { ! ia32 } } } } */
/* { dg-require-effective-target maybe_x32 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -mx32 -fpic -fno-plt -maddress-mode=long" } */
extern void bar (void);
diff --git a/gcc/testsuite/gcc.target/i386/pr66232-12.c b/gcc/testsuite/gcc.target/i386/pr66232-12.c
index 69af4e866197..7e9aa8740d79 100644
--- a/gcc/testsuite/gcc.target/i386/pr66232-12.c
+++ b/gcc/testsuite/gcc.target/i386/pr66232-12.c
@@ -1,5 +1,6 @@
/* { dg-do compile { target { *-*-linux* && { ! ia32 } } } } */
/* { dg-require-effective-target maybe_x32 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -mx32 -fpic -fno-plt -maddress-mode=long" } */
extern int bar (void);
diff --git a/gcc/testsuite/gcc.target/i386/pr66232-13.c b/gcc/testsuite/gcc.target/i386/pr66232-13.c
index 6aa29356ec80..3dc6ef9c377d 100644
--- a/gcc/testsuite/gcc.target/i386/pr66232-13.c
+++ b/gcc/testsuite/gcc.target/i386/pr66232-13.c
@@ -1,5 +1,6 @@
/* { dg-do compile { target { *-*-linux* && { ! ia32 } } } } */
/* { dg-require-effective-target maybe_x32 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -mx32 -fpic -fno-plt -maddress-mode=long" } */
extern int bar (void);
diff --git a/gcc/testsuite/gcc.target/i386/pr66232-2.c b/gcc/testsuite/gcc.target/i386/pr66232-2.c
index f05d7c557a50..363c32371e29 100644
--- a/gcc/testsuite/gcc.target/i386/pr66232-2.c
+++ b/gcc/testsuite/gcc.target/i386/pr66232-2.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fno-plt" } */
extern void bar (void);
diff --git a/gcc/testsuite/gcc.target/i386/pr66232-3.c b/gcc/testsuite/gcc.target/i386/pr66232-3.c
index e6ba60f34aaf..b060c6b2cb6a 100644
--- a/gcc/testsuite/gcc.target/i386/pr66232-3.c
+++ b/gcc/testsuite/gcc.target/i386/pr66232-3.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fno-plt" } */
extern int bar (void);
diff --git a/gcc/testsuite/gcc.target/i386/pr66232-4.c b/gcc/testsuite/gcc.target/i386/pr66232-4.c
index 5fa0dedf67e6..e0090fe09d05 100644
--- a/gcc/testsuite/gcc.target/i386/pr66232-4.c
+++ b/gcc/testsuite/gcc.target/i386/pr66232-4.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fno-plt" } */
extern int bar (void);
diff --git a/gcc/testsuite/gcc.target/i386/pr66232-5.c b/gcc/testsuite/gcc.target/i386/pr66232-5.c
index 87f93802694f..76705a529848 100644
--- a/gcc/testsuite/gcc.target/i386/pr66232-5.c
+++ b/gcc/testsuite/gcc.target/i386/pr66232-5.c
@@ -1,5 +1,6 @@
/* { dg-do compile { target { ! ia32 } } } */
/* { dg-require-effective-target maybe_x32 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -mx32" } */
extern void (*bar) (void);
diff --git a/gcc/testsuite/gcc.target/i386/pr66334.c b/gcc/testsuite/gcc.target/i386/pr66334.c
index 97dfecc8725c..19c2396073cd 100644
--- a/gcc/testsuite/gcc.target/i386/pr66334.c
+++ b/gcc/testsuite/gcc.target/i386/pr66334.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-require-effective-target ia32 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fexceptions -fasynchronous-unwind-tables" } */
/* { dg-final { scan-assembler "movl\[ \\t\].+, %ebx" } } */
extern int foo (int);
diff --git a/gcc/testsuite/gcc.target/i386/pr66819-2.c b/gcc/testsuite/gcc.target/i386/pr66819-2.c
index 9de4f97a9063..ad2a33e7fd24 100644
--- a/gcc/testsuite/gcc.target/i386/pr66819-2.c
+++ b/gcc/testsuite/gcc.target/i386/pr66819-2.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target ia32 } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fPIC -O2 -mregparm=3" } */
/* { dg-final { scan-assembler-not "call" } } */
diff --git a/gcc/testsuite/gcc.target/i386/pr67215-1.c b/gcc/testsuite/gcc.target/i386/pr67215-1.c
index fd37f8e63db9..3400acd1dc31 100644
--- a/gcc/testsuite/gcc.target/i386/pr67215-1.c
+++ b/gcc/testsuite/gcc.target/i386/pr67215-1.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fno-plt" } */
extern char* bar (int);
diff --git a/gcc/testsuite/gcc.target/i386/pr67215-2.c b/gcc/testsuite/gcc.target/i386/pr67215-2.c
index ebf2919078c4..11f7e5ebdd11 100644
--- a/gcc/testsuite/gcc.target/i386/pr67215-2.c
+++ b/gcc/testsuite/gcc.target/i386/pr67215-2.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic" } */
extern char* bar (int) __attribute__ ((noplt));
diff --git a/gcc/testsuite/gcc.target/i386/pr67215-3.c b/gcc/testsuite/gcc.target/i386/pr67215-3.c
index eb6bb395f10a..f6c5fade5b17 100644
--- a/gcc/testsuite/gcc.target/i386/pr67215-3.c
+++ b/gcc/testsuite/gcc.target/i386/pr67215-3.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fno-plt -fdump-rtl-expand" } */
extern int bar (void);
diff --git a/gcc/testsuite/gcc.target/i386/pr67265.c b/gcc/testsuite/gcc.target/i386/pr67265.c
index 2671acc043ad..1708d537b98a 100644
--- a/gcc/testsuite/gcc.target/i386/pr67265.c
+++ b/gcc/testsuite/gcc.target/i386/pr67265.c
@@ -3,6 +3,7 @@
/* { dg-do compile } */
/* { dg-require-stack-check "" } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O -fstack-check -fPIC" } */
int a, b, c, d, e;
diff --git a/gcc/testsuite/gcc.target/i386/pr68937-1.c b/gcc/testsuite/gcc.target/i386/pr68937-1.c
index 897856bc5903..ae35f0a43c5d 100644
--- a/gcc/testsuite/gcc.target/i386/pr68937-1.c
+++ b/gcc/testsuite/gcc.target/i386/pr68937-1.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target { *-*-linux* && ia32 } } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fno-plt -mregparm=3" } */
extern void bar (int);
diff --git a/gcc/testsuite/gcc.target/i386/pr68937-2.c b/gcc/testsuite/gcc.target/i386/pr68937-2.c
index 257f4e267f46..313575dac7c3 100644
--- a/gcc/testsuite/gcc.target/i386/pr68937-2.c
+++ b/gcc/testsuite/gcc.target/i386/pr68937-2.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target { *-*-linux* && ia32 } } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fno-plt -mregparm=3" } */
extern void bar (int, int);
diff --git a/gcc/testsuite/gcc.target/i386/pr68937-3.c b/gcc/testsuite/gcc.target/i386/pr68937-3.c
index 6d8e40ff769d..06fca090fc8d 100644
--- a/gcc/testsuite/gcc.target/i386/pr68937-3.c
+++ b/gcc/testsuite/gcc.target/i386/pr68937-3.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target { *-*-linux* && ia32 } } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fno-plt -mregparm=3" } */
extern void bar (int, int, int);
diff --git a/gcc/testsuite/gcc.target/i386/pr68937-4.c b/gcc/testsuite/gcc.target/i386/pr68937-4.c
index 9c199568d661..cdad6d20f57d 100644
--- a/gcc/testsuite/gcc.target/i386/pr68937-4.c
+++ b/gcc/testsuite/gcc.target/i386/pr68937-4.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target { *-*-linux* && ia32 } } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fno-plt -mregparm=3" } */
extern int bar (int, int);
diff --git a/gcc/testsuite/gcc.target/i386/pr68937-5.c b/gcc/testsuite/gcc.target/i386/pr68937-5.c
index fc907f8c30a2..539c16110d6e 100644
--- a/gcc/testsuite/gcc.target/i386/pr68937-5.c
+++ b/gcc/testsuite/gcc.target/i386/pr68937-5.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fno-plt -funroll-loops" } */
extern void *f();
diff --git a/gcc/testsuite/gcc.target/i386/pr68937-6.c b/gcc/testsuite/gcc.target/i386/pr68937-6.c
index 406ce282d945..9f47fdf31722 100644
--- a/gcc/testsuite/gcc.target/i386/pr68937-6.c
+++ b/gcc/testsuite/gcc.target/i386/pr68937-6.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target { *-*-linux* && ia32 } } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fno-plt -mregparm=3" } */
extern void foo (int, int, int);
diff --git a/gcc/testsuite/gcc.target/i386/pr81481.c b/gcc/testsuite/gcc.target/i386/pr81481.c
index a5b936fdacc1..49f7821ea5be 100644
--- a/gcc/testsuite/gcc.target/i386/pr81481.c
+++ b/gcc/testsuite/gcc.target/i386/pr81481.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-require-effective-target ssse3 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -mssse3" } */
/* { dg-final { scan-assembler-not "pshufb\[ \t\]\\(%esp\\)" } } */
#include <immintrin.h>
diff --git a/gcc/testsuite/gcc.target/i386/pr82699-3.c b/gcc/testsuite/gcc.target/i386/pr82699-3.c
index 08fa0e7fa5ce..39670e20bdd9 100644
--- a/gcc/testsuite/gcc.target/i386/pr82699-3.c
+++ b/gcc/testsuite/gcc.target/i386/pr82699-3.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target *-*-linux* } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fcf-protection -pg -fasynchronous-unwind-tables" } */
/* { dg-final { scan-assembler-times {\t\.cfi_startproc\n\tendbr} 1 } } */
diff --git a/gcc/testsuite/gcc.target/i386/pr82699-4.c b/gcc/testsuite/gcc.target/i386/pr82699-4.c
index 719566b358b4..129e2f578ac1 100644
--- a/gcc/testsuite/gcc.target/i386/pr82699-4.c
+++ b/gcc/testsuite/gcc.target/i386/pr82699-4.c
@@ -1,5 +1,6 @@
/* { dg-do compile { target { *-*-linux* && { ! ia32 } } } } */
/* { dg-require-effective-target mfentry } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fcf-protection -pg -mfentry -fasynchronous-unwind-tables" } */
/* { dg-final { scan-assembler-times {\t\.cfi_startproc\n\tendbr} 1 } } */
diff --git a/gcc/testsuite/gcc.target/i386/pr83994.c b/gcc/testsuite/gcc.target/i386/pr83994.c
index dc0b7cb44c44..1eb47e3cf0a2 100644
--- a/gcc/testsuite/gcc.target/i386/pr83994.c
+++ b/gcc/testsuite/gcc.target/i386/pr83994.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -march=i686 -fpic -fstack-clash-protection" } */
/* { dg-require-effective-target ia32 } */
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests
2020-11-03 8:25 [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests Olivier Hainque
@ 2020-11-03 8:30 ` Jakub Jelinek
2020-11-03 10:24 ` Olivier Hainque
0 siblings, 1 reply; 5+ messages in thread
From: Jakub Jelinek @ 2020-11-03 8:30 UTC (permalink / raw)
To: Olivier Hainque; +Cc: GCC Patches
On Tue, Nov 03, 2020 at 09:25:03AM +0100, Olivier Hainque wrote:
> Hello,
>
> This change is a proposal to add
>
> /* { dg-require-effective-target fpic } */
>
> to tests in gcc.target/i386 that do use -fpic or -fPIC
> but don't currently query the target support.
>
> This corresponds to what many other fpic tests do
> and helps the vxWorks ports at least, as -fpic is
> typically not supported in at least one of the two
> major modes of such port (kernel vs RTP).
70% of the tests you've changed have a target *-linux* or similar
right above that line, what is the point of adding the fpic
effective targets to those? Those surely aren't run on vxWorks
and on x86 Linux fpic is always supported.
No objection to adding it to the rest.
Jakub
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests
2020-11-03 8:30 ` Jakub Jelinek
@ 2020-11-03 10:24 ` Olivier Hainque
2020-11-03 10:25 ` Jakub Jelinek
0 siblings, 1 reply; 5+ messages in thread
From: Olivier Hainque @ 2020-11-03 10:24 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Olivier Hainque, GCC Patches
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
> On 3 Nov 2020, at 09:30, Jakub Jelinek <jakub@redhat.com> wrote:
> 70% of the tests you've changed have a target *-linux* or similar
> right above that line, what is the point of adding the fpic
> effective targets to those? Those surely aren't run on vxWorks
> and on x86 Linux fpic is always supported.
Good point. We had quite a few actual failures
and I did a pretty systematic search, missing the
linux implication.
> No objection to adding it to the rest.
Ok, amended change below.
Thanks for your prompt feedback on this Jakub!
Best Regards,
Olivier
2020-11-03 Olivier Hainque <hainque@adacore.com>
gcc/testsuite/
* gcc.target/i386/pr45352-1.c: Add dg-require-effective-target fpic.
* gcc.target/i386/pr47602.c: Likewise.
* gcc.target/i386/pr55151.c: Likewise.
* gcc.target/i386/pr55458.c: Likewise.
* gcc.target/i386/pr56348.c: Likewise.
* gcc.target/i386/pr57097.c: Likewise.
* gcc.target/i386/pr65753.c: Likewise.
* gcc.target/i386/pr65915.c: Likewise.
* gcc.target/i386/pr66232-5.c: Likewise.
* gcc.target/i386/pr66334.c: Likewise.
* gcc.target/i386/pr66819-2.c: Likewise.
* gcc.target/i386/pr67265.c: Likewise.
* gcc.target/i386/pr81481.c: Likewise.
* gcc.target/i386/pr83994.c: Likewise.
[-- Attachment #2: dg-require-fpic-i386-not-linux.txt --]
[-- Type: text/plain, Size: 7237 bytes --]
---
gcc/testsuite/gcc.target/i386/pr45352-1.c | 1 +
gcc/testsuite/gcc.target/i386/pr47602.c | 1 +
gcc/testsuite/gcc.target/i386/pr55151.c | 1 +
gcc/testsuite/gcc.target/i386/pr55458.c | 1 +
gcc/testsuite/gcc.target/i386/pr56348.c | 1 +
gcc/testsuite/gcc.target/i386/pr57097.c | 1 +
gcc/testsuite/gcc.target/i386/pr65753.c | 1 +
gcc/testsuite/gcc.target/i386/pr65915.c | 1 +
gcc/testsuite/gcc.target/i386/pr66232-5.c | 1 +
gcc/testsuite/gcc.target/i386/pr66334.c | 1 +
gcc/testsuite/gcc.target/i386/pr66819-2.c | 1 +
gcc/testsuite/gcc.target/i386/pr67265.c | 1 +
gcc/testsuite/gcc.target/i386/pr81481.c | 1 +
gcc/testsuite/gcc.target/i386/pr83994.c | 1 +
14 files changed, 14 insertions(+)
diff --git a/gcc/testsuite/gcc.target/i386/pr45352-1.c b/gcc/testsuite/gcc.target/i386/pr45352-1.c
index 5cd1bd842d80..f5e96b270166 100644
--- a/gcc/testsuite/gcc.target/i386/pr45352-1.c
+++ b/gcc/testsuite/gcc.target/i386/pr45352-1.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-mtune=amdfam10 -O3 -fpeel-loops -fselective-scheduling2 -fsel-sched-pipelining -fPIC" } */
static int FIR_Tab_16[16][16];
diff --git a/gcc/testsuite/gcc.target/i386/pr47602.c b/gcc/testsuite/gcc.target/i386/pr47602.c
index fa5f5bd7d351..5ed1e1fd490c 100644
--- a/gcc/testsuite/gcc.target/i386/pr47602.c
+++ b/gcc/testsuite/gcc.target/i386/pr47602.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-require-effective-target ia32 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fPIC" } */
/* Test verifies that %ebx is no longer fixed when generating PIC code on i686. */
diff --git a/gcc/testsuite/gcc.target/i386/pr55151.c b/gcc/testsuite/gcc.target/i386/pr55151.c
index 62da8cb7781e..d6255a83dee7 100644
--- a/gcc/testsuite/gcc.target/i386/pr55151.c
+++ b/gcc/testsuite/gcc.target/i386/pr55151.c
@@ -1,5 +1,6 @@
/* PR rtl-optimization/55151 */
/* { dg-do compile { target { ! ia32 } } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fPIC" } */
int a, b, c, d, e, f, g, h, i, j, k, l;
diff --git a/gcc/testsuite/gcc.target/i386/pr55458.c b/gcc/testsuite/gcc.target/i386/pr55458.c
index 7164ca905db2..1dea55c50c9e 100644
--- a/gcc/testsuite/gcc.target/i386/pr55458.c
+++ b/gcc/testsuite/gcc.target/i386/pr55458.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-require-effective-target ia32 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fPIC" } */
/* Test verifies that %ebx is no longer fixed when generating PIC code on i686. */
diff --git a/gcc/testsuite/gcc.target/i386/pr56348.c b/gcc/testsuite/gcc.target/i386/pr56348.c
index c31814f60f47..93423d9190d9 100644
--- a/gcc/testsuite/gcc.target/i386/pr56348.c
+++ b/gcc/testsuite/gcc.target/i386/pr56348.c
@@ -1,5 +1,6 @@
/* PR target/56348 */
/* { dg-do compile { target ia32 } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fPIC -mfpmath=sse -msse2" } */
typedef unsigned int size_t;
diff --git a/gcc/testsuite/gcc.target/i386/pr57097.c b/gcc/testsuite/gcc.target/i386/pr57097.c
index 2f0093840df5..debacbfc048b 100644
--- a/gcc/testsuite/gcc.target/i386/pr57097.c
+++ b/gcc/testsuite/gcc.target/i386/pr57097.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fPIC" } */
extern double ad[], bd[], cd[], dd[];
extern long long all[], bll[], cll[], dll[];
diff --git a/gcc/testsuite/gcc.target/i386/pr65753.c b/gcc/testsuite/gcc.target/i386/pr65753.c
index 562f54bff6bd..117d6ed0cf17 100644
--- a/gcc/testsuite/gcc.target/i386/pr65753.c
+++ b/gcc/testsuite/gcc.target/i386/pr65753.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fPIC -O2" } */
/* { dg-final { scan-assembler-not "call" } } */
diff --git a/gcc/testsuite/gcc.target/i386/pr65915.c b/gcc/testsuite/gcc.target/i386/pr65915.c
index 990c5aaa2e4d..6588de47c4a2 100644
--- a/gcc/testsuite/gcc.target/i386/pr65915.c
+++ b/gcc/testsuite/gcc.target/i386/pr65915.c
@@ -1,4 +1,5 @@
/* { dg-do run } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -mavx512f -fpic -mcmodel=medium" } */
/* { dg-require-effective-target avx512f } */
/* { dg-require-effective-target lp64 } */
diff --git a/gcc/testsuite/gcc.target/i386/pr66232-5.c b/gcc/testsuite/gcc.target/i386/pr66232-5.c
index 87f93802694f..76705a529848 100644
--- a/gcc/testsuite/gcc.target/i386/pr66232-5.c
+++ b/gcc/testsuite/gcc.target/i386/pr66232-5.c
@@ -1,5 +1,6 @@
/* { dg-do compile { target { ! ia32 } } } */
/* { dg-require-effective-target maybe_x32 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -mx32" } */
extern void (*bar) (void);
diff --git a/gcc/testsuite/gcc.target/i386/pr66334.c b/gcc/testsuite/gcc.target/i386/pr66334.c
index 97dfecc8725c..19c2396073cd 100644
--- a/gcc/testsuite/gcc.target/i386/pr66334.c
+++ b/gcc/testsuite/gcc.target/i386/pr66334.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-require-effective-target ia32 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -fexceptions -fasynchronous-unwind-tables" } */
/* { dg-final { scan-assembler "movl\[ \\t\].+, %ebx" } } */
extern int foo (int);
diff --git a/gcc/testsuite/gcc.target/i386/pr66819-2.c b/gcc/testsuite/gcc.target/i386/pr66819-2.c
index 9de4f97a9063..ad2a33e7fd24 100644
--- a/gcc/testsuite/gcc.target/i386/pr66819-2.c
+++ b/gcc/testsuite/gcc.target/i386/pr66819-2.c
@@ -1,4 +1,5 @@
/* { dg-do compile { target ia32 } } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-fPIC -O2 -mregparm=3" } */
/* { dg-final { scan-assembler-not "call" } } */
diff --git a/gcc/testsuite/gcc.target/i386/pr67265.c b/gcc/testsuite/gcc.target/i386/pr67265.c
index 2671acc043ad..1708d537b98a 100644
--- a/gcc/testsuite/gcc.target/i386/pr67265.c
+++ b/gcc/testsuite/gcc.target/i386/pr67265.c
@@ -3,6 +3,7 @@
/* { dg-do compile } */
/* { dg-require-stack-check "" } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O -fstack-check -fPIC" } */
int a, b, c, d, e;
diff --git a/gcc/testsuite/gcc.target/i386/pr81481.c b/gcc/testsuite/gcc.target/i386/pr81481.c
index a5b936fdacc1..49f7821ea5be 100644
--- a/gcc/testsuite/gcc.target/i386/pr81481.c
+++ b/gcc/testsuite/gcc.target/i386/pr81481.c
@@ -1,5 +1,6 @@
/* { dg-do compile } */
/* { dg-require-effective-target ssse3 } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -fpic -mssse3" } */
/* { dg-final { scan-assembler-not "pshufb\[ \t\]\\(%esp\\)" } } */
#include <immintrin.h>
diff --git a/gcc/testsuite/gcc.target/i386/pr83994.c b/gcc/testsuite/gcc.target/i386/pr83994.c
index dc0b7cb44c44..1eb47e3cf0a2 100644
--- a/gcc/testsuite/gcc.target/i386/pr83994.c
+++ b/gcc/testsuite/gcc.target/i386/pr83994.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target fpic } */
/* { dg-options "-O2 -march=i686 -fpic -fstack-clash-protection" } */
/* { dg-require-effective-target ia32 } */
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests
2020-11-03 10:24 ` Olivier Hainque
@ 2020-11-03 10:25 ` Jakub Jelinek
2020-11-03 11:56 ` Olivier Hainque
0 siblings, 1 reply; 5+ messages in thread
From: Jakub Jelinek @ 2020-11-03 10:25 UTC (permalink / raw)
To: Olivier Hainque; +Cc: GCC Patches
On Tue, Nov 03, 2020 at 11:24:24AM +0100, Olivier Hainque wrote:
>
>
> > On 3 Nov 2020, at 09:30, Jakub Jelinek <jakub@redhat.com> wrote:
>
> > 70% of the tests you've changed have a target *-linux* or similar
> > right above that line, what is the point of adding the fpic
> > effective targets to those? Those surely aren't run on vxWorks
> > and on x86 Linux fpic is always supported.
>
> Good point. We had quite a few actual failures
> and I did a pretty systematic search, missing the
> linux implication.
>
> > No objection to adding it to the rest.
>
> Ok, amended change below.
>
> Thanks for your prompt feedback on this Jakub!
Ok, thanks.
> 2020-11-03 Olivier Hainque <hainque@adacore.com>
>
> gcc/testsuite/
>
> * gcc.target/i386/pr45352-1.c: Add dg-require-effective-target fpic.
> * gcc.target/i386/pr47602.c: Likewise.
> * gcc.target/i386/pr55151.c: Likewise.
> * gcc.target/i386/pr55458.c: Likewise.
> * gcc.target/i386/pr56348.c: Likewise.
> * gcc.target/i386/pr57097.c: Likewise.
> * gcc.target/i386/pr65753.c: Likewise.
> * gcc.target/i386/pr65915.c: Likewise.
> * gcc.target/i386/pr66232-5.c: Likewise.
> * gcc.target/i386/pr66334.c: Likewise.
> * gcc.target/i386/pr66819-2.c: Likewise.
> * gcc.target/i386/pr67265.c: Likewise.
> * gcc.target/i386/pr81481.c: Likewise.
> * gcc.target/i386/pr83994.c: Likewise.
Jakub
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests
2020-11-03 10:25 ` Jakub Jelinek
@ 2020-11-03 11:56 ` Olivier Hainque
0 siblings, 0 replies; 5+ messages in thread
From: Olivier Hainque @ 2020-11-03 11:56 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Olivier Hainque, GCC Patches
> On 3 Nov 2020, at 11:25, Jakub Jelinek <jakub@redhat.com> wrote:
>
> Ok, thanks.
Thanks Jakub!
I have a couple of similar ones (for fpic) for non-target-specific
tests in preparation.
Then JIC, two smaller ones in the same spirit already sent:
https://gcc.gnu.org/pipermail/gcc-patches/2020-October/557477.html
(dg-require-profiling on i386 tests using -pg)
and
https://gcc.gnu.org/pipermail/gcc-patches/2020-November/557738.html
(dg-require-effective-target fopenmp on g++ test)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-03 11:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-03 8:25 [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests Olivier Hainque
2020-11-03 8:30 ` Jakub Jelinek
2020-11-03 10:24 ` Olivier Hainque
2020-11-03 10:25 ` Jakub Jelinek
2020-11-03 11:56 ` Olivier Hainque
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).