From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4FCC03857C4A for ; Thu, 2 Dec 2021 17:44:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4FCC03857C4A Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-347-0Cv21vfFP_GvS1y7Jh-Guw-1; Thu, 02 Dec 2021 12:44:37 -0500 X-MC-Unique: 0Cv21vfFP_GvS1y7Jh-Guw-1 Received: by mail-qt1-f198.google.com with SMTP id i5-20020ac85c05000000b002ae12b76e64so527177qti.6 for ; Thu, 02 Dec 2021 09:44:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to; bh=Pn6ZTxG+1xFx41kPNSvbF1+vDPsZotWDphUD/Fp1MnI=; b=N9cnuP8+9BF7Y5NydFEBwO9NU80Oy1tSsHWiAxzvsoT9PZU+wlqtKQnvqyJ6AjZ2pI o0z0IgHd8RqwXEB0f77BIxFLkHWh8j67NM+g+EPlqovqWmrgSkPK7Z9Lj14qumoce26n Ohmu0FMBaZevfnwdLHwc5HjQ4eQKXYDVIivEFAQxWhaidR1MNkqVUXBLBBVVKY9R8Idb THkIFgbjLjSN/aJp2NhFRKuOjkkFTZ1y9LaDaW01t+AeP7yhNgIKHRZdFg2PqgecLTG5 BM/pF6QQvMexcv4Im4163TUp36UhU4RAM/iQXjokNiXaBWcT5Aw/gya8dToSdoPDLxmN WkkA== X-Gm-Message-State: AOAM530vmPd+ILbxsd0eu+4pg49boHOxylBB80s844759u66EV4M602H 9yul02UaIX/gMdDI11lIskFYsKJs1uuOvlWljKwSWxLjam/b16DaEPP7kRjGrFjb0rAme7CpJjI ZbfCImalUTxyp403SuWHjWGgCWRw4zUJZlBNIQo4F1yWVa4CPAKarUfoZuQzcLVoPrrEH3Q== X-Received: by 2002:a05:620a:25c7:: with SMTP id y7mr13577351qko.129.1638467076675; Thu, 02 Dec 2021 09:44:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJw8987g0GAdhD/uAQ5uGWC9JsiJTdCoqWdVcU2phvEhu6Nf+UHzWylG32EeAG3rmqhBwA/s0Q== X-Received: by 2002:a05:620a:25c7:: with SMTP id y7mr13577319qko.129.1638467076385; Thu, 02 Dec 2021 09:44:36 -0800 (PST) Received: from [192.168.1.113] ([69.165.238.126]) by smtp.gmail.com with ESMTPSA id c22sm237685qtd.76.2021.12.02.09.44.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Dec 2021 09:44:35 -0800 (PST) Message-ID: <6a0f3aa3-5f55-be6a-aae3-0cb1b4e418c2@redhat.com> Date: Thu, 2 Dec 2021 12:44:34 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PR103437] [committed] IRA: Process multiplication overflow in priority calculation for allocno assignments To: gcc-patches@gcc.gnu.org References: <116e765c-ea89-47f4-600f-af115dd561c3@redhat.com> <20211202140021.GH2646553@tucnak> <3bb6317f-b049-13f1-1bac-6ffd753e9685@redhat.com> <20211202142937.GI2646553@tucnak> <68638247-ddb8-b165-d24a-89a0f8155e63@redhat.com> <20211202161348.GJ2646553@tucnak> <6995f136-f658-2f81-47e7-c869cd1b554b@redhat.com> From: Vladimir Makarov In-Reply-To: <6995f136-f658-2f81-47e7-c869cd1b554b@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------dQYUZ7VxaqZAfisraQjxgaU9" Content-Language: en-US X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2021 17:44:40 -0000 This is a multi-part message in MIME format. --------------dQYUZ7VxaqZAfisraQjxgaU9 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2021-12-02 12:21, Vladimir Makarov via Gcc-patches wrote: > > On 2021-12-02 12:06, Vladimir Makarov wrote: >> >> >> So simple problem and so many details :) >>> This will require that long long is at least twice as large as int >>> everywhere, I thought you wanted to do that only when >>> __builtin_smul_overflow isn't available. >> >> That is not critical as GCC and probably all others C++ compiler >> support only targets with this assertion.  I guess it is better to >> find this problem earlier on targets (if any) where it is not true >> *independently* on used compiler. >> >> So it is difficult for me to know what is better.  Probably for >> GCC/Clang oriented world, your variant is better as it permits to >> compile the code by GCC even on targets where the assertion is false. >> >> > After some more considerations, I think you are right and the backup > code should be conditional.  Because otherwise, there is no sense to > use code with __builtin_smul_overflow.  I'll do the changes. > > Here is one more patch I've committed.  Jakub, thank your for the discussion and your patience. --------------dQYUZ7VxaqZAfisraQjxgaU9 Content-Type: text/x-patch; charset=UTF-8; name="pr103437-3.patch" Content-Disposition: attachment; filename="pr103437-3.patch" Content-Transfer-Encoding: base64 Y29tbWl0IGE3MmI4ZjM3NmExNzZjNjIwZjFjMWM2ODRmMmVlZTIwMTZlNmI0YzMKQXV0aG9yOiBW bGFkaW1pciBOLiBNYWthcm92IDx2bWFrYXJvdkByZWRoYXQuY29tPgpEYXRlOiAgIFRodSBEZWMg MiAxMjozMToyOCAyMDIxIC0wNTAwCgogICAgW1BSMTAzNDM3XSBNYWtlIGJhY2t1cCBjb2RlIGZv ciBvdmVyZmxvdyBjb25kaXRpb25hbAogICAgCiAgICBTd2l0Y2ggb2ZmIGxvbmcgbG9uZyB2YXJp YW50IG92ZXJmbG93IGNvZGUgYnkgcHJlcHJvY2Vzc29yIGlmIHRoZQogICAgYnVpbGQgY29tcGls ZXIgaGFzIF9fYnVpbHRpbl9zbXVsX292ZXJmbG93LgogICAgCiAgICBnY2MvQ2hhbmdlTG9nOgog ICAgICAgICAgICBQUiBydGwtb3B0aW1pemF0aW9uLzEwMzQzNwogICAgICAgICAgICAqIGlyYS1j b2xvci5jIChzZXR1cF9hbGxvY25vX3ByaW9yaXRpZXMpOiBTd2l0Y2ggb2ZmIGJhY2t1cCBjb2Rl CiAgICAgICAgICAgIGZvciBvdmVyZmxvdyBpZiBjb21waWxlciBoYXMgX19idWlsdGluX3NtdWxf b3ZlcmZsb3cuICBVc2UgPAogICAgICAgICAgICBmb3IgY29tcGFyaXNvbiB3aXRoIC1JTlRfTUFY LgoKZGlmZiAtLWdpdCBhL2djYy9pcmEtY29sb3IuYyBiL2djYy9pcmEtY29sb3IuYwppbmRleCAz YjE5YTU4ZTFmMC4uYTFiMDI3NzZlNzcgMTAwNjQ0Ci0tLSBhL2djYy9pcmEtY29sb3IuYworKysg Yi9nY2MvaXJhLWNvbG9yLmMKQEAgLTI3OTcsNyArMjc5Nyw2IEBAIHN0YXRpYyB2b2lkCiBzZXR1 cF9hbGxvY25vX3ByaW9yaXRpZXMgKGlyYV9hbGxvY25vX3QgKmNvbnNpZGVyYXRpb25fYWxsb2Nu b3MsIGludCBuKQogewogICBpbnQgaSwgbGVuZ3RoLCBucmVmcywgcHJpb3JpdHksIG1heF9wcmlv cml0eSwgbXVsdCwgZGlmZjsKLSAgYm9vbCBvdmVyZmxvd19iYWNrdXBfcCA9IHRydWU7CiAgIGly YV9hbGxvY25vX3QgYTsKIAogICBtYXhfcHJpb3JpdHkgPSAwOwpAQCAtMjgxMCwyNyArMjgwOSwy NyBAQCBzZXR1cF9hbGxvY25vX3ByaW9yaXRpZXMgKGlyYV9hbGxvY25vX3QgKmNvbnNpZGVyYXRp b25fYWxsb2Nub3MsIGludCBuKQogICAgICAgaXJhX2Fzc2VydCAobXVsdCA+PSAwKTsKICAgICAg IG11bHQgKj0gaXJhX3JlZ19jbGFzc19tYXhfbnJlZ3NbQUxMT0NOT19DTEFTUyAoYSldW0FMTE9D Tk9fTU9ERSAoYSldOwogICAgICAgZGlmZiA9IEFMTE9DTk9fTUVNT1JZX0NPU1QgKGEpIC0gQUxM T0NOT19DTEFTU19DT1NUIChhKTsKLSAgICAgIC8qIE11bHRpcGxpY2F0aW9uIGNhbiBvdmVyZmxv dyBmb3IgdmVyeSBsYXJnZSBmdW5jdGlvbnMuCi0JIENoZWNrIHRoZSBvdmVyZmxvdyBhbmQgY29u c3RyYWluIHRoZSByZXN1bHQgaWYgbmVjZXNzYXJ5OiAqLwogI2lmZGVmIF9faGFzX2J1aWx0aW4K ICNpZiBfX2hhc19idWlsdGluKF9fYnVpbHRpbl9zbXVsX292ZXJmbG93KQotICAgICAgb3ZlcmZs b3dfYmFja3VwX3AgPSBmYWxzZTsKKyNkZWZpbmUgSEFTX1NNVUxfT1ZFUkZMT1cKKyNlbmRpZgor I2VuZGlmCisgICAgICAvKiBNdWx0aXBsaWNhdGlvbiBjYW4gb3ZlcmZsb3cgZm9yIHZlcnkgbGFy Z2UgZnVuY3Rpb25zLgorCSBDaGVjayB0aGUgb3ZlcmZsb3cgYW5kIGNvbnN0cmFpbiB0aGUgcmVz dWx0IGlmIG5lY2Vzc2FyeTogKi8KKyNpZmRlZiBIQVNfU01VTF9PVkVSRkxPVwogICAgICAgaWYg KF9fYnVpbHRpbl9zbXVsX292ZXJmbG93IChtdWx0LCBkaWZmLCAmcHJpb3JpdHkpCi0JICB8fCBw cmlvcml0eSA8PSAtSU5UX01BWCkKKwkgIHx8IHByaW9yaXR5IDwgLUlOVF9NQVgpCiAJcHJpb3Jp dHkgPSBkaWZmID49IDAgPyBJTlRfTUFYIDogLUlOVF9NQVg7CisjZWxzZQorICAgICAgc3RhdGlj X2Fzc2VydAorCShzaXplb2YgKGxvbmcgbG9uZykgPj0gMiAqIHNpemVvZiAoaW50KSwKKwkgIm92 ZXJmbG93IGNvZGUgZG9lcyBub3Qgd29yayBmb3Igc3VjaCBpbnQgYW5kIGxvbmcgbG9uZyBzaXpl cyIpOworICAgICAgbG9uZyBsb25nIHByaW9yaXR5bGwgPSAobG9uZyBsb25nKSBtdWx0ICogZGlm ZjsKKyAgICAgIGlmIChwcmlvcml0eWxsIDwgLUlOVF9NQVggfHwgcHJpb3JpdHlsbCA+IElOVF9N QVgpCisJcHJpb3JpdHkgPSBkaWZmID49IDAgPyBJTlRfTUFYIDogLUlOVF9NQVg7CisgICAgICBl bHNlCisJcHJpb3JpdHkgPSBwcmlvcml0eWxsOwogI2VuZGlmCi0jZW5kaWYKLSAgICAgIGlmIChv dmVyZmxvd19iYWNrdXBfcCkKLQl7Ci0JICBzdGF0aWNfYXNzZXJ0Ci0JICAgIChzaXplb2YgKGxv bmcgbG9uZykgPj0gMiAqIHNpemVvZiAoaW50KSwKLQkgICAgICJvdmVyZmxvdyBjb2RlIGRvZXMg bm90IHdvcmsgZm9yIHN1Y2ggaW50IGFuZCBsb25nIGxvbmcgc2l6ZXMiKTsKLQkgIGxvbmcgbG9u ZyBwcmlvcml0eWxsID0gKGxvbmcgbG9uZykgbXVsdCAqIGRpZmY7Ci0JICBpZiAocHJpb3JpdHls bCA8IC1JTlRfTUFYIHx8IHByaW9yaXR5bGwgPiBJTlRfTUFYKQotCSAgICBwcmlvcml0eSA9IGRp ZmYgPj0gMCA/IElOVF9NQVggOiAtSU5UX01BWDsKLQkgIGVsc2UKLQkgICAgcHJpb3JpdHkgPSBw cmlvcml0eWxsOwotCX0KICAgICAgIGFsbG9jbm9fcHJpb3JpdGllc1tBTExPQ05PX05VTSAoYSld ID0gcHJpb3JpdHk7CiAgICAgICBpZiAocHJpb3JpdHkgPCAwKQogCXByaW9yaXR5ID0gLXByaW9y aXR5Owo= --------------dQYUZ7VxaqZAfisraQjxgaU9--