From: "Martin Liška" <mliska@suse.cz>
To: Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 2/N] Do not hide asm_out_file in ASM_OUTPUT_ASCII.
Date: Thu, 30 Sep 2021 13:46:56 +0200 [thread overview]
Message-ID: <6a5a5bf2-f548-2e7f-0f79-0810ee26ecab@suse.cz> (raw)
In-Reply-To: <CAFiYyc1BfBOcbuEKCEYUJdPSosjmq1Yxy2tPA=aJ25FF5LgN6Q@mail.gmail.com>
On 9/22/21 11:44, Richard Biener wrote:
> On Thu, Sep 16, 2021 at 12:01 PM Martin Liška <mliska@suse.cz> wrote:
>>
>> Again a preparation patch that was tested on all cross compilers.
>>
>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>>
>> Ready to be installed?
>
> I think you want to retain
>
> - FILE *_hide_asm_out_file = (MYFILE);
Oh, oh!
>
> and use _hide_asm_out_file to preserve MYFILE execution counts in case
> it contains side-effects.
I do always forget about the fact that macros can have side-effects.
Thanks for review,
Martin
>
> OK with that change.
>
> Richard.
>
>> Thanks,
>> Martin
next prev parent reply other threads:[~2021-09-30 11:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 9:31 [PATCH][RFC] Come up with casm state Martin Liška
2021-09-16 10:00 ` [PATCH 1/N] Rename asm_out_file function arguments Martin Liška
2021-09-16 13:52 ` Iain Sandoe
2021-09-17 8:23 ` Richard Biener
2021-09-17 9:42 ` Iain Sandoe
2021-09-17 9:57 ` Richard Biener
2021-10-20 11:57 ` Martin Liška
2021-10-20 12:11 ` Richard Biener
2021-09-16 10:00 ` [PATCH 2/N] Do not hide asm_out_file in ASM_OUTPUT_ASCII Martin Liška
2021-09-22 9:44 ` Richard Biener
2021-09-30 11:46 ` Martin Liška [this message]
2021-09-16 13:12 ` [PATCH 3/N] Come up with casm global state Martin Liška
2021-09-22 9:59 ` Richard Biener
2021-10-04 11:13 ` Martin Liška
2021-10-05 11:54 ` Richard Biener
2021-10-21 9:47 ` Martin Liška
2021-10-21 12:42 ` Richard Biener
2021-10-21 13:43 ` Martin Liška
2021-10-21 13:57 ` Richard Biener
2021-10-21 15:40 ` Segher Boessenkool
2021-10-25 10:46 ` Richard Biener
2021-10-25 13:36 ` Martin Liška
2021-10-25 16:30 ` Segher Boessenkool
2021-10-26 7:45 ` Richard Biener
2021-11-05 14:27 ` Martin Liška
2021-11-09 12:49 ` Richard Biener
2021-10-25 16:06 ` Segher Boessenkool
2021-10-04 11:16 ` Martin Liška
2021-10-21 12:47 ` David Malcolm
2021-10-21 13:08 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a5a5bf2-f548-2e7f-0f79-0810ee26ecab@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).