From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 7431A385841A for ; Wed, 7 Sep 2022 11:46:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7431A385841A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 158DA1FDB8; Wed, 7 Sep 2022 11:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1662551218; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rkHWx8PY8ryWZkqYoqZ+jF4qlznN3PbrNABuwpFkbME=; b=PcwuDGVDMWc3/+hUG+okJW+2IEg1B/eiba2gtWiP4WtlpqfssV3KCtz0mSvsWuS43RPFQk CB659zYz1EocweOfy8RLJiRm22tvZlVKz/btUTwHPXVGHtkc9VcP3UShzCks0jDQd/HRCB p0+PT9dHocmRjedKqJ1LO7vYSuKERH0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1662551218; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rkHWx8PY8ryWZkqYoqZ+jF4qlznN3PbrNABuwpFkbME=; b=WIQhiB4wV+thWHfaO6ijNMok9y1rqDk34jHwzOx3/Z9zsQxNgxO3NGOj5LHKDS0SSWt9iB 7qQdSseJszCYbhCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DA9A313486; Wed, 7 Sep 2022 11:46:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WVLxM7GEGGOTbAAAMHmgww (envelope-from ); Wed, 07 Sep 2022 11:46:57 +0000 Message-ID: <6aa8bbe6-6c63-ea82-85b0-fde91d459022@suse.cz> Date: Wed, 7 Sep 2022 13:46:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality Content-Language: en-US To: David Edelsohn , Richard Biener , Jeff Law Cc: GCC Patches References: From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/6/22 19:00, David Edelsohn wrote: > * dwarf2out.cc (XCOFF_DEBUGGING_INFO): Likewise. > (HAVE_XCOFF_DWARF_EXTRAS): Likewise. > (output_fde): Likewise. > (output_call_frame_info): Likewise. > (have_macinfo): Likewise. > (add_AT_loc_list): Likewise. > (add_AT_view_list): Likewise. > (output_compilation_unit_header): Likewise. > (output_pubnames): Likewise. > (output_aranges): Likewise. > (output_line_info): Likewise. > (output_macinfo): Likewise. > (dwarf2out_finish): Likewise. > (dwarf2out_early_finish): Likewise. > > These changes are not correct and break AIX bootstrap. > > Those changes are not related to stabs support. We agreed to remove stabs and > > XCOFF stabs support, not GCC DWARF debugging support for AIX. Sorry for the breakage, I've just sent a patch that restores that. Cheers, Martin > > Also > > * configure: Regenerate. Likewise. > * configure.ac : Likewise. > > does not list that tests for HAVE_XCOFF_DWARF_EXTRAS was removed, so the ChangeLog was not accurate. > > Again, that test is required for AIX is not part of stabs support. > > > Please revert this change so that AIX can continue to be bootstrapped and tested, and we can work together to test a corrected patch. > > Thanks, David > > > On Tue, Sep 6, 2022 at 12:31 PM David Edelsohn > wrote: > > I fully support the plan to remove stabs support, but this patch broke bootstrap on AIX.  It seems rather bad policy to remove support for a feature without ensuring that the removal does not negatively impact the targets touched by the patch.  I should have been explicitly copied on these patches and I should have been asked to test the patches before they were installed, if for no other reason than politeness and consideration. > > Thanks, David > >