From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 505CB3951C7A; Thu, 1 Jul 2021 07:27:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 505CB3951C7A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: 7yi0DwfiN+7ITM1zXuAdeiMv168UO043ZLH5KxRhwDTicLSXAE3T9KcQ2WDI+a1DfimKF9lhtG o5KQ5mDMch/jhOnlezBavyP4ZNFElTv6JdzDhPjIeA/5RpHOdYVA1kvdoJxZud9/l7M7V5feso Uegz1mioGthwMFVJ7c8AtH4gxwxZuM7sEEVLbcWKyaYnFxoSpTo13XProGZ61m2ul3mLI55e60 nPikjD1ZoceC5vKlyWU4U/W5upg19FfdlhBAv2P05efCRKI4bMM1Sn7w4FGeu/eGk2CQuz99kj LnU= X-IronPort-AV: E=Sophos;i="5.83,313,1616486400"; d="scan'208";a="63206559" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 30 Jun 2021 23:26:59 -0800 IronPort-SDR: EzHnu7QL+zsGm4g4SrutGkuWWw1MOuaXy4VGJEk2+wkpuI7TLcTVJ+wiAomUaAfYuJqZnQgjUI GCbEh1g4ormiBmzyfGt9j2BikurbIdsYY6HOL2JR0SU7dMmAVZgGxWSM8n/RHWbCy4BXBhf5rs C2Jw0FVJdzNxnnHzOQscC7AdwGB5K/S1er/OOYqq27EN/TPykmJVAVbjc66yvOzDTaq+Cl34ON +FfeAjU2WbwX2X41Gy5R9laKeXAOGyKPRYkqlLwC/xVhEaoAVVCiED/qx4PHyYnozQSSrXoTKd PDg= Subject: Re: [PATCH, Fortran] set version field in CFI_cdesc_t to CFI_VERSION To: Sandra Loosemore , "gcc-patches@gcc.gnu.org" , "fortran@gcc.gnu.org" References: From: Tobias Burnus Message-ID: <6aac8442-ea02-c440-bac7-0ccfdeae3bcc@codesourcery.com> Date: Thu, 1 Jul 2021 09:26:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jul 2021 07:27:01 -0000 On 01.07.21 08:00, Sandra Loosemore wrote: > This patch fixes the failures in interoperability/fc-descriptor-8.f90 > in my just-posted TS 29113 testsuite: > https://gcc.gnu.org/pipermail/gcc-patches/2021-July/574115.html > > The problem here is that the routines that copy between GFC and CFI > descriptors think they both use the same version number conventions, > but the GFC descriptors' version is zero-initialized elsewhere and > CFI_VERSION is defined to be 1. It seems incorrect to expect the > internal and external descriptor ABIs to be in lock step together anyway. > > OK to check in? OK =E2=80=93 and thanks for the patch! I note that the FE does not explicitly set the version but it inits the descriptor such that it happens that value the version field is '\0'-fied; additionally, neither libgfortran nor the FE ever access the version field. Tobias ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 M=C3=BCnchen R= egistergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas H= eurung, Frank Th=C3=BCrauf