public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tom de Vries <Tom_deVries@mentor.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: [nvptx, PR 81662, committed] Error out on nvptx for fpatchable-function-entry
Date: Thu, 03 Aug 2017 11:23:00 -0000	[thread overview]
Message-ID: <6ad5514b-cb0c-98f0-50ed-bacfa19a39a3@mentor.com> (raw)
In-Reply-To: <9b7cba92-382d-4255-9983-2868726ad4f5@mentor.com>

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

[ was: Re: [testsuite, PR81662, committed] Skip 
fpatchable-function-entry tests for nvptx ]

On 08/03/2017 09:17 AM, Tom de Vries wrote:
> Hi,
> 
> fpatchable-function-entry requires nop, which nvptx does not have.
> 
> I've disabled the corresponding test for nvptx.

This patch errors out on nvptx for fpatchable-function-entry.

Committed.

Thanks,
- Tom

[-- Attachment #2: 0001-Error-out-on-nvptx-for-fpatchable-function-entry.patch --]
[-- Type: text/x-patch, Size: 1584 bytes --]

Error out on nvptx for fpatchable-function-entry

2017-08-03  Tom de Vries  <tom@codesourcery.com>

	PR target/81662
	* config/nvptx/nvptx.c (nvptx_option_override): Emit sorry if
	function_entry_patch_area_size > 0.

	* gcc.target/nvptx/patchable_function_entry-default.c: New test.

---
 gcc/config/nvptx/nvptx.c                                  |  4 ++++
 .../gcc.target/nvptx/patchable_function_entry-default.c   | 15 +++++++++++++++
 2 files changed, 19 insertions(+)

diff --git a/gcc/config/nvptx/nvptx.c b/gcc/config/nvptx/nvptx.c
index 208b115..9211d1a 100644
--- a/gcc/config/nvptx/nvptx.c
+++ b/gcc/config/nvptx/nvptx.c
@@ -180,6 +180,10 @@ nvptx_option_override (void)
   if (!global_options_set.x_flag_no_common)
     flag_no_common = 1;
 
+  /* The patch area requires nops, which we don't have.  */
+  if (function_entry_patch_area_size > 0)
+    sorry ("not generating patch area, nops not supported");
+
   /* Assumes that it will see only hard registers.  */
   flag_var_tracking = 0;
 
diff --git a/gcc/testsuite/gcc.target/nvptx/patchable_function_entry-default.c b/gcc/testsuite/gcc.target/nvptx/patchable_function_entry-default.c
new file mode 100644
index 0000000..4254456
--- /dev/null
+++ b/gcc/testsuite/gcc.target/nvptx/patchable_function_entry-default.c
@@ -0,0 +1,15 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fpatchable-function-entry=3,1" } */
+
+extern int a;
+
+int f3 (void);
+
+int
+__attribute__((noinline))
+f3 (void)
+{
+  return 5*a;
+}
+
+/* { dg-excess-errors "sorry, unimplemented: not generating patch area, nops not supported" } */

  reply	other threads:[~2017-08-03 11:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03  7:17 [testsuite, PR81662, committed] Skip fpatchable-function-entry tests for nvptx Tom de Vries
2017-08-03 11:23 ` Tom de Vries [this message]
2017-08-10 13:13   ` [nvptx, PR 81662, committed] Error out on nvptx for fpatchable-function-entry Thomas Schwinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ad5514b-cb0c-98f0-50ed-bacfa19a39a3@mentor.com \
    --to=tom_devries@mentor.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).