From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id AF9B8385840C for ; Thu, 14 Jul 2022 04:29:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AF9B8385840C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pj1-x102f.google.com with SMTP id o15so1419636pjh.1 for ; Wed, 13 Jul 2022 21:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=N8OkkJnRKsKo/8GW1Ft8Ai49YxrszH+jO1c4AMQ9B3g=; b=QWQZZnXLVg/z69hEDtShNFrBLTNjgJ/XnOjttYOzWFUf1dUoVxIesoPa1nBPsHatzt M4ihXaiXUxPMEScgeeHLU0uGIzwGqzHeTTA9QZTz9RnuQhqEDKby23LwwR1zP6HXJkQj Y1oBqdH2m9r3E/lNzX8ArjhajQ7lGUV2d38PlFr1gU1kx/4yprltCO49jEwI+h4e8TFA IKmy5CzUwO2N4v4nZ4Uk2fvOxlf1/ZopYW/z/Xdxba2Zk1Sc1MBQnhQw8R8mlk6gH8aj oAf1HDphz2SoJwrlU6FiKvqRIoEms/VWcPoHxp4ApSKVYUg6MPs11NIjYtzARLUjgQN+ ohIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=N8OkkJnRKsKo/8GW1Ft8Ai49YxrszH+jO1c4AMQ9B3g=; b=sW/IMuEiXQJ0ZUNKTSVER9VtAYkCmmUZqjEbbpbiPpUHTpHH3+o3kO07fgDjeKQajE unZz1FDZCQ/Pf/A764CmHCP0RbQkAMlcuee5hvFiIpINGSxiJd950ndPVAtoAzBkgdwZ KiaYxM75TJr0GYZOQ40b6a4RH3B6emaR463SYVUOadlO8lPj7fy3LfpA5Ogaj2YcM9VH fA6TTOJ+TLAtKFOy4HJJbfkI8i8S8qUOjf8RRtS8FZv5EHlCY/AZHR/KXZzTJD+43dOa 2+SAGclLXUC6jPeAv5ilpJD05Z/M7SEYlAfqWvkE7Jzqy4RggIYqhuxYdEFKZMM30kM3 ShYw== X-Gm-Message-State: AJIora8jOo+FvP2xqrnSJRnm4qv9kmnZVTnTc5B2aqrLzd0T/kMT9+uC EzwqbDeazICdCdkyx+zQ3JFrvJE2gwEnPg== X-Google-Smtp-Source: AGRyM1spzxDQtOYHQlHvHz+YCUSLthMWaRu4Bn6T4jFVsRY3UOTN0vlY+J7ks2DhE4p1sv7OeVT9vg== X-Received: by 2002:a17:90b:4a41:b0:1f0:6928:2363 with SMTP id lb1-20020a17090b4a4100b001f069282363mr12493997pjb.161.1657772983717; Wed, 13 Jul 2022 21:29:43 -0700 (PDT) Received: from [192.168.50.116] (c-24-4-73-83.hsd1.ca.comcast.net. [24.4.73.83]) by smtp.gmail.com with ESMTPSA id p35-20020a634f63000000b003fd4831e6fesm215237pgl.70.2022.07.13.21.29.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 21:29:42 -0700 (PDT) Message-ID: <6adf2fe2-fe88-3564-48ee-440f0a15cfd3@rivosinc.com> Date: Wed, 13 Jul 2022 21:29:40 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3] RISC-V/testsuite: constraint some of tests to hard_float Content-Language: en-US To: Kito Cheng , Vineet Gupta Cc: "Maciej W . Rozycki" , gnu-toolchain@rivosinc.com, GCC Patches , Andrew Waterman , Philipp Tomsich References: <20220527015646.2220532-1-vineetg@rivosinc.com> <20220527023636.2224696-1-vineetg@rivosinc.com> From: Vineet Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2022 04:29:46 -0000 On 5/29/22 20:50, Kito Cheng via Gcc-patches wrote: > Committed, thanks! Can this be backported to gcc-12 please. Thx, -Vineet > On Fri, May 27, 2022 at 10:37 AM Vineet Gupta wrote: >> >> Commit 9ddd44b58649d1d ("RISC-V: Provide `fmin'/`fmax' RTL pattern") added >> tests which check for hard float instructions which obviously fails on >> soft-float ABI builds. >> >> And my recent commit b646d7d279ae ("RISC-V: Inhibit FP <--> int register >> moves via tune param") is guilty of same crime. >> >> So constraint with "dg-require-effective-target hard_float" >> >> This reduces bunch of new RV failures. >> >> | ========= Summary of gcc testsuite ========= >> | | # of unexpected case / # of unique unexpected case >> | | gcc | g++ | gfortran | >> | rv64imac/ lp64/ medlow | 134 / 22 | 0 / 0 | - | BEFORE >> | rv64imac/ lp64/ medlow | 22 / 9 | 0 / 0 | - | AFTER >> | >> >> gcc/testsuite/Changelog: >> * gcc.target/riscv/fmax.c: Add dg-require-effective-target hard_float. >> * gcc.target/riscv/fmaxf.c: Ditto. >> * gcc.target/riscv/fmin.c: Ditto. >> * gcc.target/riscv/fminf.c: Ditto. >> * gcc.target/riscv/smax-ieee.c: Ditto. >> * gcc.target/riscv/smax.c: Ditto. >> * gcc.target/riscv/smaxf-ieee.c: Ditto. >> * gcc.target/riscv/smaxf.c: Ditto. >> * gcc.target/riscv/smin-ieee.c: Ditto. >> * gcc.target/riscv/smin.c: Ditto. >> * gcc.target/riscv/sminf-ieee.c: Ditto. >> * gcc.target/riscv/sminf.c: Ditto. >> * gcc.target/riscv/pr105666.c: Ditto. >> >> Signed-off-by: Vineet Gupta >> --- >> v3: >> Added fix to pr105666.c as well. >> v2: >> Fixed the SoB snafu in v1 >> --- >> gcc/testsuite/gcc.target/riscv/fmax.c | 1 + >> gcc/testsuite/gcc.target/riscv/fmaxf.c | 1 + >> gcc/testsuite/gcc.target/riscv/fmin.c | 1 + >> gcc/testsuite/gcc.target/riscv/fminf.c | 1 + >> gcc/testsuite/gcc.target/riscv/pr105666.c | 1 + >> gcc/testsuite/gcc.target/riscv/smax-ieee.c | 1 + >> gcc/testsuite/gcc.target/riscv/smax.c | 1 + >> gcc/testsuite/gcc.target/riscv/smaxf-ieee.c | 1 + >> gcc/testsuite/gcc.target/riscv/smaxf.c | 1 + >> gcc/testsuite/gcc.target/riscv/smin-ieee.c | 1 + >> gcc/testsuite/gcc.target/riscv/smin.c | 1 + >> gcc/testsuite/gcc.target/riscv/sminf-ieee.c | 1 + >> gcc/testsuite/gcc.target/riscv/sminf.c | 1 + >> 13 files changed, 13 insertions(+) >> >> diff --git a/gcc/testsuite/gcc.target/riscv/fmax.c b/gcc/testsuite/gcc.target/riscv/fmax.c >> index c71d35c9f9dc..e1b7fa8f918c 100644 >> --- a/gcc/testsuite/gcc.target/riscv/fmax.c >> +++ b/gcc/testsuite/gcc.target/riscv/fmax.c >> @@ -1,4 +1,5 @@ >> /* { dg-do compile } */ >> +/* { dg-require-effective-target hard_float } */ >> /* { dg-options "-fno-finite-math-only -fsigned-zeros -fno-signaling-nans -dp" } */ >> >> double >> diff --git a/gcc/testsuite/gcc.target/riscv/fmaxf.c b/gcc/testsuite/gcc.target/riscv/fmaxf.c >> index f9980166887a..8da0513dc8f6 100644 >> --- a/gcc/testsuite/gcc.target/riscv/fmaxf.c >> +++ b/gcc/testsuite/gcc.target/riscv/fmaxf.c >> @@ -1,4 +1,5 @@ >> /* { dg-do compile } */ >> +/* { dg-require-effective-target hard_float } */ >> /* { dg-options "-fno-finite-math-only -fsigned-zeros -fno-signaling-nans -dp" } */ >> >> float >> diff --git a/gcc/testsuite/gcc.target/riscv/fmin.c b/gcc/testsuite/gcc.target/riscv/fmin.c >> index 9634abd19af8..01993d49bc21 100644 >> --- a/gcc/testsuite/gcc.target/riscv/fmin.c >> +++ b/gcc/testsuite/gcc.target/riscv/fmin.c >> @@ -1,4 +1,5 @@ >> /* { dg-do compile } */ >> +/* { dg-require-effective-target hard_float } */ >> /* { dg-options "-fno-finite-math-only -fsigned-zeros -fno-signaling-nans -dp" } */ >> >> double >> diff --git a/gcc/testsuite/gcc.target/riscv/fminf.c b/gcc/testsuite/gcc.target/riscv/fminf.c >> index 9a3687be3092..32ce363e10d8 100644 >> --- a/gcc/testsuite/gcc.target/riscv/fminf.c >> +++ b/gcc/testsuite/gcc.target/riscv/fminf.c >> @@ -1,4 +1,5 @@ >> /* { dg-do compile } */ >> +/* { dg-require-effective-target hard_float } */ >> /* { dg-options "-fno-finite-math-only -fsigned-zeros -fno-signaling-nans -dp" } */ >> >> float >> diff --git a/gcc/testsuite/gcc.target/riscv/pr105666.c b/gcc/testsuite/gcc.target/riscv/pr105666.c >> index 904f3bc0763f..dd996eec8efc 100644 >> --- a/gcc/testsuite/gcc.target/riscv/pr105666.c >> +++ b/gcc/testsuite/gcc.target/riscv/pr105666.c >> @@ -6,6 +6,7 @@ >> spilling to stack. */ >> >> /* { dg-do compile } */ >> +/* { dg-require-effective-target hard_float } */ >> /* { dg-options "-march=rv64g -ffast-math" } */ >> >> #define NITER 4 >> diff --git a/gcc/testsuite/gcc.target/riscv/smax-ieee.c b/gcc/testsuite/gcc.target/riscv/smax-ieee.c >> index 3a98aeb45add..2dbccefe2f4d 100644 >> --- a/gcc/testsuite/gcc.target/riscv/smax-ieee.c >> +++ b/gcc/testsuite/gcc.target/riscv/smax-ieee.c >> @@ -1,4 +1,5 @@ >> /* { dg-do compile } */ >> +/* { dg-require-effective-target hard_float } */ >> /* { dg-options "-ffinite-math-only -fsigned-zeros -dp" } */ >> >> double >> diff --git a/gcc/testsuite/gcc.target/riscv/smax.c b/gcc/testsuite/gcc.target/riscv/smax.c >> index d806c632faed..1092cc49f25e 100644 >> --- a/gcc/testsuite/gcc.target/riscv/smax.c >> +++ b/gcc/testsuite/gcc.target/riscv/smax.c >> @@ -1,4 +1,5 @@ >> /* { dg-do compile } */ >> +/* { dg-require-effective-target hard_float } */ >> /* { dg-options "-ffinite-math-only -fno-signed-zeros -dp" } */ >> >> double >> diff --git a/gcc/testsuite/gcc.target/riscv/smaxf-ieee.c b/gcc/testsuite/gcc.target/riscv/smaxf-ieee.c >> index 6cf23d789b6e..31b9bfa4d91e 100644 >> --- a/gcc/testsuite/gcc.target/riscv/smaxf-ieee.c >> +++ b/gcc/testsuite/gcc.target/riscv/smaxf-ieee.c >> @@ -1,4 +1,5 @@ >> /* { dg-do compile } */ >> +/* { dg-require-effective-target hard_float } */ >> /* { dg-options "-ffinite-math-only -fsigned-zeros -dp" } */ >> >> float >> diff --git a/gcc/testsuite/gcc.target/riscv/smaxf.c b/gcc/testsuite/gcc.target/riscv/smaxf.c >> index d6a7a7f84cf7..aa1f22b45a17 100644 >> --- a/gcc/testsuite/gcc.target/riscv/smaxf.c >> +++ b/gcc/testsuite/gcc.target/riscv/smaxf.c >> @@ -1,4 +1,5 @@ >> /* { dg-do compile } */ >> +/* { dg-require-effective-target hard_float } */ >> /* { dg-options "-ffinite-math-only -fno-signed-zeros -dp" } */ >> >> float >> diff --git a/gcc/testsuite/gcc.target/riscv/smin-ieee.c b/gcc/testsuite/gcc.target/riscv/smin-ieee.c >> index c0a148c37cf1..ea36c2de89fe 100644 >> --- a/gcc/testsuite/gcc.target/riscv/smin-ieee.c >> +++ b/gcc/testsuite/gcc.target/riscv/smin-ieee.c >> @@ -1,4 +1,5 @@ >> /* { dg-do compile } */ >> +/* { dg-require-effective-target hard_float } */ >> /* { dg-options "-ffinite-math-only -fsigned-zeros -dp" } */ >> >> double >> diff --git a/gcc/testsuite/gcc.target/riscv/smin.c b/gcc/testsuite/gcc.target/riscv/smin.c >> index e325e9a1c7cc..d07a0fdc1525 100644 >> --- a/gcc/testsuite/gcc.target/riscv/smin.c >> +++ b/gcc/testsuite/gcc.target/riscv/smin.c >> @@ -1,4 +1,5 @@ >> /* { dg-do compile } */ >> +/* { dg-require-effective-target hard_float } */ >> /* { dg-options "-ffinite-math-only -fno-signed-zeros -dp" } */ >> >> double >> diff --git a/gcc/testsuite/gcc.target/riscv/sminf-ieee.c b/gcc/testsuite/gcc.target/riscv/sminf-ieee.c >> index 353e7a18704a..427617af08f1 100644 >> --- a/gcc/testsuite/gcc.target/riscv/sminf-ieee.c >> +++ b/gcc/testsuite/gcc.target/riscv/sminf-ieee.c >> @@ -1,4 +1,5 @@ >> /* { dg-do compile } */ >> +/* { dg-require-effective-target hard_float } */ >> /* { dg-options "-ffinite-math-only -fsigned-zeros -dp" } */ >> >> float >> diff --git a/gcc/testsuite/gcc.target/riscv/sminf.c b/gcc/testsuite/gcc.target/riscv/sminf.c >> index f0ba7b43bdf9..7df223e8bcad 100644 >> --- a/gcc/testsuite/gcc.target/riscv/sminf.c >> +++ b/gcc/testsuite/gcc.target/riscv/sminf.c >> @@ -1,4 +1,5 @@ >> /* { dg-do compile } */ >> +/* { dg-require-effective-target hard_float } */ >> /* { dg-options "-ffinite-math-only -fno-signed-zeros -dp" } */ >> >> float >> -- >> 2.32.0 >> >