From: Tom de Vries <Tom_deVries@mentor.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Mike Stump <mikestump@comcast.net>,
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Subject: [testsuite, committed] Support dg-add-options in profopt.exp
Date: Wed, 21 Jun 2017 14:27:00 -0000 [thread overview]
Message-ID: <6af0f95f-8623-a299-075f-48fb3f282ee7@mentor.com> (raw)
In-Reply-To: <20170621131930.GQ2123@tucnak>
[-- Attachment #1: Type: text/plain, Size: 2046 bytes --]
[ was: Re: [PATCH, testsuite] Add effective target stack_size ]
On 06/21/2017 03:19 PM, Jakub Jelinek wrote:
> On Fri, Jun 09, 2017 at 04:24:30PM +0200, Tom de Vries wrote:
>> * gcc.dg/tree-prof/comp-goto-1.c: Same.
>> * gcc.dg/tree-prof/pr44777.c: Same.
>
>> --- a/gcc/testsuite/gcc.dg/tree-prof/comp-goto-1.c
>> +++ b/gcc/testsuite/gcc.dg/tree-prof/comp-goto-1.c
>> @@ -1,6 +1,8 @@
>> /* { dg-require-effective-target freorder } */
>> /* { dg-require-effective-target label_values } */
>> /* { dg-options "-O2 -freorder-blocks-and-partition" } */
>> +/* { dg-additional-options "-DSTACK_SIZE=[dg-effective-target-value stack_size]" { target { stack_size } } } */
>> +
>> #include <stdlib.h>
>>
>> #if (!defined(STACK_SIZE) || STACK_SIZE >= 4000) && __INT_MAX__ >= 2147483647
>> diff --git a/gcc/testsuite/gcc.dg/tree-prof/pr44777.c b/gcc/testsuite/gcc.dg/tree-prof/pr44777.c
>> index 4074b75..1249b5b 100644
>> --- a/gcc/testsuite/gcc.dg/tree-prof/pr44777.c
>> +++ b/gcc/testsuite/gcc.dg/tree-prof/pr44777.c
>> @@ -2,6 +2,8 @@
>> /* { dg-require-effective-target label_values } */
>> /* { dg-require-effective-target trampolines } */
>> /* { dg-options "-O0" } */
>> +/* { dg-additional-options "-DSTACK_SIZE=[dg-effective-target-value stack_size]" { target { stack_size } } } */
>> +
>> /* A variant of gcc.c-torture/execute/comp-goto-2.c. */
>>
>> extern void abort (void);
>
> I'm now seeing
> WARNING: profopt.exp does not support dg-add-options
> WARNING: profopt.exp does not support dg-add-options
> so the above doesn't look correct.
Thanks for pointing that out. I've double-checked, and the warnings did
appear for me in the testlogs, but my automated test-comparison
reporting did not pick up on that, I'll have to fix that.
Fixed the warnings by adding dg-add-options support in profopt-get-options.
Tested both test-cases on x86_64.
Tested both test-cases on x86_64 with effective target stack_size set to
0, and verified that -DSTACK_SIZE=0 was passed.
Committed as obvious.
Thanks,
- Tom
[-- Attachment #2: 0002-Support-dg-add-options-in-profopt.exp.patch --]
[-- Type: text/x-patch, Size: 796 bytes --]
Support dg-add-options in profopt.exp
2017-06-21 Tom de Vries <tom@codesourcery.com>
* lib/profopt.exp (profopt-get-options): Support dg-add-options.
---
gcc/testsuite/lib/profopt.exp | 1 +
1 file changed, 1 insertion(+)
diff --git a/gcc/testsuite/lib/profopt.exp b/gcc/testsuite/lib/profopt.exp
index 6519c44..0ea8e7a 100644
--- a/gcc/testsuite/lib/profopt.exp
+++ b/gcc/testsuite/lib/profopt.exp
@@ -249,6 +249,7 @@ proc profopt-get-options { src } {
set cmd [lindex $op 0]
if { ![string compare "dg-options" $cmd] \
|| ![string compare "dg-additional-options" $cmd] \
+ || ![string compare "dg-add-options" $cmd] \
|| ![string compare "dg-skip-if" $cmd] \
|| ![string compare "dg-final-generate" $cmd] \
|| ![string compare "dg-final-use" $cmd] \
next prev parent reply other threads:[~2017-06-21 14:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 14:24 [PATCH, testsuite] Add effective target stack_size Tom de Vries
2017-06-09 15:25 ` Mike Stump
2017-06-12 12:28 ` Christophe Lyon
2017-06-12 14:29 ` Tom de Vries
2017-06-19 9:21 ` Christophe Lyon
2017-06-19 15:42 ` Mike Stump
2017-06-19 17:11 ` Add dg-add-options feature stack_size Tom de Vries
2017-06-19 17:36 ` Mike Stump
2017-06-21 13:19 ` [PATCH, testsuite] Add effective target stack_size Jakub Jelinek
2017-06-21 14:27 ` Tom de Vries [this message]
2022-11-08 20:29 ` nvptx: stack size limits are relevant for execution only (was: [PATCH, testsuite] Add effective target stack_size) Thomas Schwinge
2022-11-25 11:09 ` [PING] " Thomas Schwinge
2022-12-20 7:55 ` [PING^2] " Thomas Schwinge
2023-01-11 11:45 ` [PING^3] " Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6af0f95f-8623-a299-075f-48fb3f282ee7@mentor.com \
--to=tom_devries@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mikestump@comcast.net \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).