From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id F35B53858D35 for ; Wed, 2 Nov 2022 10:45:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F35B53858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linuxfoundation.org Received: by mail-wr1-x431.google.com with SMTP id h9so23951774wrt.0 for ; Wed, 02 Nov 2022 03:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=2arK3IZIsamDplVU2iXa0IFu1yCOHwko6qsDR00wqtk=; b=ATHSg6wKpvGzqkj9BmlzeBIPvbWV1oQakAyCYi1hYZIQS5qW4zQ2ADvqXpfUG5a8ZQ 4YMhaZ4x+4Tynv/hoJU3RR819MZ5IuV47AmAfBFHm05GSNKBwl24rgds4QMkHzdsPzun /JvqTLWyRcloAL1q0/ohLGGnKxZqHfnNC7tCE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2arK3IZIsamDplVU2iXa0IFu1yCOHwko6qsDR00wqtk=; b=4RAFFmI5xXeuFLH0yquMMesarTTebTo7M2q1RWRImGR4z+NPam4jk/8/ykNWadw6bz sg2fFkfIAR0sr4gkqQtUXFBMuUUag2K9x4BZ2fpo6lWe/IYP9YaWSoVfiBu5sEpG/nnX z/o7Y6KshT4Yrr93AQPlXHWesJ+S9tzTSrt0WP9piOjLYrV5JUDbFDklg5WLbNpI7KlE rbC3DuJ5gL/kzxelXmL96f2PNrfeH1Qrh+c8YbhIz3ovk17pSOMd6ZSPaJobN714el8R aXEUtoneSmSxN2XUAUGengkAA9WvY52ul3XEkU0dq9wJRPAW6jQxT24qXj+DcaAS9Dbu DQlw== X-Gm-Message-State: ACrzQf11VBb7CPv4uZ4Tfk63FyYRdGJcNpk7thv/Z1lFl7a1kbDN9eTp mXwQ6NPVLrh03KGWBfDF80jyKVotsJ0xng== X-Google-Smtp-Source: AMsMyM6n3SbSwb8uM0FNd/Hur8u9I6hHt31vSEqABupHiYLE/0boASjNmk8mH3N8SapWYb46N0Zc0A== X-Received: by 2002:a5d:522f:0:b0:235:c877:5cdc with SMTP id i15-20020a5d522f000000b00235c8775cdcmr14922798wra.352.1667385949233; Wed, 02 Nov 2022 03:45:49 -0700 (PDT) Received: from ?IPv6:2001:8b0:aba:5f3c:b8b1:19d6:e9d8:a61a? ([2001:8b0:aba:5f3c:b8b1:19d6:e9d8:a61a]) by smtp.gmail.com with ESMTPSA id m2-20020a5d4a02000000b00236695ff94fsm12392294wrq.34.2022.11.02.03.45.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 03:45:48 -0700 (PDT) Message-ID: <6af4b473cfba6d3ea729dd8e3bbd8bd23fbb94ac.camel@linuxfoundation.org> Subject: Re: [PATCH] config/rs6000/t-float128: Don't encode full build paths into headers From: Richard Purdie To: gcc-patches@gcc.gnu.org Date: Wed, 02 Nov 2022 10:45:46 +0000 In-Reply-To: <20220817121014.1824521-1-richard.purdie@linuxfoundation.org> References: <20220817121014.1824521-1-richard.purdie@linuxfoundation.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2022-08-17 at 13:10 +0100, Richard Purdie via Gcc-patches wrote: > Avoid encoding full build paths into headers, just use the basename of th= e file. > This aids build reproducibility where the build paths vary and source is = saved > for debugging purposes. >=20 > libgcc/ChangeLog: >=20 > * config/rs6000/t-float128: Don't encode full build paths into header= s >=20 I think this patch is at risk of being lost. It is a simple change which aids reproducibility so I'm hoping someone might be able to help with review/merging? Thanks! Richard > Signed-off-by: Richard Purdie > --- > libgcc/config/rs6000/t-float128 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/libgcc/config/rs6000/t-float128 b/libgcc/config/rs6000/t-flo= at128 > index b09b5664af0..513e63748f1 100644 > --- a/libgcc/config/rs6000/t-float128 > +++ b/libgcc/config/rs6000/t-float128 > @@ -103,7 +103,7 @@ $(ibm128_dec_objs) : INTERNAL_CFLAGS +=3D $(IBM128_CF= LAGS_DECIMAL) > $(fp128_softfp_src) : $(srcdir)/soft-fp/$(subst -sw,,$(subst kf,tf,$@)) = $(fp128_dep) > @src=3D"$(srcdir)/soft-fp/$(subst -sw,,$(subst kf,tf,$@))"; \ > echo "Create $@"; \ > - (echo "/* file created from $$src */"; \ > + (echo "/* file created from `basename $$src` */"; \ > echo; \ > sed -f $(fp128_sed) < $$src) > $@ > =20