From: Nathan Sidwell <nathan@acm.org>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: RFC (DECL_CONSTRUCTOR_P): C++ PATCH for c++/83911, ICE with multiversioned constructor
Date: Fri, 16 Feb 2018 23:41:00 -0000 [thread overview]
Message-ID: <6b295441-a4a1-6acf-6e73-159a7aeee968@acm.org> (raw)
In-Reply-To: <CADzB+2mscyD4RO7jz-JVxWZ0hvqy6RdMmG2E3XQgPUy9-5y9ng@mail.gmail.com>
On 02/16/2018 05:48 PM, Jason Merrill wrote:
> We hit the bug in this testcase because build_over_call replaces the
> constructor with a dispatcher function, and then build_aggr_init_expr
> doesn't recognize it as a constructor.
>
> Messing with the DECL_NAME of the dispatcher seems messy, but copying
> the DECL_CXX_CONSTRUCTOR_P flag is easy. So we can change the test in
> build_aggr_init_expr, or change the definition of DECL_CONSTRUCTOR_P.
> I lean toward the latter as more uniform, but not strongly. Do you
> have an opinion?
Using the ctor name for the dispatcher doesn't seem wonky to me -- it is after
all a constructor. But then I've not looked at the code. Might be bored in
airports tomorrow ... If I fail to respond, go with your approach.
nathan
--
Nathan Sidwell
next prev parent reply other threads:[~2018-02-16 23:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 22:48 Jason Merrill
2018-02-16 23:41 ` Nathan Sidwell [this message]
2018-02-17 19:15 ` Nathan Sidwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b295441-a4a1-6acf-6e73-159a7aeee968@acm.org \
--to=nathan@acm.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).