From: Jeff Law <law@redhat.com>
To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com
Subject: Re: [07/13] Use function_arg_info for TARGET_FUNCTION_ARG_ADVANCE
Date: Mon, 19 Aug 2019 21:11:00 -0000 [thread overview]
Message-ID: <6b2f6016-0feb-8ecc-a554-e4bc1168fd53@redhat.com> (raw)
In-Reply-To: <mpt36hxchfy.fsf@arm.com>
On 8/19/19 9:18 AM, Richard Sandiford wrote:
> Use function_arg_info for TARGET_FUNCTION_ARG_ADVANCE.
>
> There seems to be a bit of confusion around this one. Almost all
> callers pass the same arguments as TARGET_FUNCTION_ARG, meaning
> that the mode is the promoted mode rather than the type mode.
> But the calls.c handling for normal typed arguments instead passes
> the unpromoted TYPE_MODE (despite passing the promoted mode to
> TARGET_FUNCTION_ARG). I've kept this behaviour with a ??? comment.
>
> (The calls.c handling of libgcc functions does pass the promoted
> mode though, as does the function.c handling of incoming arguments.)
>
> Also, a couple of the arm callers don't seem to be using the hook
> correctly. Again I kept the current choices and added a ??? comment.
Keeping current behavior seems reasonable as does marking the
inconsistent bits.
>
>
> 2019-08-19 Richard Sandiford <richard.sandiford@arm.com>
>
> gcc/
> * target.def (function_arg_advance): Take a function_arg_info instead
> of a mode, type and named flag.
> * doc/tm.texi: Regenerate.
> * targhooks.h (default_function_arg_advance): Take a function_arg_info
> instead of a mode, type and named flag.
> * targhooks.c (default_function_arg_advance): Likewise.
> * calls.c (initialize_argument_information): Update call to
> targetm.calls.function_arg_advance.
> (emit_library_call_value_1): Likewise.
> * dse.c (get_call_args): Likewise.
> * expr.c (block_move_libcall_safe_for_call_parm): Likewise.
> * function.c (assign_parms, gimplify_parameters): Likewise.
> * var-tracking.c (prepare_call_arguments): Likewise.
> * config/aarch64/aarch64.c (aarch64_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> (aarch64_setup_incoming_varargs): Update call accordingly.
> * config/alpha/alpha.c (alpha_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> (alpha_setup_incoming_varargs): Update call accordingly.
> * config/arc/arc.c (arc_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> (arc_setup_incoming_varargs): Update call accordingly.
> * config/arm/arm.c (arm_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> (cmse_func_args_or_return_in_stack): Update call accordingly.
> (arm_function_ok_for_sibcall): Likewise.
> (cmse_nonsecure_call_clear_caller_saved): Likewise.
> * config/avr/avr.c (avr_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> * config/bfin/bfin.c (bfin_function_arg_advance): Likewise.
> * config/c6x/c6x.c (c6x_function_arg_advance): Likewise.
> (c6x_call_saved_register_used): Update call accordingly.
> * config/cr16/cr16.c (cr16_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> * config/cris/cris.c (cris_function_arg_advance): Likewise.
> * config/csky/csky.c (csky_function_arg_advance): Likewise.
> (csky_setup_incoming_varargs): Update call accordingly.
> * config/epiphany/epiphany.c (epiphany_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> * config/fr30/fr30.c (fr30_function_arg_advance): Likewise.
> * config/frv/frv.c (frv_function_arg_advance): Likewise.
> * config/ft32/ft32.c (ft32_function_arg_advance): Likewise.
> * config/gcn/gcn.c (gcn_function_arg_advance): Likewise.
> * config/h8300/h8300.c (h8300_function_arg_advance): Likewise.
> * config/i386/i386.c (ix86_function_arg_advance): Likewise.
> (ix86_setup_incoming_varargs): Update call accordingly.
> * config/ia64/ia64.c (ia64_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> (ia64_setup_incoming_varargs): Update call accordingly.
> * config/iq2000/iq2000.c (iq2000_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> (iq2000_expand_prologue): Update call accordingly.
> * config/lm32/lm32.c (lm32_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> * config/m32c/m32c.c (m32c_function_arg_advance): Likewise.
> * config/m32r/m32r.c (m32r_function_arg_advance): Likewise.
> * config/m68k/m68k.c (m68k_function_arg_advance): Likewise.
> * config/mcore/mcore.c (mcore_function_arg_advance): Likewise.
> * config/microblaze/microblaze.c (microblaze_function_arg_advance):
> Likewise.
> (microblaze_expand_prologue): Update call accordingly.
> * config/mips/mips.c (mips_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> (mips_setup_incoming_varargs): Update call accordingly.
> (mips_output_args_xfer): Likewise.
> * config/mmix/mmix.c (mmix_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> * config/mn10300/mn10300.c (mn10300_function_arg_advance): Likewise.
> * config/moxie/moxie.c (moxie_function_arg_advance): Likewise.
> * config/msp430/msp430.c (msp430_function_arg_advance): Likewise.
> * config/nds32/nds32.c (nds32_function_arg_advance): Likewise.
> * config/nios2/nios2.c (nios2_function_arg_advance): Likewise.
> (nios2_setup_incoming_varargs): Update call accordingly.
> * config/nvptx/nvptx.c (nvptx_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> * config/or1k/or1k.c (or1k_function_arg_advance): Likewise.
> * config/pa/pa.c (pa_function_arg_advance): Likewise.
> * config/pdp11/pdp11.c (pdp11_function_arg_advance): Likewise.
> * config/pru/pru.c (pru_function_arg_advance): Likewise.
> * config/riscv/riscv.c (riscv_function_arg_advance): Likewise.
> (riscv_setup_incoming_varargs): Update call accordingly.
> * config/rl78/rl78.c (rl78_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> * config/rs6000/rs6000-internal.h (rs6000_function_arg_advance):
> Likewise.
> * config/rs6000/rs6000-call.c (rs6000_function_arg_advance): Likewise.
> (rs6000_parm_needs_stack): Update call accordingly.
> * config/rx/rx.c (rx_function_arg_advance): Take a function_arg_info
> instead of a mode, type and named flag.
> * config/s390/s390.c (s390_function_arg_advance): Likewise.
> (s390_call_saved_register_used): Update call accordingly.
> * config/sh/sh.c (sh_function_arg_advance): Take a function_arg_info
> instead of a mode, type and named flag.
> (sh_output_mi_thunk): Update call accordingly.
> * config/sparc/sparc.c (sparc_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> * config/spu/spu.c (spu_function_arg_advance): Likewise.
> (spu_setup_incoming_varargs): Update call accordingly.
> * config/stormy16/stormy16.c (xstormy16_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> * config/tilegx/tilegx.c (tilegx_function_arg_advance): Likewise.
> (tilegx_setup_incoming_varargs): Update call accordingly.
> * config/tilepro/tilepro.c (tilepro_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> (tilegx_setup_incoming_varargs): Update call accordingly.
> * config/v850/v850.c (v850_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
> * config/vax/vax.c (vax_function_arg_advance): Likewise.
> * config/visium/visium.c (visium_function_arg_advance): Likewise.
> (visium_setup_incoming_varargs): Update call accordingly.
> * config/xtensa/xtensa.c (xtensa_function_arg_advance): Take a
> function_arg_info instead of a mode, type and named flag.
>
OK
jeff
next prev parent reply other threads:[~2019-08-19 20:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 15:15 [00/13] Pass an argument descriptor to target hooks Richard Sandiford
2019-08-19 15:16 ` [01/13] Add pass_va_arg_by_reference Richard Sandiford
2019-08-19 20:04 ` Jeff Law
2019-08-19 15:17 ` [02/13] Add must_pass_va_arg_in_stack Richard Sandiford
2019-08-19 20:05 ` Jeff Law
2019-08-19 15:18 ` [03/13] Use function_arg_info for TARGET_ARG_PARTIAL_BYTES Richard Sandiford
2019-08-19 20:42 ` Jeff Law
2019-08-19 15:19 ` [04/13] Use function_arg_info for TARGET_PASS_BY_REFERENCE Richard Sandiford
2019-08-19 20:43 ` Jeff Law
2019-08-19 15:20 ` [05/13] Use function_arg_info for TARGET_SETUP_INCOMING_ARGS Richard Sandiford
2019-08-19 20:50 ` Jeff Law
2019-08-19 15:21 ` [06/13] Use function_arg_info for TARGET_FUNCTION_(INCOMING_)ARG Richard Sandiford
2019-08-19 21:07 ` Jeff Law
2019-08-19 15:22 ` [07/13] Use function_arg_info for TARGET_FUNCTION_ARG_ADVANCE Richard Sandiford
2019-08-19 21:11 ` Jeff Law [this message]
2019-08-19 15:23 ` [08/13] Use function_arg_info for TARGET_CALLEE_COPIES Richard Sandiford
2019-08-19 21:16 ` Jeff Law
2019-08-19 15:24 ` [09/13] Use function_arg_info for TARGET_MUST_PASS_IN_STACK Richard Sandiford
2019-08-19 22:04 ` Jeff Law
2019-08-19 15:47 ` [10/13] Add a apply_pass_by_reference_rules helper Richard Sandiford
2019-08-19 22:19 ` Jeff Law
2019-08-19 15:51 ` [11/13] Make function.c use function_arg_info internally Richard Sandiford
2019-08-19 22:47 ` Jeff Law
2019-08-19 15:52 ` [12/13] Make calls.c " Richard Sandiford
2019-08-19 22:49 ` Jeff Law
2019-08-19 15:52 ` [13/13] Add a pass_by_reference flag to function_arg_info Richard Sandiford
2019-08-19 22:54 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b2f6016-0feb-8ecc-a554-e4bc1168fd53@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).