From: Andreas Krebbel <krebbel@linux.ibm.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] s390: Fix up *cmp_and_trap_unsigned_int<mode> constraints [PR104775]
Date: Mon, 7 Mar 2022 11:10:07 +0100 [thread overview]
Message-ID: <6b3b81b7-cb69-2a89-ff49-6adf575b21e2@linux.ibm.com> (raw)
In-Reply-To: <YiMgdlKRkRVbpo+I@tucnak>
On 3/5/22 09:33, Jakub Jelinek wrote:
> Hi!
>
> The following testcase fails to assemble due to clgte %r6,0(%r1,%r10)
> insn not being accepted by assembler.
> My rough understanding is that in the RSY-b insn format the spot
> in other formats used for index registers is used instead for M3 what
> kind of comparison it is, so this patch follows what other similar
> instructions use for constraint (i.e. one without index register).
>
> Bootstrapped on s390x-linux, regtest there still pending, ok for
> trunk if it passes it?
>
> 2022-03-05 Jakub Jelinek <jakub@redhat.com>
>
> PR target/104775
> * config/s390/s390.md (*cmp_and_trap_unsigned_int<mode>): Use
> S constraint instead of T in the last alternative.
>
> * gcc.target/s390/pr104775.c: New test.
Ok. Thanks for the fix!
Bye,
Andreas
prev parent reply other threads:[~2022-03-07 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-05 8:33 Jakub Jelinek
2022-03-06 9:15 ` Jakub Jelinek
2022-03-07 10:10 ` Andreas Krebbel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b3b81b7-cb69-2a89-ff49-6adf575b21e2@linux.ibm.com \
--to=krebbel@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).