From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id E0FE3383983F; Fri, 10 Jun 2022 11:22:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E0FE3383983F Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id C386A667D2; Fri, 10 Jun 2022 07:22:20 -0400 (EDT) Message-ID: <6b83d5a42ee91313c2d37da1f55a08819258e589.camel@xry111.site> Subject: Re: [PING][PATCH][WIP] have configure probe prefix for gmp/mpfr/mpc [PR44425] From: Xi Ruoyao To: Eric Gallager , gcc-patches Cc: Paolo Bonzini , aoliva@gcc.gnu.org, neroden@gcc.gnu.org Date: Fri, 10 Jun 2022 19:22:19 +0800 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2 MIME-Version: 1.0 X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FROM_SUSPICIOUS_NTLD, KAM_SHORT, LIKELY_SPAM_FROM, PDS_OTHER_BAD_TLD, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2022 11:22:26 -0000 On Thu, 2022-06-09 at 16:04 -0400, Eric Gallager via Gcc-patches wrote: > Hi, I'd like to ping this patch: > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596126.html > (cc-ing the build machinery maintainers listed in MAINTAINERS this > time) >=20 > On Thu, Jun 2, 2022 at 11:53 AM Eric Gallager > wrote: > >=20 > > So, I'm working on fixing PR bootstrap/44425, and have this patch to > > have the top-level configure script check in the value passed to > > `--prefix=3D` when looking for gmp/mpfr/mpc. It "works" (in that > > configuring with just `--prefix=3D` and none of > > `--with-gmp=3D`/`--with-mpfr=3D`/`--with-mpc=3D` now works where it fai= led > > before), but unfortunately it results in a bunch of duplicated > > `-I`/`-L` flags stuck in ${gmplibs} and ${gmpinc}... is that > > acceptable or should I try another approach? > > Eric A patch should not edit configure directly. configure.ac should be edited and configure should be regenerated from it. --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University