From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103237 invoked by alias); 1 Aug 2018 09:13:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 103222 invoked by uid 89); 1 Aug 2018 09:13:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR04-VI1-obe.outbound.protection.outlook.com Received: from mail-eopbgr80054.outbound.protection.outlook.com (HELO EUR04-VI1-obe.outbound.protection.outlook.com) (40.107.8.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Aug 2018 09:13:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gnufXobgW9zvPNDW4sIXNToXtrp0diS6DE2mChyBqDw=; b=gIVeCLWZqSU5uINnZXYEpuhPQ/EGOr2BvbUcxClqD8crTd+m59N/uNQOx38zuKEuEYELQ+L2LqKkQF22P/FM+Ime/Je9vzk+dGPUZt7xlICCCDWhA9a3YMh24GoB7U4YculE5pt5OeVVDr3rDjHUvIq2ntDsKKfoIwqXr/F0WcU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Sam.Tebbs@arm.com; Received: from [10.2.206.46] (217.140.106.6) by AM6PR08MB3432.eurprd08.prod.outlook.com (2603:10a6:20b:44::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.19; Wed, 1 Aug 2018 09:13:15 +0000 Subject: Re: [GCC][PATCH][Aarch64] Stop redundant zero-extension after UMOV when in DI mode To: "gcc-patches@gcc.gnu.org" Cc: James Greenhalgh , Sudakshina Das , Marcus Shawcroft , nd , Richard Earnshaw References: <953dbdd2-e20c-4587-3e0d-ad1a65fc93c6@arm.com> <85b58ddb-3da2-67c6-1514-e308201191d3@arm.com> <74da7cb6-485b-3ce4-7901-d10cb6f1ed95@arm.com> <9e7ccf5b-55b9-543d-1f9e-f9ab36e93376@arm.com> <20180731221625.GH1826@arm.com> From: Sam Tebbs Message-ID: <6be85f18-5f4c-0312-cc0a-bc1b69e9a183@arm.com> Date: Wed, 01 Aug 2018 09:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180731221625.GH1826@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-Path: sam.tebbs@arm.com Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00015.txt.bz2 On 07/31/2018 11:16 PM, James Greenhalgh wrote: > On Thu, Jul 26, 2018 at 11:52:15AM -0500, Sam Tebbs wrote: > > > >>> Thanks for making the changes and adding more test cases. I do however >>> see that you are only covering 2 out of 4 new >>> *aarch64_get_lane_zero_extenddi<> patterns. The >>> *aarch64_get_lane_zero_extendsi<> were already existing. I don't mind >>> those tests. I would just ask you to add the other two new patterns >>> as well. Also since the different versions of the instruction generate >>> same instructions (like foo_16qi and foo_8qi both give out the same >>> instruction), I would suggest using a -fdump-rtl-final (or any relevant >>> rtl dump) with the dg-options and using a scan-rtl-dump to scan the >>> pattern name. Something like: >>> /* { dg-do compile } */ >>> /* { dg-options "-O3 -fdump-rtl-final" } */ >>> ... >>> ... >>> /* { dg-final { scan-rtl-dump "aarch64_get_lane_zero_extenddiv16qi" >>> "final" } } */ >>> >>> Thanks >>> Sudi >> Hi Sudi, >> >> Thanks again. Here's an update that adds 4 more tests, so all 8 patterns >> generated are now tested for! > This is OK for trunk, thanks for the patch (and thanks Sudi for the review!) > > Thanks, > James Thank you James! I'd appreciate it if someone could commit it as I don't have commit rights yet. Sam > >> Below is the updated changelog >> >> gcc/ >> 2018-07-26  Sam Tebbs  >> >>         * config/aarch64/aarch64-simd.md >>         (*aarch64_get_lane_zero_extendsi): >>         Rename to... >> (*aarch64_get_lane_zero_extend): ... This. >>         Use GPI iterator instead of SI mode. >> >> gcc/testsuite >> 2018-07-26  Sam Tebbs  >> >>         * gcc.target/aarch64/extract_zero_extend.c: New file >>