On 10/12/2018 05:56 AM, Alexandre Oliva wrote:
> On Oct 11, 2018, JonY <10walls@gmail.com> wrote:
> 
>> On 10/11/2018 02:57 AM, NightStrike wrote:
>>>
>>> Except that options typically don't get removed, just deprecated.  It
>>> seems cleaner to me to drop mingw from the name and make it default to
>>> enabled for cygwin.
> 
>> It is already enabled for Cygwin,
> 
> plus, I have no evidence that Cygwin even works without
> --large-address-aware, and I have no way to test that.
> 
>> but good point,
>> --enable-large-address-aware it is, but enabled only for mingw for now,
>> as such in the original patch.
> 
> Here's the patch, adjusted as requested and retested.  Ok to install?
> 
> 
> introduce --enable-large-address-aware
> 
> From: Alexandre Oliva <oliva@adacore.com>
> 
> Add a configure knob for mingw32 and 64 toolchains to default passing
> --large-address-aware to the linker, when creating 32-bit binaries.
> -Wl,--disable-large-address-aware can still reverse its effects.
> 
> for  gcc/ChangeLog
> 
> 	* configure.ac: Introduce --enable-large-address-aware
> 	to define MINGW_DEFAULT_LARGE_ADDR_AWARE.
> 	* doc/install.texi: Document it.
> 	* configure, config.in: Rebuilt.
> 	* config/i386/mingw32.h (LINK_SPEC_LARGE_ADDR_AWARE): Define,
> 	based on MINGW_DEFAULT_LARGE_ADDR_AWARE.
> 	(LINK_SPEC): Insert it.
> 	* config/i386/mingw-264.h: Likewise.

Patch looks OK to be.