From: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
To: "Mark Mitchell" <mark@codesourcery.com>
Cc: "GCC Patches" <gcc-patches@gcc.gnu.org>,
"Tom Tromey" <tromey@redhat.com>
Subject: Re: [CPP] 28079 #line range not verified without -pedantic
Date: Fri, 29 Feb 2008 20:20:00 -0000 [thread overview]
Message-ID: <6c33472e0802291215v56258847n20330b4bb0d3214c@mail.gmail.com> (raw)
In-Reply-To: <47C8634A.9020901@codesourcery.com>
On 29/02/2008, Mark Mitchell <mark@codesourcery.com> wrote:
> Manuel López-Ibáñez wrote:
>
> You didn't document this new possible return value. I don't see any
> reason to return 2; do you need this change? If not, please just take
> it out.
Good catch! That was a typo indeed. Thanks!
> It's a shame we don't make better use of typedefs throughout GCC. A lot
> of these problems would be less likely to occur if we had something like
>
> typedef unsigned long linenum_type;
>
> and then just used that everywhere...
Well, I didn't try that just because I assumed that there was a reason
to to use int as the line number, but, with hindsight, that seems
unlikely. I can try to change at least this part of the preprocessor
to use a typedef if the preprocessor maintainers think that is OK.
Cheers,
Manuel.
next prev parent reply other threads:[~2008-02-29 20:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 17:07 Manuel López-Ibáñez
2008-02-29 20:09 ` Mark Mitchell
2008-02-29 20:20 ` Manuel López-Ibáñez [this message]
2008-02-29 22:05 ` Mark Mitchell
2008-03-07 15:34 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c33472e0802291215v56258847n20330b4bb0d3214c@mail.gmail.com \
--to=lopezibanez@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mark@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).