From: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
To: "Gabriel Dos Reis" <gdr@integrable-solutions.net>
Cc: "GCC Patches" <gcc-patches@gcc.gnu.org>
Subject: Re: [4.4] remove diagnostic_count_diagnostic
Date: Fri, 14 Mar 2008 10:06:00 -0000 [thread overview]
Message-ID: <6c33472e0803140248i4740d942o5b5394bfcdd13896@mail.gmail.com> (raw)
In-Reply-To: <6c33472e0802251518r5ec8f889x6a92cffe37a6fe29@mail.gmail.com>
PING: http://gcc.gnu.org/ml/gcc-patches/2008-02/msg01108.html
Gabriel,
If the unified patch is confusing you, please look at the resulting
code. No behaviour is changed at all.
Cheers,
Manuel.
On 26/02/2008, Manuel López-Ibáñez <lopezibanez@gmail.com> wrote:
> On 25/02/2008, Gabriel Dos Reis <gdr@integrable-solutions.net> wrote:
> > On Mon, Feb 25, 2008 at 1:40 PM, Manuel López-Ibáñez
> > <lopezibanez@gmail.com> wrote:
> > > On 25/02/2008, Gabriel Dos Reis <gdr@integrable-solutions.net> wrote:
> > > > I believe this patch misses the semantics of the function.
> > > > It isn't just to return true. It also count the number of
> > > > diagnostic kinds emitted.
> > >
> > > This is done by the following line:
> > >
> > > + ++diagnostic_kind_count (context, diagnostic->kind);
> > >
> > > No more is needed to count a diagnostic. Of course, we could
> > > encapsulate that in a function:
> > >
> > > static void
> > > diagnostic_count_diagnostic (diagnostic_context *context,
> > > diagnostic_info *diagnostic)
> > > {
> > > ++diagnostic_kind_count (context, diagnostic->kind);
> > > }
> > >
> > > Do we really need to do that? Nobody outside diagnostics.c is using
> > > such function.
> > >
> >
> >
> > Counting the different kinds of diagnostics is all that I would like retained.
>
>
> But my patch does that, so what do you mean?
>
> Cheers,
>
>
> Manuel.
>
next prev parent reply other threads:[~2008-03-14 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 21:14 Manuel López-Ibáñez
2008-02-25 19:41 ` Gabriel Dos Reis
2008-02-25 19:45 ` Manuel López-Ibáñez
2008-02-25 20:05 ` Gabriel Dos Reis
2008-02-25 23:29 ` Manuel López-Ibáñez
2008-03-14 10:06 ` Manuel López-Ibáñez [this message]
2008-03-14 23:20 ` Gabriel Dos Reis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c33472e0803140248i4740d942o5b5394bfcdd13896@mail.gmail.com \
--to=lopezibanez@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdr@integrable-solutions.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).