public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Manuel López-Ibáñez" <lopezibanez@gmail.com>
To: "Paolo Carlini" <paolo.carlini@oracle.com>
Cc: "Gcc Patch List" <gcc-patches@gcc.gnu.org>,
	 	"Mark Mitchell" <mark@codesourcery.com>
Subject: Re: [C++ Patch] PR 35321
Date: Sun, 17 Aug 2008 21:34:00 -0000	[thread overview]
Message-ID: <6c33472e0808171326q5d77a3bbj8823a44d7185d6c6@mail.gmail.com> (raw)
In-Reply-To: <48A86360.8010104@oracle.com>

2008/8/17 Paolo Carlini <paolo.carlini@oracle.com>:
> +   __builtin_offsetof(B, a[0]); /* { dg-error "error: cannot
> apply.*offsetof" } */

I am sorry for being so picky but I would suggest to not use ".*" in
matches That will match anything including newlines. I guess that in
this case it would be very strange to generate by error multiple
messages that start with "cannot apply" and finish with  offsetof.
However, it is better to be consistent.

In this case you just need "error: cannot apply .offsetof" but I think
it would be better if you use:

"error: cannot apply .offsetof. when .operator[]. is overloaded"

If such message changes in the future we can do a "find + sed" for all
instances. However, matching a partial message is more error prone
(less future proof).

Cheers,

Manuel.

PS: To really match anything but not newlines you should use \[^\n\]*.
I wish there was a way to tell DejaGNU to not match newlines with '.'

  reply	other threads:[~2008-08-17 20:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-17 20:26 Paolo Carlini
2008-08-17 21:34 ` Manuel López-Ibáñez [this message]
2008-08-17 22:00   ` Paolo Carlini
2008-08-18  1:54     ` Manuel López-Ibáñez
2008-08-18  6:06   ` Paolo Carlini
2008-08-28 16:55     ` Mark Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c33472e0808171326q5d77a3bbj8823a44d7185d6c6@mail.gmail.com \
    --to=lopezibanez@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mark@codesourcery.com \
    --cc=paolo.carlini@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).