From: Jeff Law <jeffreyalaw@gmail.com>
To: Xi Ruoyao <xry111@xry111.site>, gcc-patches@gcc.gnu.org
Cc: Andrew Pinski <quic_apinski@quicinc.com>,
"Kewen . Lin" <linkw@linux.ibm.com>,
Jakub Jelinek <jakub@redhat.com>,
chenxiaolong@loongson.cn
Subject: Re: [PATCH v2] testsuite: Make pr104992.c irrelated to target vector feature [PR113418]
Date: Sun, 3 Mar 2024 15:00:25 -0700 [thread overview]
Message-ID: <6c382e58-f167-4411-baf7-171545693c8d@gmail.com> (raw)
In-Reply-To: <20240229070701.56554-1-xry111@xry111.site>
On 2/29/24 00:06, Xi Ruoyao wrote:
> The vect_int_mod target selector is evaluated with the options in
> DEFAULT_VECTCFLAGS in effect, but these options are not automatically
> passed to tests out of the vect directories. So this test fails on
> targets where integer vector modulo operation is supported but requiring
> an option to enable, for example LoongArch.
>
> In this test case, the only expected optimization not happened in
> original is in corge because it needs forward propogation. So we can
> scan the forwprop2 dump (where the vector operation is not expanded to
> scalars yet) instead of optimized, then we don't need to consider
> vect_int_mod or not.
>
> gcc/testsuite/ChangeLog:
>
> PR testsuite/113418
> * gcc.dg/pr104992.c (dg-options): Use -fdump-tree-forwprop2
> instead of -fdump-tree-optimized.
> (dg-final): Scan forwprop2 dump instead of optimized, and remove
> the use of vect_int_mod.
> * lib/target-supports.exp (check_effective_target_vect_int_mod):
> Remove because it's not used anymore.
> ---
>
> v1->v2: Remove check_effective_target_vect_int_mod as it's now unused.
>
> This fixes the test failure on loongarch64-linux-gnu. Also tested on
> x86_64-linux-gnu. Ok for trunk?
>
> gcc/testsuite/gcc.dg/pr104992.c | 5 ++---
> gcc/testsuite/lib/target-supports.exp | 13 -------------
> 2 files changed, 2 insertions(+), 16 deletions(-)
While not strictly a regression, it's just the testsuite so I think this
is OK for the trunk, even though we're in stage4.
jeff
prev parent reply other threads:[~2024-03-03 22:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 7:06 Xi Ruoyao
2024-03-03 22:00 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c382e58-f167-4411-baf7-171545693c8d@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=chenxiaolong@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=linkw@linux.ibm.com \
--cc=quic_apinski@quicinc.com \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).