From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id A21A73858D1E for ; Fri, 5 Apr 2024 21:46:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A21A73858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A21A73858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712353595; cv=none; b=GPjyvQ0+nTDJnaXIxhui5HAc9zGxY4mpM+HYJgN0t4GlFQ2gnCrIORJu88zWRR6tRlsYqA0d09ZtXNS6nEinvBThsam2abev960b06RJ1OsAcxrq/qCnaU3/SQWwZh+UMtO5s79o4vsYWKDOUeZUWGr67uKvXhVIRDyfDN2TsMI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712353595; c=relaxed/simple; bh=mt/Bv1IQKNNqgCz/MM+rCo+vwyA0D82dkun0BoleIEw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=gVz7atW9TTP8zz6k6Dy4FjYICkb3DvUjnYkXMIDoFBZ9cU12uAuAHCCKeCRakhb0rU9VbTjYAEpR+FnXCZKAa4DxP2tJgO3hhwjgDbiSWJa7u5qsj1uV9pYmpp/oBuL2dXde4hBt1RwKzBahghGueO5KB95xWnj0XGY2F+iFALc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1e2a2d5f0b7so19883225ad.1 for ; Fri, 05 Apr 2024 14:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712353592; x=1712958392; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S3CycahIMLgVPyW0MiAd+Z3p6/KphV2CgZeR9oDxkbI=; b=PYoArWf9NWJdgzSoelvH6wU27nZqzLdx61OOvlXFA9HdRoE+6+LuwNQ1peJv/yknUw 8q9jIVCnDTorFsqo7fUG8FI/qxk/7l9YcqxijdMXhg8HxfGzFZyZY2u+xCKk3Lv46XEQ 8A7U/tRE8wvKYYRyJmtQeV6xkUlFKHYtFeBQmQPzHvMfrLuTKDjBD8oGQ91e7oUdQngm X1oal+o1Om8wCpCVZCrbaraISX1G40hoX02nAwbbpSV8MxPMZgHdAE3ArYhbKpLTwwl0 JOITWM+pUPZBlEfJhBQ5HpWjQRzyJsEG7TUiekT8OD5P/J7m3ZC36udePVdVnyxXm3qF mQBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712353592; x=1712958392; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S3CycahIMLgVPyW0MiAd+Z3p6/KphV2CgZeR9oDxkbI=; b=Q69DCrRC5KZ26fuFmgJudn80UznOtmE3FUFUGVXgsUWFa6tUoAYxObQCo9whG3jUUN 6IlH94CjvPEIU1wxqM02r2pdeO/Sh/bbwdR7yTbs5V3WFlsPgQ/ru6NBab5hLUpjTMP/ JnBFQfhfEaG6YX2H1lN0KCfS3D7oKDOab12pNuuafoSB22RDb5ef9L5oV29Wjf1dVsvh A7S3/umj8psNkbpkAysWWg60tBjn2arHlzq0faRJf3dlYkdOJUhoOfFpZReaHj8uYZI5 tVkTBAIOH6n6VWHfUQIvksOQhegxZuwx8o2AquFyK+B0mp6c21GHmI4ibDng+I3ERjW+ uJVA== X-Gm-Message-State: AOJu0YzBDSxInApCOafWeYYTaZmlHnQaR+BRRkJOSTxMnmUQlUWC8SpK nzYKs9CBuiUz0BZfvVuVxUHu/CwEt1L1hlzuPOL6isBa+6jRPsZf X-Google-Smtp-Source: AGHT+IFWKFt6cqTGZvRUK50YvjIqYCjnrsaVDQ6yFBmyVtqp4T9SK482SkMjKbnWu1sGrCW+0o9OOg== X-Received: by 2002:a17:903:2286:b0:1e2:c8bc:6bf2 with SMTP id b6-20020a170903228600b001e2c8bc6bf2mr3111212plh.30.1712353592384; Fri, 05 Apr 2024 14:46:32 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id e7-20020a170902784700b001e2ad8cd0f0sm2123575pln.133.2024.04.05.14.46.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 14:46:31 -0700 (PDT) Message-ID: <6c387fd6-bf1d-45b5-b4bb-96a947217a5c@gmail.com> Date: Fri, 5 Apr 2024 15:46:30 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH] rtl-optimization/101523 - avoid re-combine after noop 2->2 combination Content-Language: en-US To: Segher Boessenkool , Richard Biener Cc: gcc-patches@gcc.gnu.org, Jakub Jelinek References: <202404031107.433B7hCA019240@gate.crashing.org> <20240405212754.GL19790@gate.crashing.org> From: Jeff Law In-Reply-To: <20240405212754.GL19790@gate.crashing.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/5/24 3:27 PM, Segher Boessenkool wrote: > Hi! > > On Wed, Apr 03, 2024 at 01:07:41PM +0200, Richard Biener wrote: >> The following avoids re-walking and re-combining the instructions >> between i2 and i3 when the pattern of i2 doesn't change. >> >> Bootstrap and regtest running ontop of a reversal of >> r14-9692-g839bc42772ba7a. > > Please include that in the patch (or series, preferably). > >> It brings down memory use frmo 9GB to 400MB and compile-time from >> 80s to 3.5s. r14-9692-g839bc42772ba7a does better in both metrics >> but has shown code generation regressions across acrchitectures. >> >> OK to revert r14-9692-g839bc42772ba7a? > > No. > > The patch solved a very real problem. How does your replacement handle > that? You don't say. It looks like it only battles symptoms a bit, > instead :-( But that patch very clearly created new problems in the process. I would argue that it was a step backwards given that we're in stage4. Jeff