From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 709AD3858D28 for ; Mon, 7 Aug 2023 17:36:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 709AD3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1bbff6b2679so30613745ad.1 for ; Mon, 07 Aug 2023 10:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691429787; x=1692034587; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1aqGyv04P+AKLEuvN+cPdtZMc8pWhiKC8ZhBebcyN/U=; b=N4F+LYlFIk/8gTCu1VKH5sUYfU/8hBN/i/TuFvxmD9lCoLyI8Ay84h1vCob05K9Mgp SCAXnR8W2ZQIDmA/xk6vZAiGf800RxXQGBX6ESdmImWaJI9inKhINgYe6jvKrDzoycBG TZEFBaEp6Jpka1ivR46r4QFO7Wb5m5X/PfLaHeHum7iza7ueaKY++v68/AOgZlmA45Td 1FGXy5mPMkRuZLiIQbBYZ3/LvaeBPKLpHiZ6x0OQ0IAmJqcOWkknqLlC99JUnpbdrfWv rEPy9rBrazz+wNMJ0REpewCNLofwq2HssPTlbZUHpRkDQAyicmrnuyZaa0IQBvEHStw9 s/Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691429787; x=1692034587; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1aqGyv04P+AKLEuvN+cPdtZMc8pWhiKC8ZhBebcyN/U=; b=AyTnSRa2DN2o89Xfh6NaRjjPX7xXYhxlEM/dZbylczZhk6M3cBSxCjyve2Tng705X/ TKsfzWuvbt9xHBp/oIlFSUPeAHzl8/mkWXLnkGDJqBl8mZ9VBd90Zr58Pj44XxjRHt8G lta9zISBKJGbanXjuY3zbHng7TJthZTItvBsp0c+dwMspZOK/IN0OAb6+PanqFd3Sc5H +Qya/NwKkq0kAVUdO14CBbe2i5gYVLxsbBVfdw/YA23D18UbAGYCR+gR5Qvs5XD9yVjw lq4WdxL/UnA8YVm1yLeqbeut5ZfQUELcIQqkbUE2mPGEFBIhrrsCRqfmol+obq8oIK4+ LYlg== X-Gm-Message-State: AOJu0YymEh2eSI9PmYG9MKcVurorbLQHWxIdqyXEOo8uZjpOSae0v46g sd1jRXyEO25oP/vopXVeQEwYn2nglLs= X-Google-Smtp-Source: AGHT+IGQiTYvtP3c/xwcnZ6npUJpSQNYyh48apoAxdXANyTf3a+klDkBAeFrAryNLm64eIOZmOIaNA== X-Received: by 2002:a17:902:ab86:b0:1b8:7618:5414 with SMTP id f6-20020a170902ab8600b001b876185414mr7082336plr.60.1691429787313; Mon, 07 Aug 2023 10:36:27 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id i14-20020a17090332ce00b001b9de2b905asm7152236plr.231.2023.08.07.10.36.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 10:36:26 -0700 (PDT) Message-ID: <6c534e9c-3295-716e-8636-4a451f9e443b@gmail.com> Date: Mon, 7 Aug 2023 11:36:25 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 4/5] [RISC-V] Generate Zicond instruction for select pattern with condition eq or neq to non-zero Content-Language: en-US To: Xiao Zeng , gcc-patches@gcc.gnu.org Cc: research_trasio@irq.a4lg.com, kito.cheng@gmail.com, zhengyu@eswincomputing.com, eri-sw-toolchain@eswincomputing.com References: <20230719101156.21771-1-zengxiao@eswincomputing.com> <20230719101156.21771-5-zengxiao@eswincomputing.com> From: Jeff Law In-Reply-To: <20230719101156.21771-5-zengxiao@eswincomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/19/23 04:11, Xiao Zeng wrote: > This patch completes the recognition of Zicond when the select pattern with > condition eq or neq to non-zero (using equality as an example), namely: > > 1 rd = (rs2 == non-imm) ? 0 : rs1 > 2 rd = (rs2 == reg) ? 0 : rs1 > > At the same time, more Zicond non basic semantic test cases have been added. > > gcc/ChangeLog: > > * config/riscv/riscv.cc (riscv_expand_conditional_move): Recognize Zicond. I think this is handled by the changes from Raphael I just committed. But I do think we should take the testsuite work to verify the cases all work as expected. Given the testcases from 3/5 are also on hold pending fixing the costing issues, I'm thinking to roll all the testsuite changes into a distinct patch, with the failing tests xfailed until we fix the costing work. But I definitely don't want to lose the tests. jeff