From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53406 invoked by alias); 30 Jul 2019 15:33:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 53398 invoked by uid 89); 30 Jul 2019 15:33:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=H*Ad:U*bergner, H*MI:a0cd X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Jul 2019 15:33:54 +0000 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6UFWMNU059770 for ; Tue, 30 Jul 2019 11:33:53 -0400 Received: from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201]) by mx0a-001b2d01.pphosted.com with ESMTP id 2u2pdqefd8-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 30 Jul 2019 11:33:52 -0400 Received: from localhost by e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 30 Jul 2019 16:33:51 +0100 Received: from b01cxnp23032.gho.pok.ibm.com (9.57.198.27) by e11.ny.us.ibm.com (146.89.104.198) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 30 Jul 2019 16:33:48 +0100 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6UFXlrB10813842 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Jul 2019 15:33:47 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 69563B2066; Tue, 30 Jul 2019 15:33:47 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 060FBB2064; Tue, 30 Jul 2019 15:33:47 +0000 (GMT) Received: from otta.local (unknown [9.85.186.128]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 30 Jul 2019 15:33:46 +0000 (GMT) Subject: Re: [PATCH, rs6000] Fix PR91050 by adding a DRIVER_SELF_SPECS spec To: Uros Bizjak Cc: Jan Hubicka , Iain Sandoe , GCC Patches , Segher Boessenkool References: <39ef9829-c6c2-0ed5-cfaa-3c999af898bb@linux.ibm.com> <307d5b0a-1da9-f241-ab91-e55c687d2863@linux.ibm.com> From: Peter Bergner Date: Tue, 30 Jul 2019 16:19:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit x-cbid: 19073015-2213-0000-0000-000003B7AE94 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00011523; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000287; SDB=6.01239647; UDB=6.00653634; IPR=6.01021060; MB=3.00027958; MTD=3.00000008; XFM=3.00000015; UTC=2019-07-30 15:33:50 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19073015-2214-0000-0000-00005F7354B1 Message-Id: <6c72d135-a0cd-edec-2eac-f5aa17629b66@linux.ibm.com> X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg01823.txt.bz2 On 7/30/19 7:52 AM, Uros Bizjak wrote: > On Thu, Jul 25, 2019 at 7:34 PM Peter Bergner wrote: >>> +#define DRIVER_SELF_SPECS SUBTARGET_DRIVER_SELF_SPECS >>> + >>> +#ifndef SUBTARGET_DRIVER_SELF_SPECS >>> +# define SUBTARGET_DRIVER_SELF_SPECS >>> +#endif > > Shouldn't we swap these two defines, so we always get SUBTARGET_D_S_S > defined first? Like: > > #ifndef SUBTARGET_DRIVER_SELF_SPECS > # define SUBTARGET_DRIVER_SELF_SPECS "" > #endif > > #define DRIVER_SELF_SPECS SUBTARGET_DRIVER_SELF_SPECS That's the way I would have coded it myself, but when I looked at the other arches handling of spec defines, they all seemed to code it this way. Consider it swapped. Peter