From: "Martin Liška" <mliska@suse.cz>
To: Gerald Pfeifer <gerald@pfeifer.com>
Cc: gcc-patches@gcc.gnu.org, Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH] docs: document sanitizers can trigger warnings
Date: Mon, 7 Nov 2022 09:55:09 +0100 [thread overview]
Message-ID: <6d355e35-bc48-d76d-6576-6570937c91f1@suse.cz> (raw)
In-Reply-To: <02229763-c665-5295-89d1-48c4d47c54ca@pfeifer.com>
On 11/3/22 13:32, Gerald Pfeifer wrote:
> Hi Martin,
>
> On Wed, 26 Oct 2022, Martin Liška wrote:
>> +Note the enabled sanitizer options tend to increase a false-positive rate
>> +of selected warnings, most notably @option{-Wmaybe-uninitialized}.
>> +And thus we recommend to disable @option{-Werror}.
>
> I've been sitting muling over this and here is what I'm wondering might
> be a possible alternative?
>
> Note that sanitzers tend to increase the rate of false positive
> warnings, most notably those around @option{-Wmaybe-uninitialized}.
> We recommend against combining @option{-Werror} and [the use of]
> sanitzers.
>
>
> Rationale for the second sentence: Disabling a warning that is off by
> default confused my mental model (and maybe those of other readers). :-)
>
> What do you think?
I welcome it and I've pushed pushed your version.
Thanks,
Martin
>
> Gerald
prev parent reply other threads:[~2022-11-07 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 11:09 Martin Liška
2022-10-27 22:52 ` Jeff Law
2022-10-28 18:45 ` Eric Gallager
2022-11-03 12:32 ` Gerald Pfeifer
2022-11-07 8:55 ` Martin Liška [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d355e35-bc48-d76d-6576-6570937c91f1@suse.cz \
--to=mliska@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=gerald@pfeifer.com \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).