From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mliska@suse.cz>
Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c])
	by sourceware.org (Postfix) with ESMTPS id E120C3858C36
	for <gcc-patches@gcc.gnu.org>; Mon,  7 Nov 2022 08:55:10 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E120C3858C36
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz
Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by smtp-out1.suse.de (Postfix) with ESMTPS id 9FCAB223E3;
	Mon,  7 Nov 2022 08:55:09 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa;
	t=1667811309; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4u/34fL5Dfl7MgqP8K6R3Yp3PDxblowNgUZA2zAc8vU=;
	b=xaSuhLcxnTSASvU069amwUBu+8tce2JT622EXUYMoVaDlvZqi5BMIgLiWUnMOKOvrgGhO6
	ML02hsBmfgJnceyXsyQZW6MXfa05d3CY2QQPYl7iqCa6eI2udiuTrNYgUbzEZFv18z4t2Y
	sSzAaD3PG+VhAu6zXHNPaY/IdRi5ui4=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;
	s=susede2_ed25519; t=1667811309;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=4u/34fL5Dfl7MgqP8K6R3Yp3PDxblowNgUZA2zAc8vU=;
	b=rPMsXiVE12h0bAq/vkpk6HMsl8KG8EwzzeZRjriA/dGenbU/ejpRlXQlwH0d9MchzoMQBX
	TgLzm4xeWnkt1/DA==
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 87D6413494;
	Mon,  7 Nov 2022 08:55:09 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
	by imap2.suse-dmz.suse.de with ESMTPSA
	id QrYvIO3HaGPsOQAAMHmgww
	(envelope-from <mliska@suse.cz>); Mon, 07 Nov 2022 08:55:09 +0000
Message-ID: <6d355e35-bc48-d76d-6576-6570937c91f1@suse.cz>
Date: Mon, 7 Nov 2022 09:55:09 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH] docs: document sanitizers can trigger warnings
Content-Language: en-US
To: Gerald Pfeifer <gerald@pfeifer.com>
Cc: gcc-patches@gcc.gnu.org, Jakub Jelinek <jakub@redhat.com>
References: <9321d38e-a185-5505-62a5-574d64446798@suse.cz>
 <02229763-c665-5295-89d1-48c4d47c54ca@pfeifer.com>
From: =?UTF-8?Q?Martin_Li=c5=a1ka?= <mliska@suse.cz>
In-Reply-To: <02229763-c665-5295-89d1-48c4d47c54ca@pfeifer.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On 11/3/22 13:32, Gerald Pfeifer wrote:
> Hi Martin,
> 
> On Wed, 26 Oct 2022, Martin Liška wrote:
>> +Note the enabled sanitizer options tend to increase a false-positive rate
>> +of selected warnings, most notably @option{-Wmaybe-uninitialized}.
>> +And thus we recommend to disable @option{-Werror}.
> 
> I've been sitting muling over this and here is what I'm wondering might
> be a possible alternative?
> 
>   Note that sanitzers tend to increase the rate of false positive
>   warnings, most notably those around @option{-Wmaybe-uninitialized}.
>   We recommend against combining @option{-Werror} and [the use of] 
>   sanitzers.
> 
> 
> Rationale for the second sentence: Disabling a warning that is off by 
> default confused my mental model (and maybe those of other readers). :-)
> 
> What do you think?

I welcome it and I've pushed pushed your version.

Thanks,
Martin

> 
> Gerald