From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35809 invoked by alias); 13 Jul 2016 21:36:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 35586 invoked by uid 89); 13 Jul 2016 21:36:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=ensuring, Hx-languages-length:962, contrib X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 Jul 2016 21:36:36 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1361D55395; Wed, 13 Jul 2016 21:36:35 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-70.phx2.redhat.com [10.3.116.70]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6DLaYRr017226; Wed, 13 Jul 2016 17:36:34 -0400 Subject: Re: [PATCH, contrib] download_prerequisites: check for existing symlinks before making new ones To: Eric Gallager , gcc-patches@gcc.gnu.org References: From: Jeff Law Message-ID: <6d8cc2be-c68d-81f9-2274-6a12628b8caa@redhat.com> Date: Wed, 13 Jul 2016 21:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00775.txt.bz2 On 06/27/2016 08:10 PM, Eric Gallager wrote: > The last time I ran ./contrib/download_prerequisites, I already had > previous symlinks set up from a previous run of the script, so `ln` > followed the existing symlinks and created the new ones in the > directories to which the symlinks pointed. This patch should fix that > by removing the old symlinks before creating new ones. (For some > reason the `-f` flag to `ln` that was already there wasn't enough for > me.) Tested by running the script and ensuring that the new isl > symlink pointed to the correct directory, and that there were no bad > symlinks in the old isl directory. Could someone commit this trivial > patch for me, or something like it? I don't have write access. I'd really rather know why the "-f" flag didn't work for you. The whole point of -f is to remove the destination file first. Jeff