From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id E10EA3858D20 for ; Fri, 11 Nov 2022 00:01:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E10EA3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.96,155,1665475200"; d="scan'208";a="86477799" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 10 Nov 2022 16:01:37 -0800 IronPort-SDR: Zrg/IG4EHxzKFmYTuyFXJYE5D/pOsibx0/42I6kesnd4N4ct0FCCcSvU8RkPDSSGj/GKGJadFq AgcgdBRfDp3aRWmtDBLaRkxTvavmEBORZrZf9Ba9kuQXDcfUVVzrRcrrXtjkqRLDuGingKIpPV 5lvCa9Mj4NNMvLLUybzmtgt99L4UZyHpii8CYKiNt8Dfdi9h5ILpfOhi7bgLs9xgUEhPNUVfJI 4+j65dWJFNqVmu9G0l5BV1Tc9+I2iKeFnGZqcT9AQX3GdUbUPirWTuLjACayRs0sH6d+Du0IUa 4mE= Date: Fri, 11 Nov 2022 00:01:32 +0000 From: Joseph Myers To: Jonathan Wakely CC: Subject: Re: [PATCH] c-family: Support #pragma region/endregion [PR85487] In-Reply-To: <20221110031345.193991-1-jwakely@redhat.com> Message-ID: <6d96c99-db95-6f33-a0e-7c662ce05a78@codesourcery.com> References: <20221110031345.193991-1-jwakely@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-13.mgc.mentorg.com (139.181.222.13) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3110.1 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 10 Nov 2022, Jonathan Wakely via Gcc-patches wrote: > Something similar has been proposed before, but didn't get approval. > Jeff wanted a more general framework for ignoring pragmas. It might make > sense to do that, and reuse it for the Darwin-specific 'mark' pragmas. > But as I said in the PR, I looked at the darwin ones and they are unique > among all pragmas in GCC. I am not going there, sorry :-) > > In the PR it was suggested that we should check for syntax errors in > these pragmas or make sure there are matching region/endregion pairs. > I disagree. This is a simple, low-risk patch that removes unhelpful > warnings for users who have these macros for their editor to process. > It's not our business to check for correct use of these macros, their > meaning is determined by other tools that we don't control. We should > just not complain when we see them, and no more. > > Tested powerpc64le-linux. OK for trunk? OK. -- Joseph S. Myers joseph@codesourcery.com