From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8522 invoked by alias); 27 Nov 2017 16:43:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 8439 invoked by uid 89); 27 Nov 2017 16:43:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=1768 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Nov 2017 16:43:15 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5D0C94E4C1; Mon, 27 Nov 2017 16:43:11 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-12.rdu2.redhat.com [10.10.112.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9AEA05D972; Mon, 27 Nov 2017 16:43:10 +0000 (UTC) Subject: Re: [RFA][PATCH] Use SCEV conditionally within vr-values and evrp range analysis - V2 To: Richard Biener Cc: gcc-patches References: <80038401-a229-aba2-712d-1082aaa39b65@redhat.com> From: Jeff Law Message-ID: <6d9e93c4-25ae-10ce-5e8c-3e28d61b9777@redhat.com> Date: Mon, 27 Nov 2017 16:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------45857313777CB61FC87265BB" X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg02311.txt.bz2 This is a multi-part message in MIME format. --------------45857313777CB61FC87265BB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 985 On 11/23/2017 05:49 AM, Richard Biener wrote: > On Thu, Nov 23, 2017 at 1:16 AM, Jeff Law wrote: >> >> Clients of the evrp range analysis may not have initialized the SCEV >> infrastructure, and in fact my not want to (DOM for example). >> >> Yet inside both vr-values.c and gimple-ssa-evrp-analyze.c we have calls >> into SCEV (that will fault/abort if SCEV is not properly initialized). >> >> This patch allows clients of vr-values.c and gimple-ssa-evrp-analyze.c >> to indicate if they want SCEV analysis. >> >> Bootstrapped and regression tested by itself as well as with the DOM >> patches to use EVRP analysis (which test the "don't want SCEV path). >> >> OK for the trunk? > > There's also scev_initialized_p () which you could conveniently use. Yea, that worked fine and is (of course) much simpler. Bootstrapped and regression tested in isolation as well as on top of my ongoing work to remove jump threading from tree-vrp.c. OK for the trunk now? Jeff --------------45857313777CB61FC87265BB Content-Type: text/plain; charset=UTF-8; name="P" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="P" Content-length: 1863 CSogZ2ltcGxlLXNzYS1ldnJwLWFuYWx5emUuYwoJKGV2cnBfcmFuZ2VfYW5h bHl6ZXI6OnJlY29yZF9yYW5nZXNfZnJvbV9waGlzKTogT25seSB1c2UgU0NF ViB0bwoJcmVmaW5lIHJhbmdlcyBpZiBzY2V2X2luaXRpYWxpemVkX3AgcmV0 dXJucyB0cnVlLgoJKiB2ci12YWx1ZXMuYyAodnJfdmFsdWVzOjpleHRyYWN0 X3JhbmdlX2Zyb21fcGhpX25vZGUpOiBMaWtld2lzZS4KCmRpZmYgLS1naXQg YS9nY2MvZ2ltcGxlLXNzYS1ldnJwLWFuYWx5emUuYyBiL2djYy9naW1wbGUt c3NhLWV2cnAtYW5hbHl6ZS5jCmluZGV4IDY4YTJjZGMuLjM4ZmIwZGIgMTAw NjQ0Ci0tLSBhL2djYy9naW1wbGUtc3NhLWV2cnAtYW5hbHl6ZS5jCisrKyBi L2djYy9naW1wbGUtc3NhLWV2cnAtYW5hbHl6ZS5jCkBAIC0xNzYsNyArMTc2 LDggQEAgZXZycF9yYW5nZV9hbmFseXplcjo6cmVjb3JkX3Jhbmdlc19mcm9t X3BoaXMgKGJhc2ljX2Jsb2NrIGJiKQogCSAgICAgdG8gdXNlIFZBUllJTkcg Zm9yIHRoZW0uICBCdXQgd2UgY2FuIHN0aWxsIHJlc29ydCB0bwogCSAgICAg U0NFViBmb3IgbG9vcCBoZWFkZXIgUEhJcy4gICovCiAJICBzdHJ1Y3QgbG9v cCAqbDsKLQkgIGlmIChpbnRlcmVzdGluZworCSAgaWYgKHNjZXZfaW5pdGlh bGl6ZWRfcCAoKQorCSAgICAgICYmIGludGVyZXN0aW5nCiAJICAgICAgJiYg KGwgPSBsb29wX2NvbnRhaW5pbmdfc3RtdCAocGhpKSkKIAkgICAgICAmJiBs LT5oZWFkZXIgPT0gZ2ltcGxlX2JiIChwaGkpKQogCSAgdnJfdmFsdWVzLmFk anVzdF9yYW5nZV93aXRoX3NjZXYgKCZ2cl9yZXN1bHQsIGwsIHBoaSwgbGhz KTsKZGlmZiAtLWdpdCBhL2djYy92ci12YWx1ZXMuYyBiL2djYy92ci12YWx1 ZXMuYwppbmRleCAyZDExODYxLi5lNjE3NTU2IDEwMDY0NAotLS0gYS9nY2Mv dnItdmFsdWVzLmMKKysrIGIvZ2NjL3ZyLXZhbHVlcy5jCkBAIC0yOTM1LDcg KzI5MzUsOCBAQCBzY2V2X2NoZWNrOgogICAgICBzY2V2X2NoZWNrIGNhbiBi ZSByZWFjaGVkIGZyb20gdHdvIHBhdGhzLCBvbmUgaXMgYSBmYWxsIHRocm91 Z2ggZnJvbSBhYm92ZQogICAgICAidmFyeWluZyIgbGFiZWwsIHRoZSBvdGhl ciBpcyBkaXJlY3QgZ290byBmcm9tIGNvZGUgYmxvY2sgd2hpY2ggdHJpZXMg dG8KICAgICAgYXZvaWQgaW5maW5pdGUgc2ltdWxhdGlvbi4gICovCi0gIGlm ICgobCA9IGxvb3BfY29udGFpbmluZ19zdG10IChwaGkpKQorICBpZiAoc2Nl dl9pbml0aWFsaXplZF9wICgpCisgICAgICAmJiAobCA9IGxvb3BfY29udGFp bmluZ19zdG10IChwaGkpKQogICAgICAgJiYgbC0+aGVhZGVyID09IGdpbXBs ZV9iYiAocGhpKSkKICAgICBhZGp1c3RfcmFuZ2Vfd2l0aF9zY2V2ICh2cl9y ZXN1bHQsIGwsIHBoaSwgbGhzKTsKIAo= --------------45857313777CB61FC87265BB--