public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Stubbs <ams@codesourcery.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [committed] openmp: Add support for HBW or large capacity or interleaved memory through the libmemkind.so library
Date: Wed, 29 Jun 2022 13:24:23 +0100	[thread overview]
Message-ID: <6dade46f-826a-8520-6abb-5635ec8f2262@codesourcery.com> (raw)
In-Reply-To: <YrwtTzUF88tVmEtI@tucnak>

On 29/06/2022 11:45, Jakub Jelinek wrote:
> And omp_init_allocator needs to decide what to do if one asks for features
> that need memkind as well as for features that need whatever you/Abid have
> been working on.  A possible resolution is punt (return omp_null_allocator),
> or prefer one feature over the other one or vice versa.
>  From the features currently handled by memkind, even before my changes for
> consistency with libomp from llvm omp_high_bw_mem_space was considered a
> hard request, ditto omp_atk_pinned omp_atv_true, but the rest was just taken
> as optimization hint.

Right now I'm rebasing our patches so that they build and pass our tests 
again.

I don't know what to do if someone requests pinned high-bandwidth 
memory. I don't even know if that's a thing that can exist. Right now, 
as I have my dev branch, the high-bandwidth will take precedence simply 
because memkind is checked first. I presume that if memkind ever grew 
the ability to allocate pinned memory you would still have the choose 
one "kind" or the other.

Andrew

      reply	other threads:[~2022-06-29 12:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09  8:19 Jakub Jelinek
2022-06-09 10:11 ` Thomas Schwinge
2022-06-09 11:57   ` Jakub Jelinek
2022-06-10 19:23     ` Jakub Jelinek
2022-06-09 17:07 ` Richard Sandiford
2022-06-09 17:48   ` Jakub Jelinek
2022-06-28 21:29 ` Andrew Stubbs
2022-06-29 10:45   ` Jakub Jelinek
2022-06-29 12:24     ` Andrew Stubbs [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6dade46f-826a-8520-6abb-5635ec8f2262@codesourcery.com \
    --to=ams@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).