From: Jeff Law <law@redhat.com>
To: Aldy Hernandez <aldyh@redhat.com>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: VRP: abstract out MIN/MAX/ABS wide int code
Date: Mon, 20 Aug 2018 22:40:00 -0000 [thread overview]
Message-ID: <6dae90ae-5c60-4ab0-4e87-898dad100d17@redhat.com> (raw)
In-Reply-To: <3aa38fec-82aa-614e-4ef0-61f2dbf2eefa@redhat.com>
On 08/17/2018 01:11 AM, Aldy Hernandez wrote:
> No change in functionality, just a straight up conversion.
>
> OK for trunk?
>
> curr.patch
>
>
> gcc/
>
> * wide-int-range.cc (wide_int_range_abs): New.
> (wide_int_range_order_set): Rename from wide_int_range_min_max.
> * wide-int-range.h (wide_int_range_abs): New.
> (wide_int_range_min_max): New.
> * tree-vrp.c (extract_range_from_unary_expr): Rewrite ABS_EXPR
> case to call wide_int_range_abs.
> Rewrite MIN/MAX_EXPR to call wide_int_range_min_max.
> (extract_range_from_abs_expr): Delete.
OK. It was a bit hard to follow because parts of the original
implementation were split and handled in different places. But AFAICT
it looks like everything got transferred to their new locations.
jeff
next prev parent reply other threads:[~2018-08-20 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 7:11 Aldy Hernandez
2018-08-20 22:40 ` Jeff Law [this message]
2018-08-21 6:23 ` Aldy Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dae90ae-5c60-4ab0-4e87-898dad100d17@redhat.com \
--to=law@redhat.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).