From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32496 invoked by alias); 17 Mar 2008 13:55:34 -0000 Received: (qmail 32483 invoked by uid 22791); 17 Mar 2008 13:55:31 -0000 X-Spam-Check-By: sourceware.org Received: from ug-out-1314.google.com (HELO ug-out-1314.google.com) (66.249.92.170) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Mar 2008 13:55:01 +0000 Received: by ug-out-1314.google.com with SMTP id o38so805562ugd.17 for ; Mon, 17 Mar 2008 06:54:55 -0700 (PDT) Received: by 10.78.138.14 with SMTP id l14mr42666942hud.20.1205762094275; Mon, 17 Mar 2008 06:54:54 -0700 (PDT) Received: by 10.78.163.20 with HTTP; Mon, 17 Mar 2008 06:54:54 -0700 (PDT) Message-ID: <6dc9ffc80803170654jf8469c7r5cad742e21f1d816@mail.gmail.com> Date: Mon, 17 Mar 2008 14:32:00 -0000 From: "H.J. Lu" To: "Peter Bergner" Subject: Re: [PING H.J. Lu] Re: [PATCH] PR35371 GCSE loses track of REG_POINTER attribute Cc: "Richard Sandiford" , gcc-patches , "Jeff Law" In-Reply-To: <20080312144656.GA4941@lucon.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_7648_30105369.1205762094274" References: <20080225222624.GA26857@vervain.rchland.ibm.com> <87skzfzkvh.fsf@firetop.home> <1204052325.7014.2.camel@otta> <47C467BA.1090308@redhat.com> <1204240130.7376.16.camel@otta> <1205163133.6782.57.camel@otta> <20080312144656.GA4941@lucon.org> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-03/txt/msg01014.txt.bz2 ------=_Part_7648_30105369.1205762094274 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 1264 Hi Peter, I removed copyright update in your original patch and applied it on gcc 4.4 at revision 133082. I didn't noticed any serious performance regressions with SPEC CPU 2000/2006. Thanks. H.J. On Wed, Mar 12, 2008 at 7:46 AM, H.J. Lu wrote: > > On Mon, Mar 10, 2008 at 10:32:13AM -0500, Peter Bergner wrote: > > On Thu, 2008-02-28 at 17:08 -0600, Peter Bergner wrote: > > > HJ, > > > > > > Given the x86/x86_64 issues with the last indexed load/store patch, > > > can you SPEC test this patch to make sure the rtlanal.c change doesn't > > > affect you? Thanks. > > > > HJ, > > > > If you get a chance, can you please SPEC test the patch located in: > > > > http://gcc.gnu.org/ml/gcc-patches/2008-02/msg01442.html > > > > just to make sure it doesn't have a negative impact on x86/x86_64? > > Thanks. > > Hi Peter, > > I can use gcc to compile SPEC CPU now. But your patch won't apply > > patching file rtlanal.c > patching file gcse.c > Hunk #2 succeeded at 4463 (offset 7 lines). > Hunk #4 succeeded at 6120 (offset 7 lines). > patching file emit-rtl.c > Reversed (or previously applied) patch detected! Assume -R? [n] > > against revision 133140. Do you have an updated patch? > > Thanks. > > H.J. > ------=_Part_7648_30105369.1205762094274 Content-Type: text/x-patch; name=gcc-pr35371-2.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_fdx3jg640 Content-Disposition: attachment; filename=gcc-pr35371-2.patch Content-length: 8736 T24gVHVlLCAyMDA4LTAyLTI2IGF0IDEyOjI1IC0wNzAwLCBKZWZmIExhdyB3 cm90ZToKPiBJZiBzb21lb25lIHdhbnRlZCB0byBnZXQgcmVhbCBhbWJpdGlv dXMgdGhleSBjb3VsZCByZXZhbXAgdGhlCj4gUkVHX1BPSU5URVIgcHJvcGFn YXRpb24gY29kZSBhcyB3ZWxsLiAgSXQncyBhbWF6aW5nbHkgc2ltcGxpc3Rp Ywo+IGF0IHRoZSBtb21lbnQgKHNlZSByZWdjbGFzcy5jOnJlZ19zY2FuX21h cmtfcmVmcykuICBCYXNpY2FsbHkgaXQKPiBmYWlscyB0byBwcm9wYWdhdGUg Zm9yIGFueSByZWdpc3RlciBkZXN0aW5hdGlvbiB0aGF0IGlzIHNldCBtb3Jl Cj4gdGhhbiBvbmNlLCBldmVuIGlmIGFsbCB0aGUgc2V0cyBhcmUgb2YgdGhl IHByb3BlciBmb3JtIGZvcgo+IHByb3BhZ2F0aW5nIFJFR19QT0lOVEVSLgoK RG8geW91IG1lYW4gZml4IGl0IHVwIGFuZCB0aGVuIGNhbGwgaXQgZnJvbSBt b3JlIHRoYW4ganVzdCBDU0U/CkN1cnJlbnRseSwgdGhlIG9ubHkgY2FsbCB0 byByZWdfc2NhbigpIGlzbid0IGluIGEgbG9jYXRpb24gdGhhdAp3aWxsIGhl bHAgbWUuCgpBbnl3YXksIEkgdG9vayBSaWNoYXJkJ3MgYWR2aWNlIGFuZCBt b3ZlZC9yZW5hbWVkIHRoZSBuZXcgZnVuY3Rpb24KdG8gZW1pdC1ydGwuYy4g IEhvdyBkb2VzIHRoZSBuZXcgY29kZSBsb29rPyAgRm9yIC1PMSBjb21waWxl cywgSSBoYWQKdG8gcHJvcGVybHkgb3JkZXIgdGhlIGluZGV4ZWQgbG9hZC9z dG9yZSBvcGVyYW5kcyBkdXJpbmcgZXhwYW5kLCBiZWNhdXNlCndlIG5ldmVy IGF0dGVtcHQgdG8gZml4IHRoZW0gdXAgYWZ0ZXIgdGhhdCAoYWN0dWFsbHks IERTRSBzZWVtcyB0byBjYWxsCnNpbXBsaWZ5LCBhbmQgc3dhcF9jb21tdXRh dGl2ZV9vcGVyYW5kc19wKCkgY29ycmVjdGx5IHNheXMgd2Ugc2hvdWxkCnN3 YXAgdGhlIG9wZXJhbmRzLCBidXQgZm9yIHNvbWUgcmVhc29uIEkgZG9uJ3Qg dW5kZXJzdGFuZCB5ZXQsIERTRQpzZWVtcyB0byBqdXN0IHRocm93IGF3YXkg dGhhdCByZXN1bHQpLgoKCkhKLAoKR2l2ZW4gdGhlIHg4Ni94ODZfNjQgaXNz dWVzIHdpdGggdGhlIGxhc3QgaW5kZXhlZCBsb2FkL3N0b3JlIHBhdGNoLApj YW4geW91IFNQRUMgdGVzdCB0aGlzIHBhdGNoIHRvIG1ha2Ugc3VyZSB0aGUg cnRsYW5hbC5jIGNoYW5nZSBkb2Vzbid0CmFmZmVjdCB5b3U/ICBUaGFua3Mu CgoKUGV0ZXIKCgoKCi0tPS1QSUlWQ3hmVmVxZGN6dWFoK2svSQpDb250ZW50 LURpc3Bvc2l0aW9uOiBhdHRhY2htZW50OyBmaWxlbmFtZT1QUjM1MzcxLTMu ZGlmZgpDb250ZW50LVR5cGU6IHRleHQveC1wYXRjaDsgbmFtZT1QUjM1Mzcx LTMuZGlmZjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29k aW5nOiA3Yml0CgoJUFIgcnRsLW9wdGltaXphdGlvbi8zNTM3MQoJKiBydGxh bmFsLmM6IFVwZGF0ZSBjb3B5cmlnaHQgeWVhci4KCShjb21tdXRhdGl2ZV9v cGVyYW5kX3ByZWNlZGVuY2UpOiBHaXZlIFNZTUJPTF9SRUYncyB0aGUgc2Ft ZQoJcHJlY2VkZW5jZSBhcyBSRUdfUE9JTlRFUidzIGFuZCBNRU1fUE9JTlRF UidzLgoJKiBlbWl0LXJ0bC5jOiBVcGRhdGUgY29weXJpZ2h0IHllYXIuCgko c2V0X3JlZ19hdHRyc19mcm9tX3ZhbHVlKTogQ29weSB0aGUgUkVHX1BPSU5U RVIvTUVNX1BPSU5URVIKCWF0dHJpYnV0ZSBvdmVyIHRvIHRoZSBuZXcgcmVn IHJ0eC4KCShnZW5fcmVnX3J0eF9jb3B5KTogTmV3IGZ1bmN0aW9uLgoJKiBn Y3NlLmM6IFVwZGF0ZSBjb3B5cmlnaHQgeWVhci4KCShwcmVfZGVsZXRlKTog Q2FsbCBnZW5fcmVnX3J0eF9jb3B5IHJhdGhlciB0aGFuIGdlbl9yZWdfcnR4 LgoJKGhvaXN0X2NvZGUpOiBMaWtld2lzZS4KCShidWlsZF9zdG9yZV92ZWN0 b3JzKTogTGlrZXdpc2UuCgkoZGVsZXRlX3N0b3JlKTogTGlrZXdpc2UuCgkq IGxvb3AtaW52YXJpYW50LmM6IFVwZGF0ZSBjb3B5cmlnaHQgeWVhci4KCSht b3ZlX2ludmFyaWFudF9yZWcpOiBDYWxsIGdlbl9yZWdfcnR4X2NvcHkgcmF0 aGVyIHRoYW4gZ2VuX3JlZ19ydHguCgkqIHJ0bC5oOiBVcGRhdGUgY29weXJp Z2h0IHllYXIuCgkoZ2VuX3JlZ19ydHhfY29weSk6IEFkZCBwcm90b3R5cGUu CgpJbmRleDogcnRsYW5hbC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IHJ0bGFuYWwuYwkocmV2aXNpb24gMTMyNTY4KQorKysgcnRsYW5hbC5jCSh3 b3JraW5nIGNvcHkpCkBAIC0yODk4LDYgKzI4OTgsOCBAQCBjb21tdXRhdGl2 ZV9vcGVyYW5kX3ByZWNlZGVuY2UgKHJ0eCBvcCkKICAgc3dpdGNoIChHRVRf UlRYX0NMQVNTIChjb2RlKSkKICAgICB7CiAgICAgY2FzZSBSVFhfQ09OU1Rf T0JKOgorICAgICAgaWYgKGNvZGUgPT0gU1lNQk9MX1JFRikKKwlyZXR1cm4g LTE7CiAgICAgICBpZiAoY29kZSA9PSBDT05TVF9JTlQpCiAgICAgICAgIHJl dHVybiAtNjsKICAgICAgIGlmIChjb2RlID09IENPTlNUX0RPVUJMRSkKSW5k ZXg6IGdjc2UuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBnY3NlLmMJ KHJldmlzaW9uIDEzMjU2OCkKKysrIGdjc2UuYwkod29ya2luZyBjb3B5KQpA QCAtNDQ1Niw4ICs0NDU2LDcgQEAgcHJlX2RlbGV0ZSAodm9pZCkKIAkJICAg ZXhwcmVzc2lvbnMgaW50by4gIEdldCB0aGUgbW9kZSBmb3IgdGhlIG5ldyBw c2V1ZG8gZnJvbQogCQkgICB0aGUgbW9kZSBvZiB0aGUgb3JpZ2luYWwgZGVz dGluYXRpb24gcHNldWRvLiAgKi8KIAkJaWYgKGV4cHItPnJlYWNoaW5nX3Jl ZyA9PSBOVUxMKQotCQkgIGV4cHItPnJlYWNoaW5nX3JlZwotCQkgICAgPSBn ZW5fcmVnX3J0eCAoR0VUX01PREUgKFNFVF9ERVNUIChzZXQpKSk7CisJCSAg ZXhwci0+cmVhY2hpbmdfcmVnID0gZ2VuX3JlZ19ydHhfY29weSAoU0VUX0RF U1QgKHNldCkpOwogCiAJCWdjc2VfZW1pdF9tb3ZlX2FmdGVyIChleHByLT5y ZWFjaGluZ19yZWcsIFNFVF9ERVNUIChzZXQpLCBpbnNuKTsKIAkJZGVsZXRl X2luc24gKGluc24pOwpAQCAtNDk4MSw3ICs0OTgwLDcgQEAgaG9pc3RfY29k ZSAodm9pZCkKIAkJCSBmcm9tIHRoZSBtb2RlIG9mIHRoZSBvcmlnaW5hbCBk ZXN0aW5hdGlvbiBwc2V1ZG8uICAqLwogCQkgICAgICBpZiAoZXhwci0+cmVh Y2hpbmdfcmVnID09IE5VTEwpCiAJCQlleHByLT5yZWFjaGluZ19yZWcKLQkJ CSAgPSBnZW5fcmVnX3J0eCAoR0VUX01PREUgKFNFVF9ERVNUIChzZXQpKSk7 CisJCQkgID0gZ2VuX3JlZ19ydHhfY29weSAoU0VUX0RFU1QgKHNldCkpOwog CiAJCSAgICAgIGdjc2VfZW1pdF9tb3ZlX2FmdGVyIChleHByLT5yZWFjaGlu Z19yZWcsIFNFVF9ERVNUIChzZXQpLCBpbnNuKTsKIAkJICAgICAgZGVsZXRl X2luc24gKGluc24pOwpAQCAtNjExNCw3ICs2MTEzLDcgQEAgYnVpbGRfc3Rv cmVfdmVjdG9ycyAodm9pZCkKIAkgICAgIGFyZSBhbnkgc2lkZSBlZmZlY3Rz LiAgKi8KIAkgIGlmIChURVNUX0JJVCAoYWVfZ2VuW2JiLT5pbmRleF0sIHB0 ci0+aW5kZXgpKQogCSAgICB7Ci0JICAgICAgcnR4IHIgPSBnZW5fcmVnX3J0 eCAoR0VUX01PREUgKHB0ci0+cGF0dGVybikpOworCSAgICAgIHJ0eCByID0g Z2VuX3JlZ19ydHhfY29weSAocHRyLT5wYXR0ZXJuKTsKIAkgICAgICBpZiAo ZHVtcF9maWxlKQogCQlmcHJpbnRmIChkdW1wX2ZpbGUsICJSZW1vdmluZyBy ZWR1bmRhbnQgc3RvcmU6XG4iKTsKIAkgICAgICByZXBsYWNlX3N0b3JlX2lu c24gKHIsIFhFWFAgKHN0LCAwKSwgYmIsIHB0cik7CkBAIC02NDM3LDcgKzY0 MzYsNyBAQCBkZWxldGVfc3RvcmUgKHN0cnVjdCBsc19leHByICogZXhwciwg YmFzCiAgIHJ0eCByZWcsIGksIGRlbDsKIAogICBpZiAoZXhwci0+cmVhY2hp bmdfcmVnID09IE5VTExfUlRYKQotICAgIGV4cHItPnJlYWNoaW5nX3JlZyA9 IGdlbl9yZWdfcnR4IChHRVRfTU9ERSAoZXhwci0+cGF0dGVybikpOworICAg IGV4cHItPnJlYWNoaW5nX3JlZyA9IGdlbl9yZWdfcnR4X2NvcHkgKGV4cHIt PnBhdHRlcm4pOwogCiAgIHJlZyA9IGV4cHItPnJlYWNoaW5nX3JlZzsKIApJ bmRleDogZW1pdC1ydGwuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBl bWl0LXJ0bC5jCShyZXZpc2lvbiAxMzI1NjgpCisrKyBlbWl0LXJ0bC5jCSh3 b3JraW5nIGNvcHkpCkBAIC05NjEsMTEgKzk2MSwzMiBAQCBzZXRfcmVnX2F0 dHJzX2Zyb21fdmFsdWUgKHJ0eCByZWcsIHJ0eCB4CiAgIGludCBvZmZzZXQ7 CiAKICAgb2Zmc2V0ID0gYnl0ZV9sb3dwYXJ0X29mZnNldCAoR0VUX01PREUg KHJlZyksIEdFVF9NT0RFICh4KSk7Ci0gIGlmIChNRU1fUCAoeCkgJiYgTUVN X09GRlNFVCAoeCkgJiYgR0VUX0NPREUgKE1FTV9PRkZTRVQgKHgpKSA9PSBD T05TVF9JTlQpCi0gICAgUkVHX0FUVFJTIChyZWcpCi0gICAgICA9IGdldF9y ZWdfYXR0cnMgKE1FTV9FWFBSICh4KSwgSU5UVkFMIChNRU1fT0ZGU0VUICh4 KSkgKyBvZmZzZXQpOwotICBpZiAoUkVHX1AgKHgpICYmIFJFR19BVFRSUyAo eCkpCi0gICAgdXBkYXRlX3JlZ19vZmZzZXQgKHJlZywgeCwgb2Zmc2V0KTsK KyAgaWYgKE1FTV9QICh4KSkKKyAgICB7CisgICAgICBpZiAoTUVNX09GRlNF VCAoeCkgJiYgR0VUX0NPREUgKE1FTV9PRkZTRVQgKHgpKSA9PSBDT05TVF9J TlQpCisJUkVHX0FUVFJTIChyZWcpCisJICA9IGdldF9yZWdfYXR0cnMgKE1F TV9FWFBSICh4KSwgSU5UVkFMIChNRU1fT0ZGU0VUICh4KSkgKyBvZmZzZXQp OworICAgICAgaWYgKE1FTV9QT0lOVEVSICh4KSkKKwltYXJrX3JlZ19wb2lu dGVyIChyZWcsIE1FTV9BTElHTiAoeCkpOworICAgIH0KKyAgZWxzZSBpZiAo UkVHX1AgKHgpKQorICAgIHsKKyAgICAgIGlmIChSRUdfQVRUUlMgKHgpKQor CXVwZGF0ZV9yZWdfb2Zmc2V0IChyZWcsIHgsIG9mZnNldCk7CisgICAgICBp ZiAoUkVHX1BPSU5URVIgKHgpKQorCW1hcmtfcmVnX3BvaW50ZXIgKHJlZywg UkVHTk9fUE9JTlRFUl9BTElHTiAoUkVHTk8gKHgpKSk7CisgICAgfQorfQor CisvKiBHZW5lcmF0ZSBhIFJFRyBydHggZm9yIGEgbmV3IHBzZXVkbyByZWdp c3RlciwgY29weWluZyB0aGUgbW9kZQorICAgYW5kIGF0dHJpYnV0ZXMgZnJv bSBYLiAgKi8KKworcnR4CitnZW5fcmVnX3J0eF9jb3B5IChydHggeCkKK3sK KyAgcnR4IHJlZyA9IGdlbl9yZWdfcnR4IChHRVRfTU9ERSAoeCkpOworICBz ZXRfcmVnX2F0dHJzX2Zyb21fdmFsdWUgKHJlZywgeCk7CisgIHJldHVybiBy ZWc7CiB9CiAKIC8qIFNldCB0aGUgcmVnaXN0ZXIgYXR0cmlidXRlcyBmb3Ig cmVnaXN0ZXJzIGNvbnRhaW5lZCBpbiBQQVJNX1JUWC4KSW5kZXg6IGxvb3At aW52YXJpYW50LmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbG9vcC1p bnZhcmlhbnQuYwkocmV2aXNpb24gMTMyNTY4KQorKysgbG9vcC1pbnZhcmlh bnQuYwkod29ya2luZyBjb3B5KQpAQCAtMTE5Myw3ICsxMTkzLDcgQEAgbW92 ZV9pbnZhcmlhbnRfcmVnIChzdHJ1Y3QgbG9vcCAqbG9vcCwgdQogCSBuZWVk IHRvIGNyZWF0ZSBhIHRlbXBvcmFyeSByZWdpc3Rlci4gICovCiAgICAgICBz ZXQgPSBzaW5nbGVfc2V0IChpbnYtPmluc24pOwogICAgICAgZGVzdCA9IFNF VF9ERVNUIChzZXQpOwotICAgICAgcmVnID0gZ2VuX3JlZ19ydHggKEdFVF9N T0RFIChkZXN0KSk7CisgICAgICByZWcgPSBnZW5fcmVnX3J0eF9jb3B5IChk ZXN0KTsKIAogICAgICAgLyogVHJ5IHJlcGxhY2luZyB0aGUgZGVzdGluYXRp b24gYnkgYSBuZXcgcHNldWRvcmVnaXN0ZXIuICAqLwogICAgICAgaWYgKCF2 YWxpZGF0ZV9jaGFuZ2UgKGludi0+aW5zbiwgJlNFVF9ERVNUIChzZXQpLCBy ZWcsIGZhbHNlKSkKSW5kZXg6IHJ0bC5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIHJ0bC5oCShyZXZpc2lvbiAxMzI1NjgpCisrKyBydGwuaAkod29y a2luZyBjb3B5KQpAQCAtMTUwOSw2ICsxNTA5LDcgQEAgZXh0ZXJuIHJ0dmVj IGdlbl9ydHZlY192IChpbnQsIHJ0eCAqKTsKIGV4dGVybiBydHggZ2VuX3Jl Z19ydHggKGVudW0gbWFjaGluZV9tb2RlKTsKIGV4dGVybiBydHggZ2VuX3J0 eF9SRUdfb2Zmc2V0IChydHgsIGVudW0gbWFjaGluZV9tb2RlLCB1bnNpZ25l ZCBpbnQsIGludCk7CiBleHRlcm4gcnR4IGdlbl9yZWdfcnR4X29mZnNldCAo cnR4LCBlbnVtIG1hY2hpbmVfbW9kZSwgaW50KTsKK2V4dGVybiBydHggZ2Vu X3JlZ19ydHhfY29weSAocnR4KTsKIGV4dGVybiBydHggZ2VuX2xhYmVsX3J0 eCAodm9pZCk7CiBleHRlcm4gcnR4IGdlbl9sb3dwYXJ0X2NvbW1vbiAoZW51 bSBtYWNoaW5lX21vZGUsIHJ0eCk7CiAKCi0tPS1QSUlWQ3hmVmVxZGN6dWFo K2svSS0tCgo= ------=_Part_7648_30105369.1205762094274--