From: "H.J. Lu" <hjl.tools@gmail.com>
To: "Andrew Pinski" <pinskia@gmail.com>
Cc: "Mark Mitchell" <mark@codesourcery.com>,
"Simon Baldwin" <simonb@google.com>,
gcc-patches@gcc.gnu.org,
"Richard Guenther" <richard.guenther@gmail.com>,
"Dirk Mueller" <dmuell@gmx.net>,
"Joseph S. Myers" <joseph@codesourcery.com>
Subject: Re: [PATCH][RFC] Add a subset of -Warray-bounds warnings to C/C++ front ends
Date: Fri, 02 May 2008 20:01:00 -0000 [thread overview]
Message-ID: <6dc9ffc80805021301u68091843k20334c3ce935d0f1@mail.gmail.com> (raw)
In-Reply-To: <de8d50360805021253w77f132c1m1e8d93a38da7c41e@mail.gmail.com>
On Fri, May 2, 2008 at 12:53 PM, Andrew Pinski <pinskia@gmail.com> wrote:
> On Fri, May 2, 2008 at 9:34 AM, Mark Mitchell <mark@codesourcery.com> wrote:
> > Simon Baldwin wrote:
> >
> >
> > > I think the wisest course for now is to roll back this change until I have
> > a better understanding of the issues.
> > >
> >
> > If you want to roll back, that's fine. You can do that without any further
> > approval.
>
> x86-darwin is also broken with the following warning:
> /home/regress/tbox/svn-gcc/gcc/config/i386/i386.c:20877: error: array
>
> subscript is above array bounds
>
> which is a false warning.
> We have:
> mode0 = insn_data[icode].operand[0].mode;
>
> where insn_data is defined as:
> extern const struct insn_data insn_data[];
>
> operand is a pointer so that is not an issue.
>
May I suggest to revert it now and use a branch to implement it
properly before merging it with trunk? I can prepare a patch in half
an hour.
Thanks.
H.J.
next prev parent reply other threads:[~2008-05-02 20:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-04 1:04 Simon Baldwin
2008-04-04 9:59 ` Richard Guenther
2008-04-04 23:50 ` Simon Baldwin
2008-04-05 0:50 ` Andrew Pinski
2008-04-07 22:51 ` Simon Baldwin
2008-04-08 9:43 ` Richard Guenther
2008-04-08 15:39 ` Dirk Mueller
2008-04-08 15:21 ` Dirk Mueller
2008-04-10 18:05 ` Andrew Pinski
2008-04-08 19:42 ` Mark Mitchell
2008-04-11 20:37 ` Simon Baldwin
2008-04-15 19:18 ` Tom Tromey
2008-04-26 13:42 ` Simon Baldwin
2008-04-27 14:56 ` Mark Mitchell
2008-04-27 15:05 ` Joseph S. Myers
2008-05-01 19:07 ` Simon Baldwin
2008-05-02 12:51 ` H.J. Lu
2008-05-02 12:58 ` H.J. Lu
2008-05-02 14:06 ` Mark Mitchell
2008-05-02 16:04 ` H.J. Lu
2008-05-02 16:21 ` Simon Baldwin
2008-05-02 16:35 ` Mark Mitchell
2008-05-02 19:53 ` Andrew Pinski
2008-05-02 20:01 ` H.J. Lu [this message]
2008-05-02 20:04 ` Simon Baldwin
2008-05-02 20:11 ` H.J. Lu
2008-05-02 16:24 ` Paul Koning
2008-04-08 16:07 ` Dirk Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dc9ffc80805021301u68091843k20334c3ce935d0f1@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=dmuell@gmx.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=mark@codesourcery.com \
--cc=pinskia@gmail.com \
--cc=richard.guenther@gmail.com \
--cc=simonb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).