From: "H.J. Lu" <hjl.tools@gmail.com>
To: Andreas Schwab <schwab@redhat.com>
Cc: gcc-patches@gcc.gnu.org, janis187@us.ibm.com
Subject: PING: PATCH: Also check -m32 for i*86-*-linux*
Date: Tue, 17 Nov 2009 18:48:00 -0000 [thread overview]
Message-ID: <6dc9ffc80911171005h17ddbc7dt3659606837f148a0@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On Thu, Nov 12, 2009 at 8:11 AM, Andreas Schwab <schwab@redhat.com> wrote:
> "H.J. Lu" <hongjiu.lu@intel.com> writes:
>
>> diff --git a/gcc/testsuite/gcc.misc-tests/linkage.exp b/gcc/testsuite/gcc.misc-tests/linkage.exp
>> index 05c0311..768975a 100644
>> --- a/gcc/testsuite/gcc.misc-tests/linkage.exp
>> +++ b/gcc/testsuite/gcc.misc-tests/linkage.exp
>> @@ -57,7 +57,7 @@ if { [isnative] && ![is_remote host] } then {
>> if [ string match "*64-bit*" $file_string ] {
>> set native_cflags "-m64"
>> }
>> - } elseif [istarget "x86_64-*-linux*"] {
>> + } elseif [expr [istarget "i*86-*-linux*"] || [istarget "x86_64-*-linux*"]] {
>
> No need for expr, it's implicit.
>
PING without implicit expr.
Thanks.
--
H.J.
[-- Attachment #2: gcc-m32-3.patch --]
[-- Type: text/x-csrc, Size: 729 bytes --]
2009-11-17 H.J. Lu <hongjiu.lu@intel.com>
* gcc.misc-tests/linkage.exp: Also check -m32 for i*86-*-linux*.
diff --git a/gcc/testsuite/gcc.misc-tests/linkage.exp b/gcc/testsuite/gcc.misc-tests/linkage.exp
index 05c0311..768975a 100644
--- a/gcc/testsuite/gcc.misc-tests/linkage.exp
+++ b/gcc/testsuite/gcc.misc-tests/linkage.exp
@@ -57,7 +57,7 @@ if { [isnative] && ![is_remote host] } then {
if [ string match "*64-bit*" $file_string ] {
set native_cflags "-m64"
}
- } elseif [istarget "x86_64-*-linux*"] {
+ } elseif [[istarget "i*86-*-linux*"] || [istarget "x86_64-*-linux*"]] {
set file_string [exec file "linkage-x.o"]
if [ string match "*32-bit*" $file_string ] {
set native_cflags "-m32"
next reply other threads:[~2009-11-17 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 18:48 H.J. Lu [this message]
2009-11-18 10:29 ` Andreas Schwab
2009-11-18 16:16 ` H.J. Lu
2009-11-18 17:41 ` Janis Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dc9ffc80911171005h17ddbc7dt3659606837f148a0@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=janis187@us.ibm.com \
--cc=schwab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).