* PING: PATCH: Also check -m32 for i*86-*-linux*
@ 2009-11-17 18:48 H.J. Lu
2009-11-18 10:29 ` Andreas Schwab
0 siblings, 1 reply; 4+ messages in thread
From: H.J. Lu @ 2009-11-17 18:48 UTC (permalink / raw)
To: Andreas Schwab; +Cc: gcc-patches, janis187
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On Thu, Nov 12, 2009 at 8:11 AM, Andreas Schwab <schwab@redhat.com> wrote:
> "H.J. Lu" <hongjiu.lu@intel.com> writes:
>
>> diff --git a/gcc/testsuite/gcc.misc-tests/linkage.exp b/gcc/testsuite/gcc.misc-tests/linkage.exp
>> index 05c0311..768975a 100644
>> --- a/gcc/testsuite/gcc.misc-tests/linkage.exp
>> +++ b/gcc/testsuite/gcc.misc-tests/linkage.exp
>> @@ -57,7 +57,7 @@ if { [isnative] && ![is_remote host] } then {
>> if [ string match "*64-bit*" $file_string ] {
>> set native_cflags "-m64"
>> }
>> - } elseif [istarget "x86_64-*-linux*"] {
>> + } elseif [expr [istarget "i*86-*-linux*"] || [istarget "x86_64-*-linux*"]] {
>
> No need for expr, it's implicit.
>
PING without implicit expr.
Thanks.
--
H.J.
[-- Attachment #2: gcc-m32-3.patch --]
[-- Type: text/x-csrc, Size: 729 bytes --]
2009-11-17 H.J. Lu <hongjiu.lu@intel.com>
* gcc.misc-tests/linkage.exp: Also check -m32 for i*86-*-linux*.
diff --git a/gcc/testsuite/gcc.misc-tests/linkage.exp b/gcc/testsuite/gcc.misc-tests/linkage.exp
index 05c0311..768975a 100644
--- a/gcc/testsuite/gcc.misc-tests/linkage.exp
+++ b/gcc/testsuite/gcc.misc-tests/linkage.exp
@@ -57,7 +57,7 @@ if { [isnative] && ![is_remote host] } then {
if [ string match "*64-bit*" $file_string ] {
set native_cflags "-m64"
}
- } elseif [istarget "x86_64-*-linux*"] {
+ } elseif [[istarget "i*86-*-linux*"] || [istarget "x86_64-*-linux*"]] {
set file_string [exec file "linkage-x.o"]
if [ string match "*32-bit*" $file_string ] {
set native_cflags "-m32"
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: PING: PATCH: Also check -m32 for i*86-*-linux*
2009-11-17 18:48 PING: PATCH: Also check -m32 for i*86-*-linux* H.J. Lu
@ 2009-11-18 10:29 ` Andreas Schwab
2009-11-18 16:16 ` H.J. Lu
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Schwab @ 2009-11-18 10:29 UTC (permalink / raw)
To: H.J. Lu; +Cc: gcc-patches, janis187
"H.J. Lu" <hjl.tools@gmail.com> writes:
> diff --git a/gcc/testsuite/gcc.misc-tests/linkage.exp b/gcc/testsuite/gcc.misc-tests/linkage.exp
> index 05c0311..768975a 100644
> --- a/gcc/testsuite/gcc.misc-tests/linkage.exp
> +++ b/gcc/testsuite/gcc.misc-tests/linkage.exp
> @@ -57,7 +57,7 @@ if { [isnative] && ![is_remote host] } then {
> if [ string match "*64-bit*" $file_string ] {
> set native_cflags "-m64"
> }
> - } elseif [istarget "x86_64-*-linux*"] {
> + } elseif [[istarget "i*86-*-linux*"] || [istarget "x86_64-*-linux*"]] {
You want to put braces, not brackets, around the expression.
Andreas.
--
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E
"And now for something completely different."
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: PING: PATCH: Also check -m32 for i*86-*-linux*
2009-11-18 10:29 ` Andreas Schwab
@ 2009-11-18 16:16 ` H.J. Lu
2009-11-18 17:41 ` Janis Johnson
0 siblings, 1 reply; 4+ messages in thread
From: H.J. Lu @ 2009-11-18 16:16 UTC (permalink / raw)
To: Andreas Schwab; +Cc: gcc-patches, janis187
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
On Wed, Nov 18, 2009 at 2:01 AM, Andreas Schwab <schwab@redhat.com> wrote:
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>
>> diff --git a/gcc/testsuite/gcc.misc-tests/linkage.exp b/gcc/testsuite/gcc.misc-tests/linkage.exp
>> index 05c0311..768975a 100644
>> --- a/gcc/testsuite/gcc.misc-tests/linkage.exp
>> +++ b/gcc/testsuite/gcc.misc-tests/linkage.exp
>> @@ -57,7 +57,7 @@ if { [isnative] && ![is_remote host] } then {
>> if [ string match "*64-bit*" $file_string ] {
>> set native_cflags "-m64"
>> }
>> - } elseif [istarget "x86_64-*-linux*"] {
>> + } elseif [[istarget "i*86-*-linux*"] || [istarget "x86_64-*-linux*"]] {
>
> You want to put braces, not brackets, around the expression.
>
Here is the updated patch. OK for trunk?
Thanks.
--
H.J.
[-- Attachment #2: gcc-m32-4.patch --]
[-- Type: text/x-csrc, Size: 729 bytes --]
2009-11-17 H.J. Lu <hongjiu.lu@intel.com>
* gcc.misc-tests/linkage.exp: Also check -m32 for i*86-*-linux*.
diff --git a/gcc/testsuite/gcc.misc-tests/linkage.exp b/gcc/testsuite/gcc.misc-tests/linkage.exp
index 05c0311..768975a 100644
--- a/gcc/testsuite/gcc.misc-tests/linkage.exp
+++ b/gcc/testsuite/gcc.misc-tests/linkage.exp
@@ -57,7 +57,7 @@ if { [isnative] && ![is_remote host] } then {
if [ string match "*64-bit*" $file_string ] {
set native_cflags "-m64"
}
- } elseif [istarget "x86_64-*-linux*"] {
+ } elseif {[istarget "i*86-*-linux*"] || [istarget "x86_64-*-linux*"]} {
set file_string [exec file "linkage-x.o"]
if [ string match "*32-bit*" $file_string ] {
set native_cflags "-m32"
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: PING: PATCH: Also check -m32 for i*86-*-linux*
2009-11-18 16:16 ` H.J. Lu
@ 2009-11-18 17:41 ` Janis Johnson
0 siblings, 0 replies; 4+ messages in thread
From: Janis Johnson @ 2009-11-18 17:41 UTC (permalink / raw)
To: H.J. Lu; +Cc: Andreas Schwab, gcc-patches
On Wed, 2009-11-18 at 08:11 -0800, H.J. Lu wrote:
> On Wed, Nov 18, 2009 at 2:01 AM, Andreas Schwab <schwab@redhat.com> wrote:
> > "H.J. Lu" <hjl.tools@gmail.com> writes:
> >
> >> diff --git a/gcc/testsuite/gcc.misc-tests/linkage.exp b/gcc/testsuite/gcc.misc-tests/linkage.exp
> >> index 05c0311..768975a 100644
> >> --- a/gcc/testsuite/gcc.misc-tests/linkage.exp
> >> +++ b/gcc/testsuite/gcc.misc-tests/linkage.exp
> >> @@ -57,7 +57,7 @@ if { [isnative] && ![is_remote host] } then {
> >> if [ string match "*64-bit*" $file_string ] {
> >> set native_cflags "-m64"
> >> }
> >> - } elseif [istarget "x86_64-*-linux*"] {
> >> + } elseif [[istarget "i*86-*-linux*"] || [istarget "x86_64-*-linux*"]] {
> >
> > You want to put braces, not brackets, around the expression.
> >
>
> Here is the updated patch. OK for trunk?
OK.
Janis
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-11-18 17:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-17 18:48 PING: PATCH: Also check -m32 for i*86-*-linux* H.J. Lu
2009-11-18 10:29 ` Andreas Schwab
2009-11-18 16:16 ` H.J. Lu
2009-11-18 17:41 ` Janis Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).