Re: plugin event for C/C++ declarations

["H.J. Lu" <hjl.tools@gmail.com>]

On Tue, Dec 22, 2009 at 10:42 AM, Brian Hackett <bhackett1024@gmail.com> wrote:
> Where should texi ChangeLog changes go?  There's no changelog in
> gcc/doc and no .texi updates in gcc/ChangeLog.

They should be listed in gcc/ChanngeLog:

[hjl@gnu-6 gcc]$ grep doc/ gcc/ChangeLog | head -10
	* doc/plugins.texi: Rename pre-genericize event.
	* doc/invoke.texi: Fix typo.
	* doc/tm.texi (ARG_POINTER_CFA_OFFSET): Document new default.
	* doc/rtl.texi (Vector Operations): Clarify vec_select result mode.
	* doc/invoke.texi, doc/options.texi, doc/plugins.texi,
	doc/tm.texi: Fix typos.
	* doc/extend.texi (Function Attributes, Extended Asm):
	* doc/md.texi (Standard Names): Likewise.
	* doc/plugins.texi (Plugins): Likewise.
	* doc/c-tree.texi (Expression trees): Use @itemx for all but
[hjl@gnu-6 gcc]$

> Brian
>
> On Tue, Dec 22, 2009 at 10:24 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Tue, Dec 22, 2009 at 10:16 AM, Brian Hackett <bhackett1024@gmail.com> wrote:
>>> Hi, I added comments/documentation in plugin.def and doc/plugins.texi
>>> consistent with other plugins.  Is there another place documentation
>>> should go?
>>
>> doc/plugins.texi isn't mentioned in ChangeLog.
>>
>>
>> H.J.
>> ---
>>> Brian
>>>
>>> On Tue, Dec 22, 2009 at 10:13 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>> On Tue, Dec 22, 2009 at 10:00 AM, Brian Hackett <bhackett1024@gmail.com> wrote:
>>>>> Hi, this patch adds a new plugin event FINISH_DECL, which is invoked
>>>>> at every finish_decl in the C and C++ frontends.  Previously there did
>>>>> not seem to be a way for a plugin to see the definition for a global
>>>>> that is never used in the input file, or the initializer for a global
>>>>> which is declared before a function but defined after.  This event
>>>>> isn't restricted to just globals though, but also locals, fields, and
>>>>> parameters (C frontend only).
>>>>>
>>>>> Brian
>>>>>
>>>>>
>>>>>
>>>>> 2009-12-22  Brian Hackett  <bhackett1024@gmail.com>
>>>>>
>>>>> gcc/ChangeLog:
>>>>>
>>>>>        * plugin.def: Add event for finish_decl.
>>>>>        * plugin.c (register_callback, invoke_plugin_callbacks): Same.
>>>>>        * c-decl.c (finish_decl): Invoke callbacks on above event.
>>>>>
>>>>
>>>> Shouldn't it be documented?
>>>>
>>>>
>>
>



-- 
H.J.